From 464591438380c96730375b3d2ab71ec37c01a801 Mon Sep 17 00:00:00 2001 From: Addison Beck Date: Tue, 17 Aug 2021 13:12:55 -0400 Subject: [PATCH] Reference Events Fixups (#1518) * made salesAssistedTrialStarted nullable * removed conditional logic surrounding directory sync events * changed the value of the CipherCreated reference event enum --- src/Core/Enums/ReferenceEventType.cs | 2 +- src/Core/Models/Business/ReferenceEvent.cs | 2 +- src/Core/Services/Implementations/OrganizationService.cs | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/Core/Enums/ReferenceEventType.cs b/src/Core/Enums/ReferenceEventType.cs index b2c1b32abc..af3113c353 100644 --- a/src/Core/Enums/ReferenceEventType.cs +++ b/src/Core/Enums/ReferenceEventType.cs @@ -32,7 +32,7 @@ namespace Bit.Core.Enums DirectorySynced, [EnumMember(Value = "vault-imported")] VaultImported, - [EnumMember(Value = "secret-added")] + [EnumMember(Value = "cipher-created")] CipherCreated, [EnumMember(Value = "group-created")] GroupCreated, diff --git a/src/Core/Models/Business/ReferenceEvent.cs b/src/Core/Models/Business/ReferenceEvent.cs index 1952e13746..f4eedde6fc 100644 --- a/src/Core/Models/Business/ReferenceEvent.cs +++ b/src/Core/Models/Business/ReferenceEvent.cs @@ -60,6 +60,6 @@ namespace Bit.Core.Models.Business public string EventRaisedByUser { get; set; } - public bool SalesAssistedTrialStarted { get; set; } + public bool? SalesAssistedTrialStarted { get; set; } } } diff --git a/src/Core/Services/Implementations/OrganizationService.cs b/src/Core/Services/Implementations/OrganizationService.cs index 7fcb08f958..9be13b12cf 100644 --- a/src/Core/Services/Implementations/OrganizationService.cs +++ b/src/Core/Services/Implementations/OrganizationService.cs @@ -1981,11 +1981,8 @@ namespace Bit.Core.Services } } - if (_currentContext.ClientId == BitwardenClient.DirectoryConnector) - { - await _referenceEventService.RaiseEventAsync( - new ReferenceEvent(ReferenceEventType.DirectorySynced, organization)); - } + await _referenceEventService.RaiseEventAsync( + new ReferenceEvent(ReferenceEventType.DirectorySynced, organization)); } public async Task RotateApiKeyAsync(Organization organization)