From 4b3abe6fb0ca77529bd643b34fcb6370050a0ee0 Mon Sep 17 00:00:00 2001 From: Addison Beck Date: Fri, 4 Sep 2020 14:16:49 -0400 Subject: [PATCH] stopped manually encoding the SSO user_identifier (#913) --- bitwarden_license/src/Sso/Controllers/AccountController.cs | 2 -- src/Api/Controllers/AccountsController.cs | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/bitwarden_license/src/Sso/Controllers/AccountController.cs b/bitwarden_license/src/Sso/Controllers/AccountController.cs index 3ad20fe043..e01bd436cb 100644 --- a/bitwarden_license/src/Sso/Controllers/AccountController.cs +++ b/bitwarden_license/src/Sso/Controllers/AccountController.cs @@ -374,8 +374,6 @@ namespace Bit.Sso.Controllers } else { - var bytes = System.Convert.FromBase64String(userIdentifier); - userIdentifier = System.Text.Encoding.UTF8.GetString(bytes); var split = userIdentifier.Split(","); if (split.Length < 2) { diff --git a/src/Api/Controllers/AccountsController.cs b/src/Api/Controllers/AccountsController.cs index 45a5dd762f..e14220f303 100644 --- a/src/Api/Controllers/AccountsController.cs +++ b/src/Api/Controllers/AccountsController.cs @@ -731,8 +731,7 @@ namespace Bit.Api.Controllers { var user = await _userService.GetUserByPrincipalAsync(User); var token = await _userService.GenerateSignInTokenAsync(user, TokenPurposes.LinkSso); - var bytes = Encoding.UTF8.GetBytes($"{user.Id},{token}"); - var userIdentifier = Convert.ToBase64String(bytes); + var userIdentifier = $"{user.Id},{token}"; return userIdentifier; } }