mirror of
https://github.com/bitwarden/server
synced 2026-01-07 02:53:38 +00:00
[PM-20041] Deleting Notifications when Task is completed (#5896)
* mark all notifications associated with a security task as deleted when the task is completed * fix spelling * formatting * refactor "Active" to "NonDeleted" * refactor "Active" to "NonDeleted" for stored procedure * only send notifications per user for each notification * move notification status updates into the DB layer to save on multiple queries and insertions from the C# * Only return UserIds from db layer * omit userId from `MarkTaskAsCompletedCommand` query. The userId from the notification will be used * update UserIds * consistency in comments regarding `taskId` and `UserId`
This commit is contained in:
@@ -14,15 +14,19 @@ public class MarkTaskAsCompletedCommand : IMarkTaskAsCompleteCommand
|
||||
private readonly ISecurityTaskRepository _securityTaskRepository;
|
||||
private readonly IAuthorizationService _authorizationService;
|
||||
private readonly ICurrentContext _currentContext;
|
||||
private readonly IMarkNotificationsForTaskAsDeletedCommand _markNotificationsForTaskAsDeletedAsync;
|
||||
|
||||
|
||||
public MarkTaskAsCompletedCommand(
|
||||
ISecurityTaskRepository securityTaskRepository,
|
||||
IAuthorizationService authorizationService,
|
||||
ICurrentContext currentContext)
|
||||
ICurrentContext currentContext,
|
||||
IMarkNotificationsForTaskAsDeletedCommand markNotificationsForTaskAsDeletedAsync)
|
||||
{
|
||||
_securityTaskRepository = securityTaskRepository;
|
||||
_authorizationService = authorizationService;
|
||||
_currentContext = currentContext;
|
||||
_markNotificationsForTaskAsDeletedAsync = markNotificationsForTaskAsDeletedAsync;
|
||||
}
|
||||
|
||||
/// <inheritdoc />
|
||||
@@ -46,5 +50,8 @@ public class MarkTaskAsCompletedCommand : IMarkTaskAsCompleteCommand
|
||||
task.RevisionDate = DateTime.UtcNow;
|
||||
|
||||
await _securityTaskRepository.ReplaceAsync(task);
|
||||
|
||||
// Mark all notifications related to this task as deleted
|
||||
await _markNotificationsForTaskAsDeletedAsync.MarkAsDeletedAsync(taskId);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user