1
0
mirror of https://github.com/bitwarden/server synced 2025-12-29 06:33:43 +00:00

[PM-20041] Deleting Notifications when Task is completed (#5896)

* mark all notifications associated with a security task as deleted when the task is completed

* fix spelling

* formatting

* refactor "Active" to "NonDeleted"

* refactor "Active" to "NonDeleted" for stored procedure

* only send notifications per user for each notification

* move notification status updates into the DB layer to save on multiple queries and insertions from the C#

* Only return UserIds from db layer

* omit userId from `MarkTaskAsCompletedCommand` query.

The userId from the notification will be used

* update UserIds

* consistency in comments regarding `taskId` and `UserId`
This commit is contained in:
Nick Krantz
2025-06-27 16:04:47 -05:00
committed by GitHub
parent c441fa27dd
commit 69b7600eab
10 changed files with 198 additions and 2 deletions

View File

@@ -56,4 +56,21 @@ public class NotificationRepository : Repository<Notification, Guid>, INotificat
ContinuationToken = data.Count < pageOptions.PageSize ? null : (pageNumber + 1).ToString()
};
}
public async Task<IEnumerable<Guid>> MarkNotificationsAsDeletedByTask(Guid taskId)
{
await using var connection = new SqlConnection(ConnectionString);
var results = await connection.QueryAsync<Guid>(
"[dbo].[Notification_MarkAsDeletedByTask]",
new
{
TaskId = taskId,
},
commandType: CommandType.StoredProcedure);
var data = results.ToList();
return data;
}
}