bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-01-02 08:33:48 +00:00
Code Issues Releases Wiki Activity

fix(auth-validator): [PM-22975] Client Version Validator - Rename function

Browse Source
This commit is contained in:
Patrick Pimentel
2025-12-15 12:00:42 -05:00
parent 06224d9969
commit 6a5518a037
7 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Identity/IdentityServer/RequestValidators/BaseRequestValidator.cs
View File

@@ -222,7 +222,7 @@ public abstract class BaseRequestValidator<T> where T : class
/// <returns>true if the scheme successfully passed validation, otherwise false.</returns>
private async Task<bool> ValidateClientVersionAsync(T context, CustomValidatorRequestContext validatorContext)
{
var ok = _clientVersionValidator.ValidateAsync(validatorContext.User, validatorContext);
var ok = _clientVersionValidator.Validate(validatorContext.User, validatorContext);
if (ok)
{
return true;

4
src/Identity/IdentityServer/RequestValidators/ClientVersionValidator.cs
View File

@@ -8,7 +8,7 @@ namespace Bit.Identity.IdentityServer.RequestValidators;
public interface IClientVersionValidator
{
bool ValidateAsync(User user, CustomValidatorRequestContext requestContext);
bool Validate(User user, CustomValidatorRequestContext requestContext);
}
/// <summary>
@@ -28,7 +28,7 @@ public class ClientVersionValidator(
private const string _noUserMessage = "No user found while trying to validate client version";
private const string _versionHeaderMissing = "No client version header found, required to prevent encryption errors. Please confirm your client is supplying the header: \"Bitwarden-Client-Version\"";
public bool ValidateAsync(User? user, CustomValidatorRequestContext requestContext)
public bool Validate(User? user, CustomValidatorRequestContext requestContext)
{
// Do this nullish check because the base request validator currently is not
// strict null checking. Once that gets fixed then we can see about making