From 6b4afa269c798a1b24615ce736a0de79a5760480 Mon Sep 17 00:00:00 2001 From: Ike Kottlowski Date: Mon, 2 Feb 2026 16:01:26 -0500 Subject: [PATCH] fix: address TSQL formatting and documentation concerns and a misspelling. --- src/Core/Auth/Enums/EmergencyAccessStatusType.cs | 2 +- .../EmergencyAccess_DeleteManyById.sql | 10 +++++----- .../2026-01-23_00_AddDeleteManyEmergencyAccess.sql | 10 +++++----- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Core/Auth/Enums/EmergencyAccessStatusType.cs b/src/Core/Auth/Enums/EmergencyAccessStatusType.cs index d817d6a950..45bd5fdee4 100644 --- a/src/Core/Auth/Enums/EmergencyAccessStatusType.cs +++ b/src/Core/Auth/Enums/EmergencyAccessStatusType.cs @@ -19,7 +19,7 @@ public enum EmergencyAccessStatusType : byte /// RecoveryInitiated = 3, /// - /// The grantee has excercised their emergency access. + /// The grantee has exercised their emergency access. /// RecoveryApproved = 4, } diff --git a/src/Sql/dbo/Auth/Stored Procedures/EmergencyAccess_DeleteManyById.sql b/src/Sql/dbo/Auth/Stored Procedures/EmergencyAccess_DeleteManyById.sql index 98e4752d48..75677ebbd9 100644 --- a/src/Sql/dbo/Auth/Stored Procedures/EmergencyAccess_DeleteManyById.sql +++ b/src/Sql/dbo/Auth/Stored Procedures/EmergencyAccess_DeleteManyById.sql @@ -5,20 +5,20 @@ BEGIN SET NOCOUNT ON DECLARE @UserIds AS [GuidIdArray]; + DECLARE @BatchSize INT = 100 INSERT INTO @UserIds SELECT DISTINCT [GranteeId] FROM [dbo].[EmergencyAccess] EA - INNER JOIN + INNER JOIN @EmergencyAccessIds EAI ON EAI.[Id] = EA.[Id] WHERE - EA.[Status] = 2 - AND + EA.[Status] = 2 -- 2 = Bit.Core.Auth.Enums.EmergencyAccessStatusType.Confirmed + AND EA.[GranteeId] IS NOT NULL - DECLARE @BatchSize INT = 100 -- Delete EmergencyAccess Records WHILE @BatchSize > 0 @@ -27,7 +27,7 @@ BEGIN DELETE TOP(@BatchSize) EA FROM [dbo].[EmergencyAccess] EA - INNER JOIN + INNER JOIN @EmergencyAccessIds EAI ON EAI.[Id] = EA.[Id] SET @BatchSize = @@ROWCOUNT diff --git a/util/Migrator/DbScripts/2026-01-23_00_AddDeleteManyEmergencyAccess.sql b/util/Migrator/DbScripts/2026-01-23_00_AddDeleteManyEmergencyAccess.sql index 30f2c3d950..f3ffb7ed07 100644 --- a/util/Migrator/DbScripts/2026-01-23_00_AddDeleteManyEmergencyAccess.sql +++ b/util/Migrator/DbScripts/2026-01-23_00_AddDeleteManyEmergencyAccess.sql @@ -5,20 +5,20 @@ BEGIN SET NOCOUNT ON DECLARE @UserIds AS [GuidIdArray]; + DECLARE @BatchSize INT = 100 INSERT INTO @UserIds SELECT DISTINCT [GranteeId] FROM [dbo].[EmergencyAccess] EA - INNER JOIN + INNER JOIN @EmergencyAccessIds EAI ON EAI.[Id] = EA.[Id] WHERE - EA.[Status] = 2 - AND + EA.[Status] = 2 -- 2 = Bit.Core.Auth.Enums.EmergencyAccessStatusType.Confirmed + AND EA.[GranteeId] IS NOT NULL - DECLARE @BatchSize INT = 100 -- Delete EmergencyAccess Records WHILE @BatchSize > 0 @@ -27,7 +27,7 @@ BEGIN DELETE TOP(@BatchSize) EA FROM [dbo].[EmergencyAccess] EA - INNER JOIN + INNER JOIN @EmergencyAccessIds EAI ON EAI.[Id] = EA.[Id] SET @BatchSize = @@ROWCOUNT