bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2025-12-06 00:03:34 +00:00
Code Issues Releases Wiki Activity

chore(flag-removal): [Auth/PM20439] Remove Flagging Logic for BrowserExtensionLoginApproval (#6368)

Browse Source
This commit is contained in:
rr-bw
2025-09-29 13:29:18 -07:00
committed by GitHub
parent f6b99a7906
commit 8784907736
2 changed files with 8 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Api/Auth/Controllers/AuthRequestsController.cs
View File

@@ -3,7 +3,6 @@
using Bit.Api.Auth.Models.Response; using Bit.Api.Auth.Models.Response;
using Bit.Api.Models.Response; using Bit.Api.Models.Response;
using Bit.Core;
using Bit.Core.Auth.Enums; using Bit.Core.Auth.Enums;
using Bit.Core.Auth.Identity; using Bit.Core.Auth.Identity;
using Bit.Core.Auth.Models.Api.Request.AuthRequest; using Bit.Core.Auth.Models.Api.Request.AuthRequest;
@@ -12,7 +11,6 @@ using Bit.Core.Exceptions;
using Bit.Core.Repositories; using Bit.Core.Repositories;
using Bit.Core.Services; using Bit.Core.Services;
using Bit.Core.Settings; using Bit.Core.Settings;
using Bit.Core.Utilities;
using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
@@ -55,7 +53,6 @@ public class AuthRequestsController(
} }
[HttpGet("pending")] [HttpGet("pending")]
[RequireFeature(FeatureFlagKeys.BrowserExtensionLoginApproval)]
public async Task<ListResponseModel<PendingAuthRequestResponseModel>> GetPendingAuthRequestsAsync() public async Task<ListResponseModel<PendingAuthRequestResponseModel>> GetPendingAuthRequestsAsync()
{ {
var userId = _userService.GetProperUserId(User).Value; var userId = _userService.GetProperUserId(User).Value;

31
src/Identity/Utilities/LoginApprovingClientTypes.cs
View File

@@ -1,6 +1,4 @@
using Bit.Core; using Bit.Core.Enums;
using Bit.Core.Enums;
using Bit.Core.Services;
namespace Bit.Identity.Utilities; namespace Bit.Identity.Utilities;
@@ -11,28 +9,15 @@ public interface ILoginApprovingClientTypes
public class LoginApprovingClientTypes : ILoginApprovingClientTypes public class LoginApprovingClientTypes : ILoginApprovingClientTypes
{ {
public LoginApprovingClientTypes( public LoginApprovingClientTypes()
IFeatureService featureService)
{ {
if (featureService.IsEnabled(FeatureFlagKeys.BrowserExtensionLoginApproval)) TypesThatCanApprove = new List<ClientType>
{ {
TypesThatCanApprove = new List<ClientType> ClientType.Desktop,
{ ClientType.Mobile,
ClientType.Desktop, ClientType.Web,
ClientType.Mobile, ClientType.Browser,
ClientType.Web, };
ClientType.Browser,
};
}
else
{
TypesThatCanApprove = new List<ClientType>
{
ClientType.Desktop,
ClientType.Mobile,
ClientType.Web,
};
}
} }
public IReadOnlyCollection<ClientType> TypesThatCanApprove { get; } public IReadOnlyCollection<ClientType> TypesThatCanApprove { get; }