From 87877aeb3da7c8b953f89abf0a6fbb7325e4f23b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rui=20Tom=C3=A9?=
<108268980+r-tome@users.noreply.github.com>
Date: Wed, 13 Aug 2025 15:01:51 +0100
Subject: [PATCH] [PM-24414] Remove CollectionType property from the public
CollectionResponseModel (#6180)
---
src/Api/Models/Public/Response/CollectionResponseModel.cs | 6 ------
.../Public/Controllers/CollectionsControllerTests.cs | 1 -
2 files changed, 7 deletions(-)
diff --git a/src/Api/Models/Public/Response/CollectionResponseModel.cs b/src/Api/Models/Public/Response/CollectionResponseModel.cs
index 2d13f982cd..04ae565a27 100644
--- a/src/Api/Models/Public/Response/CollectionResponseModel.cs
+++ b/src/Api/Models/Public/Response/CollectionResponseModel.cs
@@ -4,7 +4,6 @@
using System.ComponentModel.DataAnnotations;
using Bit.Api.AdminConsole.Public.Models.Response;
using Bit.Core.Entities;
-using Bit.Core.Enums;
using Bit.Core.Models.Data;
namespace Bit.Api.Models.Public.Response;
@@ -24,7 +23,6 @@ public class CollectionResponseModel : CollectionBaseModel, IResponseModel
Id = collection.Id;
ExternalId = collection.ExternalId;
Groups = groups?.Select(c => new AssociationWithPermissionsResponseModel(c));
- Type = collection.Type;
}
///
@@ -43,8 +41,4 @@ public class CollectionResponseModel : CollectionBaseModel, IResponseModel
/// The associated groups that this collection is assigned to.
///
public IEnumerable Groups { get; set; }
- ///
- /// The type of this collection
- ///
- public CollectionType Type { get; set; }
}
diff --git a/test/Api.Test/Public/Controllers/CollectionsControllerTests.cs b/test/Api.Test/Public/Controllers/CollectionsControllerTests.cs
index d896fc9c74..9cfafbac54 100644
--- a/test/Api.Test/Public/Controllers/CollectionsControllerTests.cs
+++ b/test/Api.Test/Public/Controllers/CollectionsControllerTests.cs
@@ -67,7 +67,6 @@ public class CollectionsControllerTests
var jsonResult = Assert.IsType(result);
var response = Assert.IsType(jsonResult.Value);
Assert.Equal(collection.Id, response.Id);
- Assert.Equal(collection.Type, response.Type);
}
[Theory, BitAutoData]