bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-01-02 16:43:25 +00:00
Code Issues Releases Wiki Activity

test(auth-validator): [PM-22975] Client Version Validator - WIP changes.

Browse Source
This commit is contained in:
Patrick Pimentel
2025-12-02 13:46:23 -05:00
parent 8f89694f07
commit 8b8694e589
13 changed files with 65 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test/IntegrationTestCommon/Factories/IdentityApplicationFactory.cs
View File

@@ -75,8 +75,20 @@ public class IdentityApplicationFactory : WebApplicationFactoryBase<Startup>
var context = await ContextFromPasswordAsync(
username, password, deviceIdentifier, clientId, deviceType, deviceName);
using var body = await AssertHelper.AssertResponseTypeIs<JsonDocument>(context);
var root = body.RootElement;
// Provide clearer diagnostics on failure
if (context.Response.StatusCode != StatusCodes.Status200OK)
{
var contentType = context.Response.ContentType ?? string.Empty;
if (context.Response.Body.CanSeek)
{
context.Response.Body.Position = 0;
}
string rawBody = await new StreamReader(context.Response.Body).ReadToEndAsync();
throw new Xunit.Sdk.XunitException($"Login failed: status={context.Response.StatusCode}, contentType='{contentType}', body='{rawBody}'");
}
using var jsonDoc = await AssertHelper.AssertResponseTypeIs<JsonDocument>(context);
var root = jsonDoc.RootElement;
return (root.GetProperty("access_token").GetString(), root.GetProperty("refresh_token").GetString());
}
@@ -99,7 +111,13 @@ public class IdentityApplicationFactory : WebApplicationFactoryBase<Startup>
{ "grant_type", "password" },
{ "username", username },
{ "password", password },
}));
}),
http =>
{
// Ensure JSON content negotiation for errors and set a sane client version
http.Request.Headers.Append("Accept", "application/json");
http.Request.Headers.Append("Bitwarden-Client-Version", "2025.11.0");
});
return context;
}

3
test/IntegrationTestCommon/Factories/WebApplicationFactoryExtensions.cs
View File

@@ -23,9 +23,6 @@ public static class WebApplicationFactoryExtensions
// it runs after this so it will take precedence.
httpContext.Connection.RemoteIpAddress = IPAddress.Parse(FactoryConstants.WhitelistedIp);
// Ensure response body is bufferable and seekable for tests to read later
httpContext.Response.Body = new MemoryStream();
httpContext.Request.Path = new PathString(requestUri);
httpContext.Request.Method = method.Method;