bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-01-01 16:13:33 +00:00
Code Issues Releases Wiki Activity

Prepare for send direct upload (#1174)

Browse Source 
* Add sendId to path

Event Grid returns the blob path, which will be used to grab a Send and verify file size

* Re-validate access upon file download

Increment access count only when file is downloaded. File
name and size are leaked, but this is a good first step toward
solving the access-download race
This commit is contained in:
Matt Gibson
2021-03-01 15:01:04 -06:00
committed by GitHub
parent 13f12aaf58
commit 8d5fc21b51
7 changed files with 119 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Core/Services/NoopImplementations/NoopSendFileStorageService.cs
View File

@@ -12,7 +12,7 @@ namespace Bit.Core.Services
return Task.FromResult(0);
}
public Task DeleteFileAsync(string fileId)
public Task DeleteFileAsync(Send send, string fileId)
{
return Task.FromResult(0);
}
@@ -27,7 +27,7 @@ namespace Bit.Core.Services
return Task.FromResult(0);
}
public Task<string> GetSendFileDownloadUrlAsync(string fileId)
public Task<string> GetSendFileDownloadUrlAsync(Send send, string fileId)
{
return Task.FromResult((string)null);
}