[SM-823] ApiKey table follow up (#3183)

* dbo_future -> dbo

* DbScripts_future -> DbScripts

* Remove deprecated property

* Move data_migration -> DbScripts

src/Sql/SecretsManager/dbo/Stored Procedures/ApiKey/ApiKey_Create.sql

@@ -2,8 +2,7 @@ CREATE PROCEDURE [dbo].[ApiKey_Create]
     @Id UNIQUEIDENTIFIER OUTPUT,
     @ServiceAccountId UNIQUEIDENTIFIER,
     @Name VARCHAR(200),
-    @ClientSecret VARCHAR(30) = 'migrated', -- Deprecated as of 2023-05-17
-    @ClientSecretHash VARCHAR(128) = NULL,
+    @ClientSecretHash VARCHAR(128),
     @Scope NVARCHAR(4000),
     @EncryptedPayload NVARCHAR(4000),
     @Key VARCHAR(MAX),
@@ -14,18 +13,11 @@ AS
 BEGIN
     SET NOCOUNT ON
 
-    IF (@ClientSecretHash IS NULL)
-    BEGIN
-      DECLARE @hb VARBINARY(128) = HASHBYTES('SHA2_256', @ClientSecret);
-      SET @ClientSecretHash = CAST(N'' as xml).value('xs:base64Binary(sql:variable("@hb"))', 'VARCHAR(128)');
-    END
-
-    INSERT INTO [dbo].[ApiKey] 
+    INSERT INTO [dbo].[ApiKey]
     (
         [Id],
         [ServiceAccountId],
         [Name],
-        [ClientSecret],
         [ClientSecretHash],
         [Scope],
         [EncryptedPayload],
@@ -34,12 +26,11 @@ BEGIN
         [CreationDate],
         [RevisionDate]
     )
-    VALUES 
+    VALUES
     (
         @Id,
         @ServiceAccountId,
         @Name,
-        @ClientSecret,
         @ClientSecretHash,
         @Scope,
         @EncryptedPayload,

src/Sql/SecretsManager/dbo/Tables/ApiKey.sql

@@ -2,7 +2,6 @@
     [Id]                    UNIQUEIDENTIFIER,
     [ServiceAccountId]      UNIQUEIDENTIFIER NULL,
     [Name]                  VARCHAR(200) NOT NULL,
-    [ClientSecret]          VARCHAR(30) NOT NULL,
     [ClientSecretHash]      VARCHAR(128) NULL,
     [Scope]                 NVARCHAR (4000) NOT NULL,
     [EncryptedPayload]      NVARCHAR (4000) NOT NULL,