bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2025-12-16 00:03:54 +00:00
Code Issues Releases Wiki Activity

update cipher service and tests

Browse Source
This commit is contained in:
jaasen-livefront
2025-12-03 17:12:05 -08:00
parent 23b5c76b86
commit b24edfac43
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Core/Vault/Services/Implementations/CipherService.cs
View File

@@ -723,6 +723,7 @@ public class CipherService : ICipherService
// If the cipher was archived, clear the archived date when soft deleting // If the cipher was archived, clear the archived date when soft deleting
// If a user were to restore an archived cipher, it should go back to the vault not the archive vault // If a user were to restore an archived cipher, it should go back to the vault not the archive vault
cipherDetails.ArchivedDate = null; cipherDetails.ArchivedDate = null;
cipherDetails.Archives = null;
} }
await _securityTaskRepository.MarkAsCompleteByCipherIds([cipherDetails.Id]); await _securityTaskRepository.MarkAsCompleteByCipherIds([cipherDetails.Id]);

2
test/Core.Test/Vault/Services/CipherServiceTests.cs
View File

@@ -1829,6 +1829,8 @@ public class CipherServiceTests
await sutProvider.Sut.SoftDeleteAsync(cipherDetails, deletingUserId); await sutProvider.Sut.SoftDeleteAsync(cipherDetails, deletingUserId);
Assert.NotNull(cipherDetails.DeletedDate); Assert.NotNull(cipherDetails.DeletedDate);
// Archives should be cleared on soft delete
Assert.Null(cipherDetails.Archives);
Assert.Equal(cipherDetails.RevisionDate, cipherDetails.DeletedDate); Assert.Equal(cipherDetails.RevisionDate, cipherDetails.DeletedDate);
await sutProvider.GetDependency<ICipherRepository>().Received(1).UpsertAsync(cipherDetails); await sutProvider.GetDependency<ICipherRepository>().Received(1).UpsertAsync(cipherDetails);
await sutProvider.GetDependency<IEventService>().Received(1).LogCipherEventAsync(cipherDetails, EventType.Cipher_SoftDeleted); await sutProvider.GetDependency<IEventService>().Received(1).LogCipherEventAsync(cipherDetails, EventType.Cipher_SoftDeleted);