bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-01-06 10:34:01 +00:00
Code Issues Releases Wiki Activity

fix(auth-validator): [PM-22975] Client Version Validator - Updated validator to return false on null.

Browse Source
This commit is contained in:
Patrick Pimentel
2025-12-04 16:54:45 -05:00
parent 2ed458d5d4
commit d706796fc3
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Identity/IdentityServer/RequestValidators/ClientVersionValidator.cs
View File

@@ -30,9 +30,12 @@ public class ClientVersionValidator(
public async Task<bool> ValidateAsync(User? user, CustomValidatorRequestContext requestContext) public async Task<bool> ValidateAsync(User? user, CustomValidatorRequestContext requestContext)
{ {
// Do this nullish check because the base request validator currently is not
// strict null checking. Once that gets fixed then we can see about making
// the user not nullish checked. If they are null then the validator should fail.
if (user == null) if (user == null)
{ {
return true; return false;
} }
Version? clientVersion = currentContext.ClientVersion; Version? clientVersion = currentContext.ClientVersion;