From f56d424dcc9f1ce72459b8471f67fe6dcaf3a988 Mon Sep 17 00:00:00 2001 From: Mick Letofsky Date: Mon, 26 Jan 2026 16:02:34 +0100 Subject: [PATCH] Fixes from Claude Code review --- util/DbSeederUtility/Program.cs | 2 +- util/DbSeederUtility/README.md | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/util/DbSeederUtility/Program.cs b/util/DbSeederUtility/Program.cs index 789bd9e9ef..f1cbfc8b8f 100644 --- a/util/DbSeederUtility/Program.cs +++ b/util/DbSeederUtility/Program.cs @@ -23,7 +23,7 @@ public class Program string domain, [Option('c', "ciphers", Description = "Number of login ciphers to create")] int ciphers = 0, - [Option('s', "structure", Description = "Org structure for collections: Traditional, Spotify, or Modern")] + [Option('o', "org-structure", Description = "Org structure for collections: Traditional, Spotify, or Modern")] string? structure = null ) { diff --git a/util/DbSeederUtility/README.md b/util/DbSeederUtility/README.md index f900cd45e2..b6361bb163 100644 --- a/util/DbSeederUtility/README.md +++ b/util/DbSeederUtility/README.md @@ -34,6 +34,9 @@ DbSeeder.exe organization -n seeded -u 10000 -d large.test # Generate an organization with 5 users and 100 encrypted ciphers DbSeeder.exe organization -n TestOrg -u 5 -d test.com -c 100 +# Generate with Spotify-style collections (tribes, chapters, guilds) +DbSeeder.exe organization -n TestOrg -u 10 -d test.com -c 50 -o Spotify + # Generate a small test organization with ciphers for manual testing DbSeeder.exe organization -n DevOrg -u 2 -d dev.local -c 10 ``` @@ -46,15 +49,16 @@ DbSeeder.exe organization -n DevOrg -u 2 -d dev.local -c 10 | `-u, --users` | Number of member users to create | | `-d, --domain` | Email domain (e.g., test.com creates owner@test.com) | | `-c, --ciphers` | Number of encrypted ciphers to create (optional) | -| `-s, --status` | User status: Confirmed (default), Invited, Accepted, Revoked | +| `-o, --org-structure` | Collection structure: Traditional, Spotify, or Modern (optional) | ### Notes - All users are created with the password `asdfasdfasdf` - The owner account is always `owner@{domain}` with Confirmed status - Member accounts are `user0@{domain}`, `user1@{domain}`, etc. -- When ciphers are created, a "Default Collection" is automatically created and all users are granted access -- Ciphers are encrypted using dynamically generated organization keys +- Without `--org-structure`, a single "Default Collection" is created +- With `--org-structure`, collections are created from org model (e.g., Spotify creates tribes, chapters, guilds) +- Ciphers are encrypted and distributed across collections using dynamically generated organization keys ## Dependencies