bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2025-12-24 20:23:21 +00:00
Code Issues Releases Wiki Activity
5,484 Commits 480 Branches 222 Tags
bc27ec2b9b800c7dbb5ffd9e6454d44df144ef3c
Commit Graph

769 Commits

Author SHA1 Message Date
Vijay Oommen
17f5c97891 PM-6939 - Onyx Integration into freshdesk controller (#5365) 2025-02-06 08:13:17 -06:00
Rui Tomé
a12b61cc9e [PM-17168] Sync organization user revoked/restored status immediately via push notification (#5330) 
* [PM-17168] Add push notification for revoked and restored organization users

* Add feature flag for push notification on user revoke/restore actions

* Add tests for user revocation and restoration with push sync feature flag enabled
 2025-02-06 10:28:12 +00:00
SmithThe4th
46004b9c68 [PM-14381] Add POST /tasks/bulk-create endpoint (#5188) 
* [PM-14378] Introduce GetCipherPermissionsForOrganization query for Dapper CipherRepository

* [PM-14378] Introduce GetCipherPermissionsForOrganization method for Entity Framework

* [PM-14378] Add integration tests for new repository method

* [PM-14378] Introduce IGetCipherPermissionsForUserQuery CQRS query

* [PM-14378] Introduce SecurityTaskOperationRequirement

* [PM-14378] Introduce SecurityTaskAuthorizationHandler.cs

* [PM-14378] Introduce SecurityTaskOrganizationAuthorizationHandler.cs

* [PM-14378] Register new authorization handlers

* [PM-14378] Formatting

* [PM-14378] Add unit tests for GetCipherPermissionsForUserQuery

* [PM-15378] Cleanup SecurityTaskAuthorizationHandler and add tests

* [PM-14378] Add tests for SecurityTaskOrganizationAuthorizationHandler

* [PM-14378] Formatting

* [PM-14378] Update date in migration file

* [PM-14378] Add missing awaits

* Added bulk create request model

* Created sproc to create bulk security tasks

* Renamed tasks to SecurityTasksInput

* Added create many implementation for sqlserver and ef core

* removed trailing comma

* created ef implementatin for create many and added integration test

* Refactored request model

* Refactored request model

* created create many tasks command interface and class

* added security authorization handler work temp

* Added the implementation for the create manys tasks command

* Added comment

* Changed return to return list of created security tasks

* Registered command

* Completed bulk create action

* Added unit tests for the command

* removed hard coded table name

* Fixed lint issue

* Added JsonConverter attribute to allow enum value to be passed as string

* Removed makshift security task operations

* Fixed references

* Removed old migration

* Rebased

* [PM-14378] Introduce GetCipherPermissionsForOrganization query for Dapper CipherRepository

* [PM-14378] Introduce GetCipherPermissionsForOrganization method for Entity Framework

* [PM-14378] Add unit tests for GetCipherPermissionsForUserQuery

* Completed bulk create action

* bumped migration version

* Fixed lint issue

* Removed complex sql data type in favour of json string

* Register IGetTasksForOrganizationQuery

* Fixed lint issue

* Removed tasks grouping

* Fixed linting

* Removed unused code

* Removed unused code

* Aligned with client change

* Fixed linting

---------

Co-authored-by: Shane Melton <smelton@bitwarden.com>
 2025-02-05 16:56:01 -05:00
Rui Tomé
03c390de74 [PM-15637] Notify Custom Users with “Manage Account Recovery” permission for Device Approval Requests (#5359) 
* Add stored procedure to read organization user details by role

* Add OrganizationUserRepository method to retrieve OrganizationUser details by role

* Enhance AuthRequestService to send notifications to custom users with ManageResetPassword permission

* Enhance AuthRequestServiceTests to include custom user permissions and validate notification email recipients
 2025-02-05 14:47:06 +00:00
Jason Ng
412c6f9849 [PM-11162] Assign to Collection Permission Update (#4844) 
Only users with Manage/Edit permissions will be allowed to Assign To Collections. If the user has Can Edit Except Password the collections dropdown will be disabled.

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Co-authored-by: kejaeger <138028972+kejaeger@users.noreply.github.com>
 2025-02-04 15:45:24 -05:00
Brant DeBow
3f3da558b6 [PM-17562] Refactor existing RabbitMq implementation (#5357) 
* [PM-17562] Refactor existing RabbitMq implementation

* Fixed issues noted in PR review
 2025-02-04 09:02:43 -05:00
Alex Morask
f1b9bd9a09 [PM-15179] Implement endpoints to add existing organization to CB provider (#5310) 
* Implement endpoints to add existing organization to provider

* Run dotnet format

* Support MOE

* Run dotnet format

* Move ProviderClientsController under AC ownership

* Move ProviderClientsControllerTests under AC ownership

* Jared's feedback
 2025-02-04 09:02:18 -05:00
Justin Baur
408ddd9388 Scaffold Events Integration Tests (#5355) 
* Scaffold Events Integration Tests

* Format
 2025-01-31 11:08:07 -05:00
Jimmy Vo
bd394eabe9 [pm-16528] Fix entity framework query (#5333) 2025-01-31 09:50:14 -06:00
Todd Martin
e43a8011f1 [PM-17709] Send New Device Login email for all new devices (#5340) 
* Send New Device Login email regardless of New Device Verification

* Adjusted tests

* Linting

* Clarified test names.
 2025-01-31 10:46:09 -05:00
renovate[bot]
23dce58103 [deps] Billing: Update xunit to 2.9.3 (#5289) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-01-30 10:58:14 -05:00
Jimmy Vo
6d7bdb6ec0 Ac/pm 17217/add use policy check for accept endpoint(#5324) 2025-01-28 12:23:15 -05:00
renovate[bot]
5310f63514 [deps] Billing: Update coverlet.collector to 6.0.4 (#5219) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Morask <144709477+amorask-bitwarden@users.noreply.github.com>
 2025-01-27 09:17:18 -05:00
Rui Tomé
9e718d7336 [PM-15637] Add Email Notification Templates and Logic for Device Approval Requests (#5270) 
* Add device approval notification email templates

* Add DeviceApprovalRequestedViewModel for device approval notifications

* Add method to send device approval requested notification email

* Send email notification to Organization Admins when adding a new admin approval auth request

* Add tests for device approval notification email sending in AuthRequestServiceTests

* fix(email-templates): Remove unnecessary triple braces from user name variable in device approval notification emails

* Add feature flag for admin notifications on device approval requests

* Add logging for skipped admin notifications on device approval requests
 2025-01-27 10:59:46 +00:00
Rui Tomé
3908edd08f [PM-12489] Extract OrganizationService.DeleteAsync and OrganizationService.InitiateDeleteAsync into commands (#5279) 
* Create organization deletion command with logic extracted from OrganizationService

* Add unit tests for OrganizationDeleteCommand

* Register OrganizationDeleteCommand for dependency injection

* Refactor organization deletion logic to use IOrganizationDeleteCommand and remove legacy IOrganizationService.DeleteAsync method

* Add organization deletion initiation command and refactor service usage

* Enhance organization deletion commands with detailed XML documentation

* Refactor organization command registration to include sign-up and deletion methods
 2025-01-27 10:58:08 +00:00
Alex Morask
f140c7f6c1 [PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api (#5201) 
* Removed feature flag

* Run dotnet format

* Fix integration tests
 2025-01-24 13:38:35 -05:00
Graham Walker
99a1dbbe02 PM-16261 move ImportCiphersAsync to the tools team (#5245) 
* PM-16261 move ImportCiphersAsync to the tools team and create services using CQRS design pattern

* PM-16261 fix renaming methods and add unit tests for succes and bad request exception

* PM-16261 clean up old code from test
 2025-01-24 10:57:44 -06:00
Patrick-Pimentel-Bitwarden
275f7ceb27 Auth/pm 17233/tests for multiple users on single device for web approvals (#5316) 
* test(test-device-repository): [PM-17233] Add Test Case for Critical Bug Found in Device Repository - Added new test case for previously found bug.
 2025-01-23 11:21:28 -05:00
renovate[bot]
e8cd86e5f6 [deps] Billing: Update xunit.runner.visualstudio to v3 (#5183) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com>
 2025-01-23 12:51:57 +01:00
Rui Tomé
edb74add50 [PM-14243] Free organization limit is not enforced when editing user (#5155) 
* Enforce free organization limit when updating user

* Add test for throwing error on accepting admin user joining multiple free organizations

* Add test for throwing BadRequest when free organization admin attempts to sign up for another free organization

* Fix user ID handling in UpdateOrganizationUserCommand for free organizations

* Rename parameter 'user' to 'organizationUser' in UpdateUserAsync method for clarity
 2025-01-21 10:15:02 +00:00
Rui Tomé
04e5626c57 [PM-16777] Fix exception when bulk restoring revoked users who never accepted invitations (#5224) 
* Fix null handling for UserId in Two Factor Authentication checks

* Add tests for restoring users with and without 2FA policies
 2025-01-20 14:59:10 +00:00
Thomas Rittson
0c29e9227c Remove provider-export-permission feature flag (#5263) 
* also remove old CipherService and CollectionService methods
  only used by old export code
 2025-01-17 08:28:23 +10:00
Jonas Hendrickx
cc2128c97a [PM-16979] Avoid returning BillingTaxIdTypeInterferenceError when an … (#5252) 
* [PM-16979] Avoid returning BillingTaxIdTypeInterferenceError when an empty tax id string is passed

* tests

* fix tests
 2025-01-15 10:05:27 -05:00
Kyle Spearrin
aa0b35a345 [PM-15608] Create more KDF defaults for prelogin (#5122) 
* kdf defaults on null map to email hash

* cleanup code. add some randomness as well

* remove null check

* fix test

* move to private method

* remove random options

* tests for random defaults

* SetDefaultKdfHmacKey for old test
 2025-01-10 15:54:53 -05:00
Jared McCannon
730f83b425 Fixing misspelling. made changes to domain claim email. (#5248) 2025-01-10 14:19:52 -06:00
Jonas Hendrickx
45d2c5315d [PM-14894] Drop Tax Rate tables - Stage 1 (#5236) 2025-01-10 16:39:02 +01:00
Rui Tomé
fbfabf2651 [PM-15547] Fix two-factor authentication revocation logic and update related tests (#5246) 
* Fix two-factor authentication revocation logic and update related tests

* Refine test for RevokeNonCompliantOrganizationUserCommand to assert single user revocation
 2025-01-10 14:45:09 +00:00
Bernd Schoolmann
8a68f075cc Remove block legacy users feature flag (#5212) 2025-01-10 11:55:40 +01:00
Ike
ce2ecf9da0 [PM-12995] Create UI elements for New Device Verification in Admin Portal (#5165) 
* feat(NewDeviceVerification) :
- Added constant to constants in Bit.Core because the cache key format needs to be shared between the Identity Server and the MVC project Admin.
- Updated DeviceValidator class to handle checking cache for user information to allow pass through.
- Updated and Added tests to handle new flow.
- Adding exception flow to admin project. Added tests for new methods in UserService.
 2025-01-09 18:10:54 -08:00
Maciej Zieniuk
1988f1402e Repeating pattern values for BitAutoData attribute (#5167) 
* Repeating pattern values for BitAutoData attribute

* nullable enabled, added documentation

* execute test method even if no repeating pattern data provided (empty array).

* RepeatingPatternBitAutoDataAttribute unit tests
 2025-01-10 00:43:24 +01:00
Shane Melton
0605590ed2 [PM-14380] Add GET /tasks/organization endpoint (#5149) 
* [PM-14380] Add GetManyByOrganizationIdStatusAsync to SecurityTaskRepository

* [PM-14380] Introduce IGetTasksForOrganizationQuery

* [PM-14380] Add /tasks/organization endpoint

* [PM-14380] Add unit tests

* [PM-14380] Formatting

* [PM-14380] Bump migration script date

* [PM-14380] Bump migration script date
 2025-01-09 12:40:12 -08:00
Shane Melton
a99f82dddd [PM-14378] SecurityTask Authorization Handler (#5039) 
* [PM-14378] Introduce GetCipherPermissionsForOrganization query for Dapper CipherRepository

* [PM-14378] Introduce GetCipherPermissionsForOrganization method for Entity Framework

* [PM-14378] Add integration tests for new repository method

* [PM-14378] Introduce IGetCipherPermissionsForUserQuery CQRS query

* [PM-14378] Introduce SecurityTaskOperationRequirement

* [PM-14378] Introduce SecurityTaskAuthorizationHandler.cs

* [PM-14378] Introduce SecurityTaskOrganizationAuthorizationHandler.cs

* [PM-14378] Register new authorization handlers

* [PM-14378] Formatting

* [PM-14378] Add unit tests for GetCipherPermissionsForUserQuery

* [PM-15378] Cleanup SecurityTaskAuthorizationHandler and add tests

* [PM-14378] Add tests for SecurityTaskOrganizationAuthorizationHandler

* [PM-14378] Formatting

* [PM-14378] Update date in migration file

* [PM-14378] Add missing awaits

* [PM-14378] Bump migration script date

* [PM-14378] Remove Unassigned property from OrganizationCipherPermission as it was making the query too complicated

* [PM-14378] Update sproc to use Union All to improve query performance

* [PM-14378] Bump migration script date
 2025-01-09 12:14:24 -08:00
Jared McCannon
fd195e7cf3 Forgot to remove compliant users from the list. (#5241) 2025-01-09 14:13:29 -06:00
Conner Turnbull
6771f79597 Updated LicensingService to be a singleton again and moved IFeatureService up a frame in the call stack (#5238) 2025-01-09 12:40:16 -05:00
Jared McCannon
e754ae4729 [PM-10319] - Send 2FA Email when policy enabled (#5233) 
* Correcting which email is sent when enabling 2FA policy.

* Fixing the test.
 2025-01-09 09:35:40 -06:00
Todd Martin
a638f359e9 Revert updates to Microsoft.Extensions dependencies from v9 (#5235) 
* Revert "[deps] Tools: Update Microsoft.Extensions.Configuration to v9 (#5072)"

This reverts commit cb7cbb630a.

* Revert "[deps] Tools: Update Microsoft.Extensions.DependencyInjection to v9 (#5073)"

This reverts commit 0b026404db.
 2025-01-08 18:04:28 -05:00
Matt Bishop
92d9b88afb Provide new feature flag context for devices (#5226) 2025-01-08 13:54:34 -05:00
Ike
a84ef0724c [PM-15614] Allow Users to opt out of new device verification (#5176) 
feat(NewDeviceVerification) : 
* Created database migration scripts for VerifyDevices column in [dbo].[User].
* Updated DeviceValidator to check if user has opted out of device verification.
* Added endpoint to AccountsController.cs to allow editing of new User.VerifyDevices property.
* Added tests for new methods and endpoint.
* Updating queries to track [dbo].[User].[VerifyDevices].
* Updated DeviceValidator to set `User.EmailVerified` property during the New Device Verification flow.
 2025-01-08 07:31:24 -08:00
Alex Morask
481a766cd2 Remove FF (#5163) 2025-01-08 09:49:24 -05:00
Patrick-Pimentel-Bitwarden
cc96e35072 Auth/pm 2996/add auth request data to devices response model (#5152) 
fix(auth): [PM-2996] Add Pending Auth Request Data to Devices Response
- New stored procedure to fetch the appropriate data.
- Updated devices controller to respond with the new data.
- Tests written at the controller and repository level.
Resolves PM-2996
 2025-01-07 15:52:53 -05:00
Addison Beck
5ae232e336 chore: expand tests of the new UpdateInstallationCommand (#5227) 2025-01-07 14:58:30 -05:00
cyprain-okeke
eeb1be1dba [PM-15808]Show suspended org modals for orgs in 'unpaid' & 'canceled' status (#5228) 
* Recreate changes on the closed pr

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Remove unused references

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

---------

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
 2025-01-07 20:01:40 +01:00
Jimmy Vo
0e801ca622 [pm-5966] Fix Entity Framework query for MySQL (#5170) 
Problem: The Entity Framework query was causing a compile-time error.

Changes:
1. Fixed the query.
2. Renamed the variable to replace the comment.
 2025-01-07 10:01:23 -05:00
Addison Beck
90f7bfe63d chore: update LastActivityDate on installation token refresh (#5081) 2025-01-06 13:22:03 -08:00
Addison Beck
cd7c4bf6ce chore: move Installation and Push to platform's domain folders (#5085) 
* chore: set up a `CODEOWNERS` space for platform

* chore: move sql objects for `Installation` to platform's domain

* chore: move `Installation` and `PushRelay` code to platform's domain
 2025-01-06 18:10:53 +01:00
Jonas Hendrickx
97e11774e3 [PM-13999] show estimated tax for taxable countries (#5110) 2025-01-02 20:27:53 +01:00
Jonas Hendrickx
bad533af8e [PM-16611] Failing unit tests due to previous month being incorrectly… (#5207) 2025-01-02 16:07:34 +01:00
cyprain-okeke
d924c6721a [PM-15814]Alert owners of reseller-managed orgs to renewal events (#5193) 
* Changes for the admin console alert

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Fix the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Add the feature flag

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

---------

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
 2024-12-31 18:06:29 +01:00
renovate[bot]
cb7cbb630a [deps] Tools: Update Microsoft.Extensions.Configuration to v9 (#5072) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-12-19 12:57:03 +00:00
renovate[bot]
0b026404db [deps] Tools: Update Microsoft.Extensions.DependencyInjection to v9 (#5073) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
 2024-12-19 13:43:44 +01:00