1
0
mirror of https://github.com/bitwarden/server synced 2026-02-12 06:23:28 +00:00
Commit Graph

4950 Commits

Author SHA1 Message Date
Patrick-Pimentel-Bitwarden
c52f2e0d09 feat(register): [PM-27084] Account Register Uses New Data Types - Repush (#6855)
* feat(register): [PM-27084] Account Register Uses New Data Types - Changes.

* test(register): [PM-27084] Account Register Uses New Data Types - Added tests.

* fix(register): [PM-27084] Account Register Uses New Data Types - Added constant for feature flag.
2026-02-04 10:03:55 -05:00
Ike
5afdfa6fd1 [PM-30563] Change error response on Send Access token request (#6911)
* feat: remove invalid email response and instead return email and OTP required to protect against enumeration attacks.

* fix: fixing tests and dotnet format
2026-02-04 09:42:32 -05:00
Derek Nance
52955d1860 [PM-29144] Add server communication config to /api/config (#6892) 2026-02-04 08:15:27 -06:00
Alex Morask
4667af6cf9 [PM-30444] Handle missing Braintree customer in GetPaymentMethodQuery (#6899)
* Handle missing Braintree customer in GetPaymentMethodQuery

* Allow addition of PayPal payment method when bad Braintree customer ID is linked

* Run dotnet format
2026-02-04 07:48:06 -06:00
Ike
68e67e1853 [PM-26376] Emergency Access Delete Command (#6857)
* feat: Add initial DeleteEmergencyContactCommand

* chore: remove nullable enable and add comments

* test: add tests for new delete command

* test: update tests to test IMailer was called.

* feat: add delete by GranteeId and allow for multiple grantors to be contacted.

* feat: add DeleteMany stored procedure for EmergencyAccess

* test: add database tests for new SP

* feat: commands use DeleteManyById for emergencyAccessDeletes

* claude: send one email per grantor instead of a bulk email to all grantors. Modified tests to validate.

* feat: change revision dates for confirmed grantees; 

* feat: add AccountRevisionDate bump for grantee users in the confirmed status

* test: update integration test to validate only confirmed users are updated as well as proper deletion of emergency access
2026-02-03 16:43:44 -05:00
Jackson Engstrom
82e1a6bd71 [PM-31622] Adds feature flag pm-30521-autofill-button-view-login-screen 2026-02-03 13:34:15 -08:00
Jacob Olness
b7923f5498 [PM-31212] Change hardcoded 5 key WebAuthn limit for login to check if premium (#6894)
* removed hardcoded limit so login would look at more than first 5 keys registered

* Update src/Core/Auth/Identity/TokenProviders/WebAuthnTokenProvider.cs

Co-authored-by: Dave <3836813+enmande@users.noreply.github.com>

* Update src/Core/Auth/Identity/TokenProviders/WebAuthnTokenProvider.cs

Co-authored-by: Dave <3836813+enmande@users.noreply.github.com>

* Update src/Core/Auth/Identity/TokenProviders/WebAuthnTokenProvider.cs

Co-authored-by: Dave <3836813+enmande@users.noreply.github.com>

* Update src/Core/Auth/Identity/TokenProviders/WebAuthnTokenProvider.cs

Co-authored-by: Dave <3836813+enmande@users.noreply.github.com>

* removed orphaned for loop in favor of more robust and efficient foreach loop

---------

Co-authored-by: Dave <3836813+enmande@users.noreply.github.com>
2026-02-03 11:12:18 -05:00
Kyle Denney
4f4ccac2de [PM-29599] create proration preview endpoint (#6858)
* [PM-29599] create proration preview endpoint

* forgot to inject user and fixing stripe errors

* updated proration preview and upgrade to be consistent

also using the correct proration behavior and making the upgrade flow start a trial

* missed using the billing address

* changes to proration behavior

and returning more properties from the proration endpoint

* missed in refactor

* pr feedback
2026-02-03 10:08:14 -06:00
Rui Tomé
cee89dbe83 [PM-27179] Fix Admin portal user view to only show individual item count (#6888) 2026-02-03 11:15:56 +00:00
John Harrington
d3aed59fcb [PM-30247] Previously archived items are not archived after import (#6824)
* support importing archived ciphers
* preserve archived ciphers across org imports
2026-02-02 14:39:01 -07:00
Stephon Brown
0e72257ea1 [PM-31360] Remove Reversion Related Code (#6922)
* fix(billing): remove stripe constants

* fix(billing): remove redundant metadate

* tests(billing): remove obsolete metadata checks
2026-02-02 13:44:15 -05:00
Todd Martin
a27eda7df6 chore(flags): [PM-30613] Remove unused mjml-based-email-templates feature flag
* Removed old method.

* Removed IFeatureService.

* Fixed test.

* Renamed the v2 endpoint.

* Removed old Handlebars templates.

* Renamed v2 templates to remove v2 suffix.
2026-02-02 11:36:39 -05:00
Justin Baur
d4de03a762 Introduce the Server SDK to the rest of our services (#6915) 2026-02-02 10:27:25 -05:00
Nik Gilmore
51aa419585 [PM-31280] Specify UTC dates for Archive, Unarchive, Restore, and RestoreByIds (#6919) 2026-01-30 09:57:10 -08:00
sven-bitwarden
93a28eed40 [PM-29246] Simplify Usage of Organization Policies (#6837)
* Initial implementation of new policy query

* Remove unused using

* Adjusts method name to better match repository method

* Correct namespace

* Initial refactor of policy loading

* Add xml doc, incorporate shim data model

* Updates usages to reflect new shim model

* Prune extranneous data from policy detail response model, format code

* Fix broken test, delete inapplicable test

* Adds test cases covering query

* Adjust codebase to use new PolicyQueryçˆ

* Format code

* Fix incorrect mock on test

* Fix formatting

* Adjust method name

* More naming adjustments

* Add PolicyData constructor, update test usages

* Rename PolicyData -> PolicyStatus

* Remove unused using
2026-01-29 14:11:20 -06:00
Alex Dragovich
0544ec41d5 [PM-31394] use email address hash for send access email verification (#6921)
* [PM-31394] use email address hash for send access email verification

* [PM-31394] fixing identity server tests for send access

* [PM-31394] fixing more identity server tests for send access
2026-01-29 11:48:12 -08:00
Brandon Treston
7855c4ee6e [PM-28414] remove feature flag (#6914)
* remove feature flagged logic

* remove feature flag
2026-01-29 10:10:22 -05:00
Patrick-Pimentel-Bitwarden
f29fd4d9c2 fix(logging): [PM-28877] Remove Config for PII Logging (#6885)
* fix(logging): [PM-28877] Remove Config for PII Logging - Removed all references to logging being set to true even in dev environment.

* fix(logging): [PM-28877] Remove Config for PII Logging - Fixed up with a better understanding of the original ask.

* fix(logging): [PM-28877] Remove Config for PII Logging - Removed all show pii.
2026-01-28 15:18:55 -05:00
Vijay Oommen
bfefd27a38 PM-30538 Add feature flag for Milestone 11 DIRT (#6916) 2026-01-28 13:57:06 -06:00
Jared
b1b6fcdbd2 Update email and text templates for Domain Claimed by Organization no… (#6897)
* Update email and text templates for Domain Claimed by Organization notification

- Changed the heading to "What this means for you" for clarity.
- Revised bullet points to better reflect user experience and responsibilities within the organization.
- Updated the phrasing of the help article reference for consistency.

* Fix HandlebarsMailService claimed domain email
2026-01-28 13:16:35 -05:00
Jared McCannon
ddbaffad59 [PM-28627] Create Default Collection Restore (#6879)
* Add default collection name to call stack for restore user command

* Committing feature flag and request model.

* Added tests

* fix for tests.

* added empty string to test

* figured out the mystery commit.

* added vnext onto method name.

* updating tests and command to include feature flag

* moved event call

* last few changes.

* opting for null instead of empty string.
2026-01-28 09:05:29 -06:00
renovate[bot]
369514c055 [deps] Platform: Update LaunchDarkly.ServerSdk to 8.11.0 (#6907)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-28 09:59:31 -05:00
Brandon Treston
a677eb9b39 remove feature flagged logic (#6901) 2026-01-28 09:31:49 -05:00
John Harrington
fa06fe41ab [PM-30920] Server changes to encrypt send access email list (#6867)
* models, entity, and stored procs updated to work with EmailHashes with migrations

* configure data protection for EmailHashes

* update SendAuthenticationQuery to use EmailHashes and perform validation

* respond to Claude's comments and update tests

* fix send.sql alignment

Co-authored-by: mkincaid-bw <mkincaid@bitwarden.com>

---------

Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
Co-authored-by: mkincaid-bw <mkincaid@bitwarden.com>
2026-01-28 07:13:25 -07:00
Todd Martin
2c39e336e0 chore(flags): [PM-31326] Rename ipc-channel-framework feature flag 2026-01-28 08:25:46 -05:00
Todd Martin
4403e036fd chore(flags): Add pm-30529-webauthn-related-origins feature flag 2026-01-27 16:46:43 -05:00
Maciej Zieniuk
f578dab94f user reset password key can be empty string (#6871) 2026-01-27 21:38:09 +01:00
Dave
03fcdc2852 feat(account-switching) [PM-5594]: Add Safari account-switching feature flag. (#6829) 2026-01-27 14:26:07 -05:00
Thomas Rittson
80eec2df85 [PM-23768] Public API - add restore and revoke member endpoint (#6859)
* Add restore and revoke to public api

* Follow naming conventions

* Use POST instead of PUT

* hello claude

* Update test names

* Actually fix test names

* Add JsonConstructor attr

* Fix test
2026-01-27 12:11:15 -06:00
Jared McCannon
898904a673 Renamed for clarity (#6902) 2026-01-27 09:03:06 -06:00
renovate[bot]
2a458807a5 [deps] Vault: Update AngleSharp to 1.4.0 (#5868)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
2026-01-26 12:04:23 -06:00
Alex Morask
5104ec5f98 [PM-31040] Add logging to bank account setup process (#6898)
* Add logging to bank account setup process

* Missed test file constructor
2026-01-26 11:46:08 -06:00
Oscar Hinton
46a4c09b81 Add desktop-migration-milestone-4 flag (#6881) 2026-01-26 16:36:10 +01:00
Anders Åberg
40e293117d PM-2035: PRF Unlock (#6401)
* Initial refactor

* Add WebauthnPRFOptions to syncResponse

* MAYBE: Use KM owned ResponseModel?

* REVERT ^- Keep using PrfUnlockOptions for simplicity

This reverts commit 5a34e7dfa8.

* UserDecryptionOptions: Only send one credential

* format

* Update UserDecryptionOptions.cs

* format

* Added feature flag (#6600)
2026-01-26 07:18:42 -08:00
Rui Tomé
c8124667ee [PM-28842] Add validation to prevent excessive master password policy values (#6807)
* Enhance MasterPasswordPolicyData with validation attributes

Added data annotations for MinComplexity and MinLength properties to enforce validation rules. MinComplexity must be between 0 and 4, and MinLength must be between 12 and 128.

* Implement model validation in PolicyDataValidator and enhance error handling

Added a ValidateModel method to enforce validation rules for policy data. Updated error messages to provide clearer feedback on validation failures. Enhanced unit tests to cover new validation scenarios for MinLength and MinComplexity properties.

* Update PoliciesControllerTests to reflect new validation rules for MinComplexity and MinLength

Modified test cases to use updated values for MinComplexity (4) and MinLength (128). Added new tests to verify that excessive values for these properties return BadRequest responses. Ensured consistency across integration tests for both Admin and Public controllers.

* Enhance MasterPasswordPolicyData with XML documentation for properties

Added XML documentation comments for MinComplexity and MinLength properties to clarify their purpose and constraints. This improves code readability and provides better context for developers using the model.

* Add unit tests for PolicyDataValidator to validate minLength and minComplexity rules

Implemented new test cases to verify the behavior of the ValidateAndSerialize method in PolicyDataValidator. Tests cover scenarios for minimum and maximum values, as well as edge cases for invalid inputs, ensuring robust validation for MasterPassword policy data.
2026-01-26 11:38:06 +00:00
Vijay Oommen
80d05eef07 PM-30879 added feature flag for huntress (#6883) 2026-01-23 13:36:27 -06:00
Vijay Oommen
b623e381b4 PM-30799 added validation for DomainName (#6856) 2026-01-23 08:34:19 -06:00
Robyn MacCallum
867e61694b Add NotificationUndeterminedCipherScenarioLogic feature flag (#6884)
* Add NotificationUndeterminedCipherScenarioLogic feature flag

* Remove whitespace
2026-01-23 09:05:58 -05:00
Rui Tomé
bfe2e7717d [PM-30615] Fix Public API List Collections returning Default Collections (#6841) 2026-01-23 11:07:56 +00:00
Dave
93e2c971df feat(emergency-access) [PM-29584] Create Email for Emergency Access Removal (#6793)
* feat(emergency-access) [PM-29584]: Add email template.

* refactor(emergency-access) [PM-29584]: Move Emergency Access to Auth/UserFeatures.

* refactor(emergency-access) [PM-29584]: Move EmergencyAccess tests to UserFeatures space.

* feat(emergency-access) [PM-29584]: Add compiled EmergencyAccess templates.

* test(emergency-access) [PM-29584]: Add mailer-specific tests.

* refactor(emergency-access) [PM-29584]: Move mail to UserFeatures area.

* feat(emergency-access) [PM-29584]: Update link for help pages, not web vault.

* test(emergency-access) [PM-29584]: Update mail tests for new URL and single responsibility.

* refactor(emergency-access) [PM-29584]: Add comments for added test.
2026-01-22 20:24:15 -05:00
Mike Amirault
0cc72127d7 [PM-26405] Fix cipher favorite info being saved incorrectly on import (#6776) 2026-01-22 20:11:56 -05:00
Derek Nance
415821f173 [PM-29142] Config for SSO cookie vending (#6880)
This config may be used when a load balancer in front of Bitwarden is
first verifying an auth cookie issued by an IdP before proxying the
request to Bitwarden.
2026-01-22 15:20:38 -06:00
Vincent Salucci
bab4750caa chore: add feature flag definition, refs PM-26463 (#6882) 2026-01-22 17:23:18 +00:00
Alex Morask
b686da18dc [PM-30626] Fetch provided storage from Pricing Service when determining storage limit (#6845)
* Fetch provided storage from Pricing Service

* Run dotnet format

* Gbubemi's feedback
2026-01-22 09:01:06 -06:00
Alex Morask
75a857055e [PM-30697] [PM-30698] Renewal email copy updates (#6875)
* feat(families-renewal): Update copy

* feat(premium-renewal): Add new var, update copy
2026-01-21 11:52:36 -06:00
Rui Tomé
7fb2822e05 [PM-28023] Fix restoring revoked invited users in Free Organizations (#6861)
* Fix null reference when restoring invited users in Free orgs

Add null check before querying for other free org ownership. Invited
users don't have a UserId yet, causing NullReferenceException.

* Add regression test for restoring revoked invited users with null UserId.
2026-01-21 11:27:24 +00:00
Alex Morask
439485fc16 Update renewal email copy (#6862) 2026-01-20 09:29:49 -06:00
Alex Morask
2e4dd061e3 [PM-30855] Pay prorated storage adjustment immediately with Braintree for Premium PayPal users (#6850)
* fix: Pay prorated storage invoice immediately with Braintree for PayPal users

* Run dotnet format
2026-01-20 09:18:27 -06:00
Todd Martin
c37412bacb chore(flags): Remove pm-1632-redirect-on-sso-required feature flag
* Remove feature flag.

* Update test title.

* Fixed some test failures.

* Fixed tests

* Removed method that's no longer used.

* Removed unneeded directive.
2026-01-20 10:03:33 -05:00
Thomas Rittson
ad19efcff7 [PM-22236] Fix invited accounts stuck in intermediate claimed status (#6810)
* Exclude invited users from claimed domain checks.
  These users should be excluded by the JOIN on
  UserId, but it's a known issue that some invited
  users have this FK set.
2026-01-17 10:47:21 +10:00