mirror of
https://github.com/bitwarden/server
synced 2026-01-12 21:44:13 +00:00
* update send api models to support new `email` field
* normalize authentication field evaluation order
* document send response converters
* add FIXME to remove unused constructor argument
* add FIXME to remove unused constructor argument
* introduce `tools-send-email-otp-listing` feature flag
* add `ISendOwnerQuery` to dependency graph
* fix broken tests
* added AuthType prop to send related models with test coverage and debt cleanup
* dotnet format
* add migrations
* dotnet format
* make SendsController null safe (tech debt)
* add AuthType col to Sends table, change Emails col length to 4000, and run migrations
* dotnet format
* update SPs to expect AuthType
* include SP updates in migrations
* remove migrations not intended for merge
* Revert "remove migrations not intended for merge"
This reverts commit 7df56e346a.
undo migrations removal
* extract AuthType inference to util method and remove SQLite file
* fix lints
* address review comments
* fix incorrect assignment and adopt SQL conventions
* fix column assignment order in Send_Update.sql
* remove space added to email list
* assign SQL default value of NULL to AuthType
* update SPs to match migration changes
---------
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
757 lines
28 KiB
C#
757 lines
28 KiB
C#
using System.Security.Claims;
|
|
using System.Text.Json;
|
|
using AutoFixture.Xunit2;
|
|
using Bit.Api.Models.Response;
|
|
using Bit.Api.Tools.Controllers;
|
|
using Bit.Api.Tools.Models;
|
|
using Bit.Api.Tools.Models.Request;
|
|
using Bit.Api.Tools.Models.Response;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Services;
|
|
using Bit.Core.Settings;
|
|
using Bit.Core.Tools.Entities;
|
|
using Bit.Core.Tools.Enums;
|
|
using Bit.Core.Tools.Models.Data;
|
|
using Bit.Core.Tools.Repositories;
|
|
using Bit.Core.Tools.SendFeatures.Commands.Interfaces;
|
|
using Bit.Core.Tools.SendFeatures.Queries.Interfaces;
|
|
using Bit.Core.Tools.Services;
|
|
using Bit.Core.Utilities;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Logging;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Api.Test.Tools.Controllers;
|
|
|
|
public class SendsControllerTests : IDisposable
|
|
{
|
|
private readonly SendsController _sut;
|
|
private readonly GlobalSettings _globalSettings;
|
|
private readonly IUserService _userService;
|
|
private readonly ISendRepository _sendRepository;
|
|
private readonly INonAnonymousSendCommand _nonAnonymousSendCommand;
|
|
private readonly IAnonymousSendCommand _anonymousSendCommand;
|
|
private readonly ISendOwnerQuery _sendOwnerQuery;
|
|
private readonly ISendAuthorizationService _sendAuthorizationService;
|
|
private readonly ISendFileStorageService _sendFileStorageService;
|
|
private readonly ILogger<SendsController> _logger;
|
|
|
|
public SendsControllerTests()
|
|
{
|
|
_userService = Substitute.For<IUserService>();
|
|
_sendRepository = Substitute.For<ISendRepository>();
|
|
_nonAnonymousSendCommand = Substitute.For<INonAnonymousSendCommand>();
|
|
_anonymousSendCommand = Substitute.For<IAnonymousSendCommand>();
|
|
_sendOwnerQuery = Substitute.For<ISendOwnerQuery>();
|
|
_sendAuthorizationService = Substitute.For<ISendAuthorizationService>();
|
|
_sendFileStorageService = Substitute.For<ISendFileStorageService>();
|
|
_globalSettings = new GlobalSettings();
|
|
_logger = Substitute.For<ILogger<SendsController>>();
|
|
|
|
_sut = new SendsController(
|
|
_sendRepository,
|
|
_userService,
|
|
_sendAuthorizationService,
|
|
_anonymousSendCommand,
|
|
_nonAnonymousSendCommand,
|
|
_sendOwnerQuery,
|
|
_sendFileStorageService,
|
|
_logger,
|
|
_globalSettings
|
|
);
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
_sut?.Dispose();
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task SendsController_WhenSendHidesEmail_CreatorIdentifierShouldBeNull(
|
|
Guid id, Send send, User user)
|
|
{
|
|
var accessId = CoreHelpers.Base64UrlEncode(id.ToByteArray());
|
|
|
|
send.Id = default;
|
|
send.Type = SendType.Text;
|
|
send.Data = JsonSerializer.Serialize(new Dictionary<string, string>());
|
|
send.HideEmail = true;
|
|
|
|
_sendRepository.GetByIdAsync(Arg.Any<Guid>()).Returns(send);
|
|
_sendAuthorizationService.AccessAsync(send, null).Returns(SendAccessResult.Granted);
|
|
_userService.GetUserByIdAsync(Arg.Any<Guid>()).Returns(user);
|
|
|
|
var request = new SendAccessRequestModel();
|
|
var actionResult = await _sut.Access(accessId, request);
|
|
var response = (actionResult as ObjectResult)?.Value as SendAccessResponseModel;
|
|
|
|
Assert.NotNull(response);
|
|
Assert.Null(response.CreatorIdentifier);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Post_DeletionDateIsMoreThan31DaysFromNow_ThrowsBadRequest()
|
|
{
|
|
var now = DateTime.UtcNow;
|
|
var expected = "You cannot have a Send with a deletion date that far " +
|
|
"into the future. Adjust the Deletion Date to a value less than 31 days from now " +
|
|
"and try again.";
|
|
var request = new SendRequestModel() { DeletionDate = now.AddDays(32) };
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => _sut.Post(request));
|
|
Assert.Equal(expected, exception.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task PostFile_DeletionDateIsMoreThan31DaysFromNow_ThrowsBadRequest()
|
|
{
|
|
var now = DateTime.UtcNow;
|
|
var expected = "You cannot have a Send with a deletion date that far " +
|
|
"into the future. Adjust the Deletion Date to a value less than 31 days from now " +
|
|
"and try again.";
|
|
var request = new SendRequestModel() { Type = SendType.File, FileLength = 1024L, DeletionDate = now.AddDays(32) };
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => _sut.PostFile(request));
|
|
Assert.Equal(expected, exception.Message);
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Get_WithValidId_ReturnsSendResponseModel(Guid sendId, Send send)
|
|
{
|
|
send.Type = SendType.Text;
|
|
var textData = new SendTextData("Test Send", "Notes", "Sample text", false);
|
|
send.Data = JsonSerializer.Serialize(textData);
|
|
_sendOwnerQuery.Get(sendId, Arg.Any<ClaimsPrincipal>()).Returns(send);
|
|
|
|
var result = await _sut.Get(sendId.ToString());
|
|
|
|
Assert.NotNull(result);
|
|
Assert.IsType<SendResponseModel>(result);
|
|
Assert.Equal(send.Id, result.Id);
|
|
await _sendOwnerQuery.Received(1).Get(sendId, Arg.Any<ClaimsPrincipal>());
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Get_WithInvalidGuid_ThrowsException(string invalidId)
|
|
{
|
|
await Assert.ThrowsAsync<FormatException>(() => _sut.Get(invalidId));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetAllOwned_ReturnsListResponseModelWithSendResponseModels()
|
|
{
|
|
var textSendData = new SendTextData("Test Send 1", "Notes 1", "Sample text", false);
|
|
var fileSendData = new SendFileData("Test Send 2", "Notes 2", "test.txt") { Id = "file-123", Size = 1024 };
|
|
var sends = new List<Send>
|
|
{
|
|
new Send { Id = Guid.NewGuid(), Type = SendType.Text, Data = JsonSerializer.Serialize(textSendData) },
|
|
new Send { Id = Guid.NewGuid(), Type = SendType.File, Data = JsonSerializer.Serialize(fileSendData) }
|
|
};
|
|
_sendOwnerQuery.GetOwned(Arg.Any<ClaimsPrincipal>()).Returns(sends);
|
|
|
|
var result = await _sut.GetAll();
|
|
|
|
Assert.NotNull(result);
|
|
Assert.IsType<ListResponseModel<SendResponseModel>>(result);
|
|
Assert.Equal(2, result.Data.Count());
|
|
var sendResponseModels = result.Data.ToList();
|
|
Assert.Equal(sends[0].Id, sendResponseModels[0].Id);
|
|
Assert.Equal(sends[1].Id, sendResponseModels[1].Id);
|
|
await _sendOwnerQuery.Received(1).GetOwned(Arg.Any<ClaimsPrincipal>());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetAllOwned_WhenNoSends_ReturnsEmptyListResponseModel()
|
|
{
|
|
_sendOwnerQuery.GetOwned(Arg.Any<ClaimsPrincipal>()).Returns(new List<Send>());
|
|
|
|
var result = await _sut.GetAll();
|
|
|
|
Assert.NotNull(result);
|
|
Assert.IsType<ListResponseModel<SendResponseModel>>(result);
|
|
Assert.Empty(result.Data);
|
|
await _sendOwnerQuery.Received(1).GetOwned(Arg.Any<ClaimsPrincipal>());
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Post_WithPassword_InfersAuthTypePassword(Guid userId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "key",
|
|
Text = new SendTextModel { Text = "text" },
|
|
Password = "password",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Post(request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(AuthType.Password, result.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.AuthType == AuthType.Password &&
|
|
s.Password != null &&
|
|
s.Emails == null &&
|
|
s.UserId == userId &&
|
|
s.Type == SendType.Text));
|
|
_userService.Received(1).GetProperUserId(Arg.Any<ClaimsPrincipal>());
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Post_WithEmails_InfersAuthTypeEmail(Guid userId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "key",
|
|
Text = new SendTextModel { Text = "text" },
|
|
Emails = "test@example.com",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Post(request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(AuthType.Email, result.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.AuthType == AuthType.Email &&
|
|
s.Emails != null &&
|
|
s.Password == null &&
|
|
s.UserId == userId &&
|
|
s.Type == SendType.Text));
|
|
_userService.Received(1).GetProperUserId(Arg.Any<ClaimsPrincipal>());
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Post_WithoutPasswordOrEmails_InfersAuthTypeNone(Guid userId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "key",
|
|
Text = new SendTextModel { Text = "text" },
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Post(request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(AuthType.None, result.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.AuthType == AuthType.None &&
|
|
s.Password == null &&
|
|
s.Emails == null &&
|
|
s.UserId == userId &&
|
|
s.Type == SendType.Text));
|
|
_userService.Received(1).GetProperUserId(Arg.Any<ClaimsPrincipal>());
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(AuthType.Password)]
|
|
[InlineData(AuthType.Email)]
|
|
[InlineData(AuthType.None)]
|
|
public async Task Access_ReturnsCorrectAuthType(AuthType authType)
|
|
{
|
|
var sendId = Guid.NewGuid();
|
|
var accessId = CoreHelpers.Base64UrlEncode(sendId.ToByteArray());
|
|
var send = new Send
|
|
{
|
|
Id = sendId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new Dictionary<string, string>()),
|
|
AuthType = authType
|
|
};
|
|
|
|
_sendRepository.GetByIdAsync(sendId).Returns(send);
|
|
_sendAuthorizationService.AccessAsync(send, "pwd123").Returns(SendAccessResult.Granted);
|
|
|
|
var request = new SendAccessRequestModel();
|
|
var actionResult = await _sut.Access(accessId, request);
|
|
var response = (actionResult as ObjectResult)?.Value as SendAccessResponseModel;
|
|
|
|
Assert.NotNull(response);
|
|
Assert.Equal(authType, response.AuthType);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(AuthType.Password)]
|
|
[InlineData(AuthType.Email)]
|
|
[InlineData(AuthType.None)]
|
|
public async Task Get_ReturnsCorrectAuthType(AuthType authType)
|
|
{
|
|
var sendId = Guid.NewGuid();
|
|
var send = new Send
|
|
{
|
|
Id = sendId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("a", "b", "c", false)),
|
|
AuthType = authType
|
|
};
|
|
|
|
_sendOwnerQuery.Get(sendId, Arg.Any<ClaimsPrincipal>()).Returns(send);
|
|
|
|
var result = await _sut.Get(sendId.ToString());
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(authType, result.AuthType);
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_WithValidSend_UpdatesSuccessfully(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false)),
|
|
AuthType = AuthType.None
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "updated-key",
|
|
Text = new SendTextModel { Text = "updated text" },
|
|
Password = "new-password",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Put(sendId.ToString(), request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s => s.Id == sendId));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_WithNonExistentSend_ThrowsNotFoundException(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
_sendRepository.GetByIdAsync(sendId).Returns((Send)null);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "key",
|
|
Text = new SendTextModel { Text = "text" },
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => _sut.Put(sendId.ToString(), request));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_WithWrongUser_ThrowsNotFoundException(Guid userId, Guid otherUserId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = otherUserId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false))
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "key",
|
|
Text = new SendTextModel { Text = "text" },
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => _sut.Put(sendId.ToString(), request));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task PutRemovePassword_WithValidSend_RemovesPasswordAndSetsAuthTypeNone(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Test", "Notes", "Text", false)),
|
|
Password = "hashed-password",
|
|
AuthType = AuthType.Password
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var result = await _sut.PutRemovePassword(sendId.ToString());
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
Assert.Equal(AuthType.None, result.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.Id == sendId &&
|
|
s.Password == null &&
|
|
s.AuthType == AuthType.None));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task PutRemovePassword_WithNonExistentSend_ThrowsNotFoundException(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
_sendRepository.GetByIdAsync(sendId).Returns((Send)null);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => _sut.PutRemovePassword(sendId.ToString()));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task PutRemovePassword_WithWrongUser_ThrowsNotFoundException(Guid userId, Guid otherUserId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = otherUserId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Test", "Notes", "Text", false)),
|
|
Password = "hashed-password"
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => _sut.PutRemovePassword(sendId.ToString()));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Delete_WithValidSend_DeletesSuccessfully(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Test", "Notes", "Text", false))
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
await _sut.Delete(sendId.ToString());
|
|
|
|
await _nonAnonymousSendCommand.Received(1).DeleteSendAsync(Arg.Is<Send>(s => s.Id == sendId));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Delete_WithNonExistentSend_ThrowsNotFoundException(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
_sendRepository.GetByIdAsync(sendId).Returns((Send)null);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => _sut.Delete(sendId.ToString()));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Delete_WithWrongUser_ThrowsNotFoundException(Guid userId, Guid otherUserId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = otherUserId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Test", "Notes", "Text", false))
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => _sut.Delete(sendId.ToString()));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task PostFile_WithPassword_InfersAuthTypePassword(Guid userId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
_nonAnonymousSendCommand.SaveFileSendAsync(Arg.Any<Send>(), Arg.Any<SendFileData>(), Arg.Any<long>())
|
|
.Returns("https://example.com/upload")
|
|
.AndDoes(callInfo =>
|
|
{
|
|
var send = callInfo.ArgAt<Send>(0);
|
|
var data = callInfo.ArgAt<SendFileData>(1);
|
|
send.Data = JsonSerializer.Serialize(data);
|
|
});
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.File,
|
|
Key = "key",
|
|
File = new SendFileModel { FileName = "test.txt" },
|
|
FileLength = 1024L,
|
|
Password = "password",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.PostFile(request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.NotNull(result.SendResponse);
|
|
Assert.Equal(AuthType.Password, result.SendResponse.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveFileSendAsync(
|
|
Arg.Is<Send>(s =>
|
|
s.AuthType == AuthType.Password &&
|
|
s.Password != null &&
|
|
s.Emails == null &&
|
|
s.UserId == userId),
|
|
Arg.Any<SendFileData>(),
|
|
1024L);
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task PostFile_WithEmails_InfersAuthTypeEmail(Guid userId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
_nonAnonymousSendCommand.SaveFileSendAsync(Arg.Any<Send>(), Arg.Any<SendFileData>(), Arg.Any<long>())
|
|
.Returns("https://example.com/upload")
|
|
.AndDoes(callInfo =>
|
|
{
|
|
var send = callInfo.ArgAt<Send>(0);
|
|
var data = callInfo.ArgAt<SendFileData>(1);
|
|
send.Data = JsonSerializer.Serialize(data);
|
|
});
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.File,
|
|
Key = "key",
|
|
File = new SendFileModel { FileName = "test.txt" },
|
|
FileLength = 1024L,
|
|
Emails = "test@example.com",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.PostFile(request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.NotNull(result.SendResponse);
|
|
Assert.Equal(AuthType.Email, result.SendResponse.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveFileSendAsync(
|
|
Arg.Is<Send>(s =>
|
|
s.AuthType == AuthType.Email &&
|
|
s.Emails != null &&
|
|
s.Password == null &&
|
|
s.UserId == userId),
|
|
Arg.Any<SendFileData>(),
|
|
1024L);
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task PostFile_WithoutPasswordOrEmails_InfersAuthTypeNone(Guid userId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
_nonAnonymousSendCommand.SaveFileSendAsync(Arg.Any<Send>(), Arg.Any<SendFileData>(), Arg.Any<long>())
|
|
.Returns("https://example.com/upload")
|
|
.AndDoes(callInfo =>
|
|
{
|
|
var send = callInfo.ArgAt<Send>(0);
|
|
var data = callInfo.ArgAt<SendFileData>(1);
|
|
send.Data = JsonSerializer.Serialize(data);
|
|
});
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.File,
|
|
Key = "key",
|
|
File = new SendFileModel { FileName = "test.txt" },
|
|
FileLength = 1024L,
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.PostFile(request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.NotNull(result.SendResponse);
|
|
Assert.Equal(AuthType.None, result.SendResponse.AuthType);
|
|
await _nonAnonymousSendCommand.Received(1).SaveFileSendAsync(
|
|
Arg.Is<Send>(s =>
|
|
s.AuthType == AuthType.None &&
|
|
s.Password == null &&
|
|
s.Emails == null &&
|
|
s.UserId == userId),
|
|
Arg.Any<SendFileData>(),
|
|
1024L);
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_ChangingFromPasswordToEmails_UpdatesAuthTypeToEmail(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false)),
|
|
Password = "hashed-password",
|
|
AuthType = AuthType.Password
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "updated-key",
|
|
Text = new SendTextModel { Text = "updated text" },
|
|
Emails = "new@example.com",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Put(sendId.ToString(), request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.Id == sendId &&
|
|
s.AuthType == AuthType.Email &&
|
|
s.Emails != null &&
|
|
s.Password == null));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_ChangingFromEmailToPassword_UpdatesAuthTypeToPassword(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false)),
|
|
Emails = "old@example.com",
|
|
AuthType = AuthType.Email
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "updated-key",
|
|
Text = new SendTextModel { Text = "updated text" },
|
|
Password = "new-password",
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Put(sendId.ToString(), request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.Id == sendId &&
|
|
s.AuthType == AuthType.Password &&
|
|
s.Password != null &&
|
|
s.Emails == null));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_WithoutPasswordOrEmails_PreservesExistingPassword(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false)),
|
|
Password = "hashed-password",
|
|
AuthType = AuthType.Password
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "updated-key",
|
|
Text = new SendTextModel { Text = "updated text" },
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Put(sendId.ToString(), request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.Id == sendId &&
|
|
s.AuthType == AuthType.Password &&
|
|
s.Password == "hashed-password" &&
|
|
s.Emails == null));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_WithoutPasswordOrEmails_PreservesExistingEmails(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false)),
|
|
Emails = "test@example.com",
|
|
AuthType = AuthType.Email
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "updated-key",
|
|
Text = new SendTextModel { Text = "updated text" },
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Put(sendId.ToString(), request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.Id == sendId &&
|
|
s.AuthType == AuthType.Email &&
|
|
s.Emails == "test@example.com" &&
|
|
s.Password == null));
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task Put_WithoutPasswordOrEmails_PreservesNoneAuthType(Guid userId, Guid sendId)
|
|
{
|
|
_userService.GetProperUserId(Arg.Any<ClaimsPrincipal>()).Returns(userId);
|
|
var existingSend = new Send
|
|
{
|
|
Id = sendId,
|
|
UserId = userId,
|
|
Type = SendType.Text,
|
|
Data = JsonSerializer.Serialize(new SendTextData("Old", "Old notes", "Old text", false)),
|
|
Password = null,
|
|
Emails = null,
|
|
AuthType = AuthType.None
|
|
};
|
|
_sendRepository.GetByIdAsync(sendId).Returns(existingSend);
|
|
|
|
var request = new SendRequestModel
|
|
{
|
|
Type = SendType.Text,
|
|
Key = "updated-key",
|
|
Text = new SendTextModel { Text = "updated text" },
|
|
DeletionDate = DateTime.UtcNow.AddDays(7)
|
|
};
|
|
|
|
var result = await _sut.Put(sendId.ToString(), request);
|
|
|
|
Assert.NotNull(result);
|
|
Assert.Equal(sendId, result.Id);
|
|
await _nonAnonymousSendCommand.Received(1).SaveSendAsync(Arg.Is<Send>(s =>
|
|
s.Id == sendId &&
|
|
s.AuthType == AuthType.None &&
|
|
s.Password == null &&
|
|
s.Emails == null));
|
|
}
|
|
}
|