mirror of
https://github.com/bitwarden/server
synced 2026-01-06 02:23:51 +00:00
* feat: exclude DefaultUserCollection from GetManyByOrganizationIdWithPermissionsAsync Updated EF implementation, SQL procedure, and unit test to verify that default user collections are filtered from results * Update the public CollectionsController.Get method to return a NotFoundResult for collections of type DefaultUserCollection. * Add unit tests for the public CollectionsController * Update ICollectionRepository.GetManyByOrganizationIdAsync to exclude results of the type DefaultUserCollection Modified the SQL stored procedure and the EF query to reflect this change and added a new integration test to ensure the functionality works as expected. * Refactor CollectionsController to remove unused IApplicationCacheService dependency * Update IOrganizationUserRepository.GetDetailsByIdWithCollectionsAsync to exclude DefaultUserCollections * Update IOrganizationUserRepository.GetManyDetailsByOrganizationAsync to exclude DefaultUserCollections * Undo change to GetByIdWithCollectionsAsync * Update integration test to verify exclusion of DefaultUserCollection in OrganizationUserRepository.GetDetailsByIdWithCollectionsAsync * Clarify documentation in ICollectionRepository to specify that GetManyByOrganizationIdWithAccessAsync returns only shared collections belonging to the organization. * Add Arrange, Act, and Assert comments to CollectionsControllerTests
20 lines
517 B
Transact-SQL
20 lines
517 B
Transact-SQL
CREATE PROCEDURE [dbo].[CollectionUser_ReadByOrganizationUserIds]
|
|
@OrganizationUserIds [dbo].[GuidIdArray] READONLY
|
|
AS
|
|
BEGIN
|
|
SET NOCOUNT ON
|
|
|
|
SELECT
|
|
CU.*
|
|
FROM
|
|
[dbo].[OrganizationUser] OU
|
|
INNER JOIN
|
|
[dbo].[CollectionUser] CU ON CU.[OrganizationUserId] = OU.[Id]
|
|
INNER JOIN
|
|
[dbo].[Collection] C ON CU.[CollectionId] = C.[Id]
|
|
INNER JOIN
|
|
@OrganizationUserIds OUI ON OUI.[Id] = OU.[Id]
|
|
WHERE
|
|
C.[Type] != 1 -- Exclude DefaultUserCollection
|
|
END
|