mirror of
https://github.com/bitwarden/server
synced 2025-12-30 23:23:37 +00:00
* account v2 registration for key connector * use new user repository functions * test coverage * integration test coverage * documentation * code review * missing test coverage * fix failing test * failing test * incorrect ticket number * moved back request model to Api, created dedicated data class in Core * sql stored procedure type mismatch, simplification * key connector authorization handler
126 lines
5.6 KiB
C#
126 lines
5.6 KiB
C#
using System.Security.Claims;
|
|
using Bit.Core.Context;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.KeyManagement.Commands;
|
|
using Bit.Core.KeyManagement.Models.Data;
|
|
using Bit.Core.OrganizationFeatures.OrganizationUsers.Interfaces;
|
|
using Bit.Core.Repositories;
|
|
using Bit.Core.Services;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Http;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.KeyManagement.Commands;
|
|
|
|
[SutProviderCustomize]
|
|
public class SetKeyConnectorKeyCommandTests
|
|
{
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task SetKeyConnectorKeyForUserAsync_Success_SetsAccountKeys(
|
|
User user,
|
|
KeyConnectorKeysData data,
|
|
SutProvider<SetKeyConnectorKeyCommand> sutProvider)
|
|
{
|
|
// Set up valid V2 encryption data
|
|
if (data.AccountKeys!.SignatureKeyPair != null)
|
|
{
|
|
data.AccountKeys.SignatureKeyPair.SignatureAlgorithm = "ed25519";
|
|
}
|
|
|
|
var expectedAccountKeysData = data.AccountKeys.ToAccountKeysData();
|
|
|
|
// Arrange
|
|
user.UsesKeyConnector = false;
|
|
var currentContext = sutProvider.GetDependency<ICurrentContext>();
|
|
var httpContext = Substitute.For<HttpContext>();
|
|
httpContext.User.Returns(new ClaimsPrincipal());
|
|
currentContext.HttpContext.Returns(httpContext);
|
|
|
|
sutProvider.GetDependency<IAuthorizationService>()
|
|
.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), user, Arg.Any<IEnumerable<IAuthorizationRequirement>>())
|
|
.Returns(AuthorizationResult.Success());
|
|
|
|
var userRepository = sutProvider.GetDependency<IUserRepository>();
|
|
var mockUpdateUserData = Substitute.For<UpdateUserData>();
|
|
userRepository.SetKeyConnectorUserKey(user.Id, data.KeyConnectorKeyWrappedUserKey!)
|
|
.Returns(mockUpdateUserData);
|
|
|
|
// Act
|
|
await sutProvider.Sut.SetKeyConnectorKeyForUserAsync(user, data);
|
|
|
|
// Assert
|
|
|
|
userRepository
|
|
.Received(1)
|
|
.SetKeyConnectorUserKey(user.Id, data.KeyConnectorKeyWrappedUserKey);
|
|
|
|
await userRepository
|
|
.Received(1)
|
|
.SetV2AccountCryptographicStateAsync(
|
|
user.Id,
|
|
Arg.Is<UserAccountKeysData>(data =>
|
|
data.PublicKeyEncryptionKeyPairData.PublicKey == expectedAccountKeysData.PublicKeyEncryptionKeyPairData.PublicKey &&
|
|
data.PublicKeyEncryptionKeyPairData.WrappedPrivateKey == expectedAccountKeysData.PublicKeyEncryptionKeyPairData.WrappedPrivateKey &&
|
|
data.PublicKeyEncryptionKeyPairData.SignedPublicKey == expectedAccountKeysData.PublicKeyEncryptionKeyPairData.SignedPublicKey &&
|
|
data.SignatureKeyPairData!.SignatureAlgorithm == expectedAccountKeysData.SignatureKeyPairData!.SignatureAlgorithm &&
|
|
data.SignatureKeyPairData.WrappedSigningKey == expectedAccountKeysData.SignatureKeyPairData.WrappedSigningKey &&
|
|
data.SignatureKeyPairData.VerifyingKey == expectedAccountKeysData.SignatureKeyPairData.VerifyingKey &&
|
|
data.SecurityStateData!.SecurityState == expectedAccountKeysData.SecurityStateData!.SecurityState &&
|
|
data.SecurityStateData.SecurityVersion == expectedAccountKeysData.SecurityStateData.SecurityVersion),
|
|
Arg.Is<IEnumerable<UpdateUserData>>(actions =>
|
|
actions.Count() == 1 && actions.First() == mockUpdateUserData));
|
|
|
|
await sutProvider.GetDependency<IEventService>()
|
|
.Received(1)
|
|
.LogUserEventAsync(user.Id, EventType.User_MigratedKeyToKeyConnector);
|
|
|
|
await sutProvider.GetDependency<IAcceptOrgUserCommand>()
|
|
.Received(1)
|
|
.AcceptOrgUserByOrgSsoIdAsync(data.OrgIdentifier, user, sutProvider.GetDependency<IUserService>());
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task SetKeyConnectorKeyForUserAsync_UserCantUseKeyConnector_ThrowsException(
|
|
User user,
|
|
KeyConnectorKeysData data,
|
|
SutProvider<SetKeyConnectorKeyCommand> sutProvider)
|
|
{
|
|
// Arrange
|
|
user.UsesKeyConnector = true;
|
|
var currentContext = sutProvider.GetDependency<ICurrentContext>();
|
|
var httpContext = Substitute.For<HttpContext>();
|
|
httpContext.User.Returns(new ClaimsPrincipal());
|
|
currentContext.HttpContext.Returns(httpContext);
|
|
|
|
sutProvider.GetDependency<IAuthorizationService>()
|
|
.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), user, Arg.Any<IEnumerable<IAuthorizationRequirement>>())
|
|
.Returns(AuthorizationResult.Failed());
|
|
|
|
// Act & Assert
|
|
await Assert.ThrowsAsync<BadRequestException>(
|
|
() => sutProvider.Sut.SetKeyConnectorKeyForUserAsync(user, data));
|
|
|
|
sutProvider.GetDependency<IUserRepository>()
|
|
.DidNotReceiveWithAnyArgs()
|
|
.SetKeyConnectorUserKey(Arg.Any<Guid>(), Arg.Any<string>());
|
|
|
|
await sutProvider.GetDependency<IUserRepository>()
|
|
.DidNotReceiveWithAnyArgs()
|
|
.SetV2AccountCryptographicStateAsync(Arg.Any<Guid>(), Arg.Any<UserAccountKeysData>(), Arg.Any<IEnumerable<UpdateUserData>>());
|
|
|
|
await sutProvider.GetDependency<IEventService>()
|
|
.DidNotReceiveWithAnyArgs()
|
|
.LogUserEventAsync(Arg.Any<Guid>(), Arg.Any<EventType>());
|
|
|
|
await sutProvider.GetDependency<IAcceptOrgUserCommand>()
|
|
.DidNotReceiveWithAnyArgs()
|
|
.AcceptOrgUserByOrgSsoIdAsync(Arg.Any<string>(), Arg.Any<User>(), Arg.Any<IUserService>());
|
|
}
|
|
}
|