mirror of
https://github.com/bitwarden/server
synced 2026-02-19 10:53:34 +00:00
* docs(billing): add design document for replacing SetupIntent cache * docs(billing): add implementation plan for replacing SetupIntent cache * feat(db): add gateway lookup stored procedures for Organization, Provider, and User * feat(db): add gateway lookup indexes to Organization, Provider, and User table definitions * chore(db): add SQL Server migration for gateway lookup indexes and stored procedures * feat(repos): add gateway lookup methods to IOrganizationRepository and Dapper implementation * feat(repos): add gateway lookup methods to IProviderRepository and Dapper implementation * feat(repos): add gateway lookup methods to IUserRepository and Dapper implementation * feat(repos): add EF OrganizationRepository gateway lookup methods and index configuration * feat(repos): add EF ProviderRepository gateway lookup methods and index configuration * feat(repos): add EF UserRepository gateway lookup methods and index configuration * chore(db): add EF migrations for gateway lookup indexes * refactor(billing): update SetupIntentSucceededHandler to use repository instead of cache * refactor(billing): simplify StripeEventService by expanding customer on SetupIntent * refactor(billing): query Stripe for SetupIntents by customer ID in GetPaymentMethodQuery * refactor(billing): query Stripe for SetupIntents by customer ID in HasPaymentMethodQuery * refactor(billing): update OrganizationBillingService to set customer on SetupIntent * refactor(billing): update ProviderBillingService to set customer on SetupIntent and query by customer * refactor(billing): update UpdatePaymentMethodCommand to set customer on SetupIntent * refactor(billing): remove bank account support from CreatePremiumCloudHostedSubscriptionCommand * refactor(billing): remove OrganizationBillingService.UpdatePaymentMethod dead code * refactor(billing): remove ProviderBillingService.UpdatePaymentMethod * refactor(billing): remove PremiumUserBillingService.UpdatePaymentMethod and UserService.ReplacePaymentMethodAsync * refactor(billing): remove SubscriberService.UpdatePaymentSource and related dead code * refactor(billing): update SubscriberService.GetPaymentSourceAsync to query Stripe by customer ID Add Task 15a to plan - this was a missed requirement for updating GetPaymentSourceAsync which still used the cache. * refactor(billing): complete removal of PremiumUserBillingService.Finalize and UserService.SignUpPremiumAsync * refactor(billing): remove ISetupIntentCache and SetupIntentDistributedCache * chore: remove temporary planning documents * chore: run dotnet format * fix(billing): add MaxLength(50) to Provider gateway ID properties * chore(db): add EF migrations for Provider gateway column lengths * chore: run dotnet format * chore: rename SQL migration for chronological order
246 lines
6.7 KiB
C#
246 lines
6.7 KiB
C#
using Bit.Core.AdminConsole.Entities;
|
|
using Bit.Core.Billing.Constants;
|
|
using Bit.Core.Billing.Payment.Queries;
|
|
using Bit.Core.Billing.Services;
|
|
using Bit.Core.Test.Billing.Extensions;
|
|
using NSubstitute;
|
|
using NSubstitute.ReturnsExtensions;
|
|
using Stripe;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.Billing.Payment.Queries;
|
|
|
|
using static StripeConstants;
|
|
|
|
public class HasPaymentMethodQueryTests
|
|
{
|
|
private readonly IStripeAdapter _stripeAdapter = Substitute.For<IStripeAdapter>();
|
|
private readonly ISubscriberService _subscriberService = Substitute.For<ISubscriberService>();
|
|
private readonly HasPaymentMethodQuery _query;
|
|
|
|
public HasPaymentMethodQueryTests()
|
|
{
|
|
_query = new HasPaymentMethodQuery(
|
|
_stripeAdapter,
|
|
_subscriberService);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_NoCustomer_ReturnsFalse()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).ReturnsNull();
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.False(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_NoPaymentMethod_ReturnsFalse()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
|
Metadata = new Dictionary<string, string>()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.False(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_HasDefaultPaymentMethodId_ReturnsTrue()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings
|
|
{
|
|
DefaultPaymentMethodId = "pm_123"
|
|
},
|
|
Metadata = new Dictionary<string, string>()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.True(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_HasDefaultSourceId_ReturnsTrue()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
DefaultSourceId = "card_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
|
Metadata = new Dictionary<string, string>()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.True(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_HasUnverifiedBankAccount_ReturnsTrue()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
|
Metadata = new Dictionary<string, string>()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
_stripeAdapter
|
|
.ListSetupIntentsAsync(Arg.Is<SetupIntentListOptions>(options =>
|
|
options.Customer == customer.Id &&
|
|
options.HasExpansions("data.payment_method")))
|
|
.Returns(
|
|
[
|
|
new SetupIntent
|
|
{
|
|
Status = "requires_action",
|
|
NextAction = new SetupIntentNextAction
|
|
{
|
|
VerifyWithMicrodeposits = new SetupIntentNextActionVerifyWithMicrodeposits()
|
|
},
|
|
PaymentMethod = new PaymentMethod
|
|
{
|
|
UsBankAccount = new PaymentMethodUsBankAccount()
|
|
}
|
|
}
|
|
]);
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.True(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_HasBraintreeCustomerId_ReturnsTrue()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
|
Metadata = new Dictionary<string, string>
|
|
{
|
|
[MetadataKeys.BraintreeCustomerId] = "braintree_customer_id"
|
|
}
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.True(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_NoSetupIntents_ReturnsFalse()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
|
Metadata = new Dictionary<string, string>()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
_stripeAdapter
|
|
.ListSetupIntentsAsync(Arg.Is<SetupIntentListOptions>(options =>
|
|
options.Customer == customer.Id &&
|
|
options.HasExpansions("data.payment_method")))
|
|
.Returns(new List<SetupIntent>());
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.False(hasPaymentMethod);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Run_SetupIntentNotBankAccount_ReturnsFalse()
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = Guid.NewGuid()
|
|
};
|
|
|
|
var customer = new Customer
|
|
{
|
|
Id = "cus_123",
|
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
|
Metadata = new Dictionary<string, string>()
|
|
};
|
|
|
|
_subscriberService.GetCustomer(organization).Returns(customer);
|
|
|
|
_stripeAdapter
|
|
.ListSetupIntentsAsync(Arg.Is<SetupIntentListOptions>(options =>
|
|
options.Customer == customer.Id &&
|
|
options.HasExpansions("data.payment_method")))
|
|
.Returns(
|
|
[
|
|
new SetupIntent
|
|
{
|
|
PaymentMethod = new PaymentMethod
|
|
{
|
|
Type = "card"
|
|
},
|
|
Status = "succeeded"
|
|
}
|
|
]);
|
|
|
|
var hasPaymentMethod = await _query.Run(organization);
|
|
|
|
Assert.False(hasPaymentMethod);
|
|
}
|
|
}
|