mirror of
https://github.com/bitwarden/server
synced 2025-12-11 05:43:35 +00:00
* feat: add static enumeration helper class * test: add enumeration helper class unit tests * feat: implement NeverAuthenticateValidator * test: unit and integration tests SendNeverAuthenticateValidator * test: use static class for common integration test setup for Send Access unit and integration tests * test: update tests to use static helper
217 lines
8.7 KiB
C#
217 lines
8.7 KiB
C#
using Bit.Core.Auth.Identity.TokenProviders;
|
|
using Bit.Core.Services;
|
|
using Bit.Core.Tools.Models.Data;
|
|
using Bit.Core.Tools.SendFeatures.Queries.Interfaces;
|
|
using Bit.IntegrationTestCommon.Factories;
|
|
using Duende.IdentityModel;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Identity.IntegrationTest.RequestValidation.SendAccess;
|
|
|
|
public class SendEmailOtpRequestValidatorIntegrationTests(IdentityApplicationFactory _factory) : IClassFixture<IdentityApplicationFactory>
|
|
{
|
|
[Fact]
|
|
public async Task SendAccess_EmailOtpProtectedSend_MissingEmail_ReturnsInvalidRequest()
|
|
{
|
|
// Arrange
|
|
var sendId = Guid.NewGuid();
|
|
var client = _factory.WithWebHostBuilder(builder =>
|
|
{
|
|
builder.ConfigureServices(services =>
|
|
{
|
|
var featureService = Substitute.For<IFeatureService>();
|
|
featureService.IsEnabled(Arg.Any<string>()).Returns(true);
|
|
services.AddSingleton(featureService);
|
|
|
|
var sendAuthQuery = Substitute.For<ISendAuthenticationQuery>();
|
|
sendAuthQuery.GetAuthenticationMethod(sendId)
|
|
.Returns(new EmailOtp(["test@example.com"]));
|
|
services.AddSingleton(sendAuthQuery);
|
|
});
|
|
}).CreateClient();
|
|
|
|
var requestBody = SendAccessTestUtilities.CreateTokenRequestBody(sendId); // No email
|
|
|
|
// Act
|
|
var response = await client.PostAsync("/connect/token", requestBody);
|
|
|
|
// Assert
|
|
var content = await response.Content.ReadAsStringAsync();
|
|
Assert.Contains(OidcConstants.TokenErrors.InvalidRequest, content);
|
|
Assert.Contains("email is required", content);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SendAccess_EmailOtpProtectedSend_EmailWithoutOtp_SendsOtpEmail()
|
|
{
|
|
// Arrange
|
|
var sendId = Guid.NewGuid();
|
|
var email = "test@example.com";
|
|
var generatedToken = "123456";
|
|
|
|
var client = _factory.WithWebHostBuilder(builder =>
|
|
{
|
|
builder.ConfigureServices(services =>
|
|
{
|
|
var featureService = Substitute.For<IFeatureService>();
|
|
featureService.IsEnabled(Arg.Any<string>()).Returns(true);
|
|
services.AddSingleton(featureService);
|
|
|
|
var sendAuthQuery = Substitute.For<ISendAuthenticationQuery>();
|
|
sendAuthQuery.GetAuthenticationMethod(sendId)
|
|
.Returns(new EmailOtp([email]));
|
|
services.AddSingleton(sendAuthQuery);
|
|
|
|
// Mock OTP token provider
|
|
var otpProvider = Substitute.For<IOtpTokenProvider<DefaultOtpTokenProviderOptions>>();
|
|
otpProvider.GenerateTokenAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>())
|
|
.Returns(generatedToken);
|
|
services.AddSingleton(otpProvider);
|
|
|
|
// Mock mail service
|
|
var mailService = Substitute.For<IMailService>();
|
|
services.AddSingleton(mailService);
|
|
});
|
|
}).CreateClient();
|
|
|
|
var requestBody = SendAccessTestUtilities.CreateTokenRequestBody(sendId, email: email); // Email but no OTP
|
|
|
|
// Act
|
|
var response = await client.PostAsync("/connect/token", requestBody);
|
|
|
|
// Assert
|
|
var content = await response.Content.ReadAsStringAsync();
|
|
Assert.Contains(OidcConstants.TokenErrors.InvalidRequest, content);
|
|
Assert.Contains("email otp sent", content);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SendAccess_EmailOtpProtectedSend_ValidOtp_ReturnsAccessToken()
|
|
{
|
|
// Arrange
|
|
var sendId = Guid.NewGuid();
|
|
var email = "test@example.com";
|
|
var otp = "123456";
|
|
|
|
var client = _factory.WithWebHostBuilder(builder =>
|
|
{
|
|
builder.ConfigureServices(services =>
|
|
{
|
|
var featureService = Substitute.For<IFeatureService>();
|
|
featureService.IsEnabled(Arg.Any<string>()).Returns(true);
|
|
services.AddSingleton(featureService);
|
|
|
|
var sendAuthQuery = Substitute.For<ISendAuthenticationQuery>();
|
|
sendAuthQuery.GetAuthenticationMethod(sendId)
|
|
.Returns(new EmailOtp(new[] { email }));
|
|
services.AddSingleton(sendAuthQuery);
|
|
|
|
// Mock OTP token provider to validate successfully
|
|
var otpProvider = Substitute.For<IOtpTokenProvider<DefaultOtpTokenProviderOptions>>();
|
|
otpProvider.ValidateTokenAsync(otp, Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>())
|
|
.Returns(true);
|
|
services.AddSingleton(otpProvider);
|
|
|
|
var mailService = Substitute.For<IMailService>();
|
|
services.AddSingleton(mailService);
|
|
});
|
|
}).CreateClient();
|
|
|
|
var requestBody = SendAccessTestUtilities.CreateTokenRequestBody(sendId, email: email, emailOtp: otp);
|
|
|
|
// Act
|
|
var response = await client.PostAsync("/connect/token", requestBody);
|
|
|
|
// Assert
|
|
Assert.True(response.IsSuccessStatusCode);
|
|
var content = await response.Content.ReadAsStringAsync();
|
|
Assert.Contains(OidcConstants.TokenResponse.AccessToken, content);
|
|
Assert.Contains(OidcConstants.TokenResponse.BearerTokenType, content);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SendAccess_EmailOtpProtectedSend_InvalidOtp_ReturnsInvalidGrant()
|
|
{
|
|
// Arrange
|
|
var sendId = Guid.NewGuid();
|
|
var email = "test@example.com";
|
|
var invalidOtp = "wrong123";
|
|
|
|
var client = _factory.WithWebHostBuilder(builder =>
|
|
{
|
|
builder.ConfigureServices(services =>
|
|
{
|
|
var featureService = Substitute.For<IFeatureService>();
|
|
featureService.IsEnabled(Arg.Any<string>()).Returns(true);
|
|
services.AddSingleton(featureService);
|
|
|
|
var sendAuthQuery = Substitute.For<ISendAuthenticationQuery>();
|
|
sendAuthQuery.GetAuthenticationMethod(sendId)
|
|
.Returns(new EmailOtp(new[] { email }));
|
|
services.AddSingleton(sendAuthQuery);
|
|
|
|
// Mock OTP token provider to validate as false
|
|
var otpProvider = Substitute.For<IOtpTokenProvider<DefaultOtpTokenProviderOptions>>();
|
|
otpProvider.ValidateTokenAsync(invalidOtp, Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>())
|
|
.Returns(false);
|
|
services.AddSingleton(otpProvider);
|
|
|
|
var mailService = Substitute.For<IMailService>();
|
|
services.AddSingleton(mailService);
|
|
});
|
|
}).CreateClient();
|
|
|
|
var requestBody = SendAccessTestUtilities.CreateTokenRequestBody(sendId, email: email, emailOtp: invalidOtp);
|
|
|
|
// Act
|
|
var response = await client.PostAsync("/connect/token", requestBody);
|
|
|
|
// Assert
|
|
var content = await response.Content.ReadAsStringAsync();
|
|
Assert.Contains(OidcConstants.TokenErrors.InvalidGrant, content);
|
|
Assert.Contains("email otp is invalid", content);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SendAccess_EmailOtpProtectedSend_OtpGenerationFails_ReturnsInvalidRequest()
|
|
{
|
|
// Arrange
|
|
var sendId = Guid.NewGuid();
|
|
var email = "test@example.com";
|
|
|
|
var client = _factory.WithWebHostBuilder(builder =>
|
|
{
|
|
builder.ConfigureServices(services =>
|
|
{
|
|
var featureService = Substitute.For<IFeatureService>();
|
|
featureService.IsEnabled(Arg.Any<string>()).Returns(true);
|
|
services.AddSingleton(featureService);
|
|
|
|
var sendAuthQuery = Substitute.For<ISendAuthenticationQuery>();
|
|
sendAuthQuery.GetAuthenticationMethod(sendId)
|
|
.Returns(new EmailOtp(new[] { email }));
|
|
services.AddSingleton(sendAuthQuery);
|
|
|
|
// Mock OTP token provider to fail generation
|
|
var otpProvider = Substitute.For<IOtpTokenProvider<DefaultOtpTokenProviderOptions>>();
|
|
otpProvider.GenerateTokenAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>())
|
|
.Returns((string)null);
|
|
services.AddSingleton(otpProvider);
|
|
|
|
var mailService = Substitute.For<IMailService>();
|
|
services.AddSingleton(mailService);
|
|
});
|
|
}).CreateClient();
|
|
|
|
var requestBody = SendAccessTestUtilities.CreateTokenRequestBody(sendId, email: email); // Email but no OTP
|
|
|
|
// Act
|
|
var response = await client.PostAsync("/connect/token", requestBody);
|
|
|
|
// Assert
|
|
var content = await response.Content.ReadAsStringAsync();
|
|
Assert.Contains(OidcConstants.TokenErrors.InvalidRequest, content);
|
|
}
|
|
}
|