mirror of
https://github.com/bitwarden/server
synced 2026-01-27 14:53:21 +00:00
* Add sproc to create multiple default collections. SqlBulkCopy implementation is overkill for most cases. This provides a lighter weight sproc implementation for smaller data sets. * DRY up collection arrangement * DRY up tests because bulk and non-bulk share same behavior * use EF native AddRange instead of bulk insert, because we expect smaller data sizes on self-host
159 lines
7.4 KiB
C#
159 lines
7.4 KiB
C#
using Bit.Core.AdminConsole.Entities;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Repositories;
|
|
using Xunit;
|
|
|
|
namespace Bit.Infrastructure.IntegrationTest.AdminConsole.Repositories.CollectionRepository;
|
|
|
|
/// <summary>
|
|
/// Shared tests for CreateDefaultCollections methods - both bulk and non-bulk implementations,
|
|
/// as they share the same behavior. Both test suites call the tests in this class.
|
|
/// </summary>
|
|
public static class CreateDefaultCollectionsSharedTests
|
|
{
|
|
public static async Task CreatesDefaultCollections_Success(
|
|
Func<Guid, IEnumerable<Guid>, string, Task> createDefaultCollectionsFunc,
|
|
IOrganizationRepository organizationRepository,
|
|
IUserRepository userRepository,
|
|
IOrganizationUserRepository organizationUserRepository,
|
|
ICollectionRepository collectionRepository)
|
|
{
|
|
// Arrange
|
|
var organization = await organizationRepository.CreateTestOrganizationAsync();
|
|
|
|
var resultOrganizationUsers = await Task.WhenAll(
|
|
CreateUserForOrgAsync(userRepository, organizationUserRepository, organization),
|
|
CreateUserForOrgAsync(userRepository, organizationUserRepository, organization)
|
|
);
|
|
|
|
var affectedOrgUserIds = resultOrganizationUsers.Select(organizationUser => organizationUser.Id).ToList();
|
|
var defaultCollectionName = $"default-name-{organization.Id}";
|
|
|
|
// Act
|
|
await createDefaultCollectionsFunc(organization.Id, affectedOrgUserIds, defaultCollectionName);
|
|
|
|
// Assert
|
|
await AssertAllUsersHaveOneDefaultCollectionAsync(collectionRepository, resultOrganizationUsers, organization.Id);
|
|
|
|
await CleanupAsync(organizationRepository, userRepository, organization, resultOrganizationUsers);
|
|
}
|
|
|
|
public static async Task CreatesForNewUsersOnly_AndIgnoresExistingUsers(
|
|
Func<Guid, IEnumerable<Guid>, string, Task> createDefaultCollectionsFunc,
|
|
IOrganizationRepository organizationRepository,
|
|
IUserRepository userRepository,
|
|
IOrganizationUserRepository organizationUserRepository,
|
|
ICollectionRepository collectionRepository)
|
|
{
|
|
// Arrange
|
|
var organization = await organizationRepository.CreateTestOrganizationAsync();
|
|
|
|
var arrangedOrganizationUsers = await Task.WhenAll(
|
|
CreateUserForOrgAsync(userRepository, organizationUserRepository, organization),
|
|
CreateUserForOrgAsync(userRepository, organizationUserRepository, organization)
|
|
);
|
|
|
|
var arrangedOrgUserIds = arrangedOrganizationUsers.Select(organizationUser => organizationUser.Id).ToList();
|
|
var defaultCollectionName = $"default-name-{organization.Id}";
|
|
|
|
await CreateUsersWithExistingDefaultCollectionsAsync(createDefaultCollectionsFunc, collectionRepository, organization.Id, arrangedOrgUserIds, defaultCollectionName, arrangedOrganizationUsers);
|
|
|
|
var newOrganizationUsers = new List<OrganizationUser>
|
|
{
|
|
await CreateUserForOrgAsync(userRepository, organizationUserRepository, organization)
|
|
};
|
|
|
|
var affectedOrgUsers = newOrganizationUsers.Concat(arrangedOrganizationUsers).ToList();
|
|
var affectedOrgUserIds = affectedOrgUsers.Select(organizationUser => organizationUser.Id).ToList();
|
|
|
|
// Act
|
|
await createDefaultCollectionsFunc(organization.Id, affectedOrgUserIds, defaultCollectionName);
|
|
|
|
// Assert
|
|
await AssertAllUsersHaveOneDefaultCollectionAsync(collectionRepository, affectedOrgUsers, organization.Id);
|
|
|
|
await CleanupAsync(organizationRepository, userRepository, organization, affectedOrgUsers);
|
|
}
|
|
|
|
public static async Task IgnoresAllExistingUsers(
|
|
Func<Guid, IEnumerable<Guid>, string, Task> createDefaultCollectionsFunc,
|
|
IOrganizationRepository organizationRepository,
|
|
IUserRepository userRepository,
|
|
IOrganizationUserRepository organizationUserRepository,
|
|
ICollectionRepository collectionRepository)
|
|
{
|
|
// Arrange
|
|
var organization = await organizationRepository.CreateTestOrganizationAsync();
|
|
|
|
var resultOrganizationUsers = await Task.WhenAll(
|
|
CreateUserForOrgAsync(userRepository, organizationUserRepository, organization),
|
|
CreateUserForOrgAsync(userRepository, organizationUserRepository, organization)
|
|
);
|
|
|
|
var affectedOrgUserIds = resultOrganizationUsers.Select(organizationUser => organizationUser.Id).ToList();
|
|
var defaultCollectionName = $"default-name-{organization.Id}";
|
|
|
|
await CreateUsersWithExistingDefaultCollectionsAsync(createDefaultCollectionsFunc, collectionRepository, organization.Id, affectedOrgUserIds, defaultCollectionName, resultOrganizationUsers);
|
|
|
|
// Act - Try to create again, should silently filter and not create duplicates
|
|
await createDefaultCollectionsFunc(organization.Id, affectedOrgUserIds, defaultCollectionName);
|
|
|
|
// Assert - Original collections should remain unchanged, still only one per user
|
|
await AssertAllUsersHaveOneDefaultCollectionAsync(collectionRepository, resultOrganizationUsers, organization.Id);
|
|
|
|
await CleanupAsync(organizationRepository, userRepository, organization, resultOrganizationUsers);
|
|
}
|
|
|
|
private static async Task CreateUsersWithExistingDefaultCollectionsAsync(
|
|
Func<Guid, IEnumerable<Guid>, string, Task> createDefaultCollectionsFunc,
|
|
ICollectionRepository collectionRepository,
|
|
Guid organizationId,
|
|
IEnumerable<Guid> affectedOrgUserIds,
|
|
string defaultCollectionName,
|
|
OrganizationUser[] resultOrganizationUsers)
|
|
{
|
|
await createDefaultCollectionsFunc(organizationId, affectedOrgUserIds, defaultCollectionName);
|
|
|
|
await AssertAllUsersHaveOneDefaultCollectionAsync(collectionRepository, resultOrganizationUsers, organizationId);
|
|
}
|
|
|
|
private static async Task AssertAllUsersHaveOneDefaultCollectionAsync(ICollectionRepository collectionRepository,
|
|
IEnumerable<OrganizationUser> organizationUsers, Guid organizationId)
|
|
{
|
|
foreach (var organizationUser in organizationUsers)
|
|
{
|
|
var collectionDetails = await collectionRepository.GetManyByUserIdAsync(organizationUser!.UserId.Value);
|
|
var defaultCollection = collectionDetails
|
|
.SingleOrDefault(collectionDetail =>
|
|
collectionDetail.OrganizationId == organizationId
|
|
&& collectionDetail.Type == CollectionType.DefaultUserCollection);
|
|
|
|
Assert.NotNull(defaultCollection);
|
|
}
|
|
}
|
|
|
|
private static async Task<OrganizationUser> CreateUserForOrgAsync(IUserRepository userRepository,
|
|
IOrganizationUserRepository organizationUserRepository, Organization organization)
|
|
{
|
|
var user = await userRepository.CreateTestUserAsync();
|
|
var orgUser = await organizationUserRepository.CreateTestOrganizationUserAsync(organization, user);
|
|
|
|
return orgUser;
|
|
}
|
|
|
|
private static async Task CleanupAsync(IOrganizationRepository organizationRepository,
|
|
IUserRepository userRepository,
|
|
Organization organization,
|
|
IEnumerable<OrganizationUser> organizationUsers)
|
|
{
|
|
await organizationRepository.DeleteAsync(organization);
|
|
|
|
await userRepository.DeleteManyAsync(
|
|
organizationUsers
|
|
.Where(organizationUser => organizationUser.UserId != null)
|
|
.Select(organizationUser => new User() { Id = organizationUser.UserId.Value })
|
|
);
|
|
}
|
|
}
|