diff --git a/smart_report.sh b/smart_report.sh index 117b75b..e8d5f2d 100644 --- a/smart_report.sh +++ b/smart_report.sh @@ -10,7 +10,7 @@ smartctl=/usr/local/sbin/smartctl freenashost=$(hostname -s | tr '[:lower:]' '[:upper:]') boundary="===== MIME boundary; FreeNAS server ${freenashost} =====" -logfile="/tmp/smart_report.tmp" +logfile="smart_report.tmp" subject="SMART Status Report for ${freenashost}" tempWarn=40 tempCrit=45 @@ -18,75 +18,54 @@ sectorsCrit=10 testAgeWarn=1 warnSymbol="?" critSymbol="!" +Drive_count=0 +SATA_count=0 +SAS_count=0 +Drive_list="" +SATA_list="" +SAS_list="" -# We need a list of the SMART-enabled drives on the system. Choose one of these -# three methods to provide the list. Comment out the two unused sections of code. - -# 1. A string constant; just key in the devices you want to report on here: -#drives="/dev/da1 /dev/da2 /dev/da3 /dev/da4 /dev/da5 /dev/da6 /dev/da7 /dev/da8 /dev/ada0" - -# 2. A systcl-based technique suggested on the FreeNAS forum: -#drives=$(for drive in $(sysctl -n kern.disks); do \ -#if [ "$("${"$smartctl"}" -i /dev/${drive} | grep "SMART support is: Enabled" | awk '{print $3}')" ] -#then printf ${drive}" "; fi done | awk '{for (i=NF; i!=0 ; i--) print $i }') - -# 3. "$smartctl"-based functions: - +# Get list of SMART-enabled drives get_smart_drives() { - gs_smartdrives="" gs_drives=$("$smartctl" --scan | awk '{print $1}') - for gs_drive in $gs_drives; do gs_smart_flag=$("$smartctl" -i "$gs_drive" | grep -E "SMART support is:[[:blank:]]+Enabled" | awk '{print $4}') if [ "$gs_smart_flag" = "Enabled" ]; then - gs_smartdrives="$gs_smartdrives $gs_drive" + Drive_list="$Drive_list $gs_drive" + Drive_count=$((Drive_count + 1)) fi done - - echo "$gs_smartdrives" } -drives=$(get_smart_drives) - - -# Checks whether it is a SATA disk +# Get list of SATA disks get_sata_drives() { - gsata_smartdrives="" - - for drive in $drives; do + for drive in $Drive_list; do gsata_smart_flag=$("$smartctl" -i "$drive" | grep -E "SATA Version is:[[:blank:]]" | awk '{print $4}') if [ "$gsata_smart_flag" = "SATA" ]; then - gsata_smartdrives="$gsata_smartdrives $drive" + SATA_list="$SATA_list $drive" + SATA_count=$((SATA_count + 1)) fi done - - echo "$gsata_smartdrives" } -satadrives=$(get_sata_drives) - - -# Checks whether it is a SAS disk +# Get list of SAS disks get_sas_drives() { - gsas_smartdrives="" - - for drive in $drives; do + for drive in $Drive_list; do gsas_smart_flag=$("$smartctl" -i "$drive" | grep -E "Transport protocol:[[:blank:]]+SAS" | awk '{print $3}') if [ "$gsas_smart_flag" = "SAS" ]; then - gsas_smartdrives="$gsas_smartdrives $drive" + SAS_list="$SAS_list $drive" + SAS_count=$((SAS_count + 1)) fi done - - echo "$gsas_smartdrives" } -sasdrives=$(get_sas_drives) - -# end of method 3. - +### Fetch drive lists ### +get_smart_drives +get_sata_drives +get_sas_drives ### Set email headers ### printf "%s\n" "To: ${email} @@ -100,158 +79,159 @@ Content-Transfer-Encoding: 7bit Content-Disposition: inline 
" > ${logfile}
 
+if [ $Drive_count -eq 0 ]; then
+  echo "##### No SMART-enabled disks found on this system #####" >> "$logfile"
+fi
 
-###### summary sata ######
-(
-  echo "########## SMART status report summary for all SATA drives on server ${freenashost} ##########"
-  echo ""
-  echo "+------+------------------------+----+-----+-----+-----+-------+-------+--------+------+----------+------+--------------+-----+"
-  echo "|Device|Serial                  |Temp|Power|Start|Spin |ReAlloc|Current|Offline |Seek  |Total     |High  |Command       |Last |"
-  echo "|      |Number                  |    |On   |Stop |Retry|Sectors|Pending|Uncorrec|Errors|Seeks     |Fly   |Timeout       |Test |"
-  echo "|      |                        |    |Hours|Count|Count|       |Sectors|Sectors |      |          |Writes|Count         |Age  |"
-  echo "+------+------------------------+----+-----+-----+-----+-------+-------+--------+------+----------+------+--------------+-----+"
-) >> "$logfile"
-
-###### for each SATA drive ######
-for drive in $satadrives; do
+###### Summary for SATA drives ######
+if [ $SATA_count -gt 0 ]; then
   (
-  devid=$(basename "$drive")
-  lastTestHours=$("$smartctl" -l selftest "$drive" | grep "# 1" | awk '{print $9}')
-  "$smartctl" -A -i -v 7,hex48 "$drive" | \
-  awk -v device="$devid" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" \
-  -v testAgeWarn="$testAgeWarn" -v warnSymbol="$warnSymbol" -v critSymbol="$critSymbol" \
-  -v lastTestHours="$lastTestHours" '
-  /Serial Number:/{serial=$3}
-  /190 Airflow_Temperature/{temp=$10}
-  /194 Temperature/{temp=$10}
-  /Power_On_Hours/{split($10,a,"+");sub(/h/,"",a[1]);onHours=a[1];}
-  /Start_Stop_Count/{startStop=$10}
-  /Spin_Retry_Count/{spinRetry=$10}
-  /Reallocated_Sector/{reAlloc=$10}
-  /Current_Pending_Sector/{pending=$10}
-  /Offline_Uncorrectable/{offlineUnc=$10}
-  /Seek_Error_Rate/{seekErrors=("0x" substr($10,3,4));totalSeeks=("0x" substr($10,7))}
-  /High_Fly_Writes/{hiFlyWr=$10}
-  /Command_Timeout/{cmdTimeout=$10}
-  END {
-    testAge=sprintf("%.0f", (onHours - lastTestHours) / 24);
-    if (temp > tempCrit || reAlloc > sectorsCrit || pending > sectorsCrit || offlineUnc > sectorsCrit)
+   echo "########## SMART status report summary for all SATA drives on server ${freenashost} ##########"
+   echo ""
+   echo "+------+------------------------+----+-----+-----+-----+-------+-------+--------+------+----------+------+-------+----+"
+   echo "|Device|Serial                  |Temp|Power|Start|Spin |ReAlloc|Current|Offline |Seek  |Total     |High  |Command|Last|"
+   echo "|      |Number                  |    |On   |Stop |Retry|Sectors|Pending|Uncorrec|Errors|Seeks     |Fly   |Timeout|Test|"
+   echo "|      |                        |    |Hours|Count|Count|       |Sectors|Sectors |      |          |Writes|Count  |Age |"
+   echo "+------+------------------------+----+-----+-----+-----+-------+-------+--------+------+----------+------+-------+----+"
+  ) >> "$logfile"
+  
+  ###### Detail information for each SATA drive ######
+  for drive in $SATA_list; do
+    (
+    devid=$(basename "$drive")
+    lastTestHours=$("$smartctl" -l selftest "$drive" | grep "# 1" | awk '{print $9}')
+    "$smartctl" -A -i -v 7,hex48 "$drive" | \
+    awk -v device="$devid" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" \
+    -v testAgeWarn="$testAgeWarn" -v warnSymbol="$warnSymbol" -v critSymbol="$critSymbol" \
+    -v lastTestHours="$lastTestHours" '
+    /Serial Number:/{serial=$3}
+    /190 Airflow_Temperature/{temp=$10}
+    /194 Temperature/{temp=$10}
+    /Power_On_Hours/{split($10,a,"+");sub(/h/,"",a[1]);onHours=a[1];}
+    /Start_Stop_Count/{startStop=$10}
+    /Spin_Retry_Count/{spinRetry=$10}
+    /Reallocated_Sector/{reAlloc=$10}
+    /Current_Pending_Sector/{pending=$10}
+    /Offline_Uncorrectable/{offlineUnc=$10}
+    /Seek_Error_Rate/{seekErrors=("0x" substr($10,3,4));totalSeeks=("0x" substr($10,7))}
+    /High_Fly_Writes/{hiFlyWr=$10}
+    /Command_Timeout/{cmdTimeout=$10}
+    END {
+      testAge=sprintf("%.0f", (onHours - lastTestHours) / 24);
+      if (temp > tempCrit || reAlloc > sectorsCrit || pending > sectorsCrit || offlineUnc > sectorsCrit)
+        device=device " " critSymbol;
+      else if (temp > tempWarn || reAlloc > 0 || pending > 0 || offlineUnc > 0 || testAge > testAgeWarn)
+        device=device " " warnSymbol;
+      seekErrors=sprintf("%d", seekErrors);
+      totalSeeks=sprintf("%d", totalSeeks);
+      if (totalSeeks == "0") {
+        seekErrors="N/A";
+        totalSeeks="N/A";
+      }
+
+      if (temp > tempWarn || temp > tempCrit) temp=temp"*"
+      
+      if (reAlloc > 0 || reAlloc > sectorsCrit) reAlloc=reAlloc"*"
+      
+      if (pending > 0 || pending > sectorsCrit) pending=pending"*"
+  
+      if (offlineUnc > 0 || offlineUnc > sectorsCrit) offlineUnc=offlineUnc"*"
+  
+      if (testAge > testAgeWarn) testAge=testAge"*"
+  
+      if (hiFlyWr == "") hiFlyWr="N/A";
+
+      if (cmdTimeout == "") cmdTimeout="N/A";
+
+      printf "|%-6s|%-24s|%-4s|%5s|%5s|%5s|%7s|%7s|%8s|%6s|%10s|%6s|%7s|%4s|\n",
+        device, serial, temp, onHours, startStop, spinRetry, reAlloc, pending, offlineUnc,
+        seekErrors, totalSeeks, hiFlyWr, cmdTimeout, testAge;
+      }'
+    ) >> "$logfile"
+  done
+  (
+    echo "+------+------------------------+----+-----+-----+-----+-------+-------+--------+------+----------+------+-------+----+"
+  ) >> "$logfile"
+fi
+
+###### Summary for SAS drives ######
+if [ $SAS_count -gt 0 ]; then
+  (
+    if [ $SATA_count -gt 0 ]; then
+      echo ""
+    fi
+  
+    echo "########## SMART status report summary for all SAS drives on server ${freenashost} ##########"
+    echo ""
+    echo "+------+------------------------+----+-----+------+------+------+------+------+------+"
+    echo "|Device|Serial                  |Temp|Start|Load  |Defect|Uncorr|Uncorr|Uncorr|Non   |"
+    echo "|      |Number                  |    |Stop |Unload|List  |Read  |Write |Verify|Medium|"
+    echo "|      |                        |    |Count|Count |Elems |Errors|Errors|Errors|Errors|"
+    echo "+------+------------------------+----+-----+------+------+------+------+------+------+"
+  ) >> "$logfile"
+  
+  ###### Detail information for each SAS drive ######
+  for drive in $SAS_list; do
+    (
+    devid=$(basename "$drive")
+    "$smartctl" -a "$drive" | \
+    awk -v device="$devid" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" \
+    -v warnSymbol="$warnSymbol" -v critSymbol="$critSymbol" '\
+    /Serial number:/{serial=$3}
+    /Current Drive Temperature:/{temp=$4} \
+    /start-stop cycles:/{startStop=$4} \
+    /load-unload cycles:/{loadUnload=$4} \
+    /grown defect list:/{defectList=$6} \
+    /read:/{readErrors=$8} \
+    /write:/{writeErrors=$8} \
+    /verify:/{verifyErrors=$8} \
+    /Non-medium error count:/{nonMediumErrors=$4} \
+    END {
+      if (temp > tempCrit)
       device=device " " critSymbol;
-    else if (temp > tempWarn || reAlloc > 0 || pending > 0 || offlineUnc > 0 || testAge > testAgeWarn)
-      device=device " " warnSymbol;
-    seekErrors=sprintf("%d", seekErrors);
-    totalSeeks=sprintf("%d", totalSeeks);
-    if (totalSeeks == "0") {
-      seekErrors="N/A";
-      totalSeeks="N/A";
-    }
-    if (temp > tempWarn || temp > tempCrit)
-       temp=temp"*"
-    else
-       temp=temp" "
-
-    if (reAlloc > 0 || reAlloc > sectorsCrit)
-       reAlloc=reAlloc"*"
-    
-    if (pending > 0 || pending > sectorsCrit)
-       pending=pending"*"
-
-    if (offlineUnc > 0 || offlineUnc > sectorsCrit)
-       offlineUnc=offlineUnc"*"
-
-    if (testAge > testAgeWarn)
-       testAge=testAge"*"
-
-    if (hiFlyWr == "") hiFlyWr="N/A";
-    if (cmdTimeout == "") cmdTimeout="N/A";
-    printf "|%-6s|%-24s| %3s|%5s|%5s|%5s|%7s|%7s|%8s|%6s|%10s|%6s|%14s|%5s|\n",
-    device, serial, temp, onHours, startStop, spinRetry, reAlloc, pending, offlineUnc,
-    seekErrors, totalSeeks, hiFlyWr, cmdTimeout, testAge;
-    }'
-  ) >> "$logfile"
-done
-(
-  echo "+------+------------------------+----+-----+-----+-----+-------+-------+--------+------+----------+------+--------------+-----+"
-) >> "$logfile"
-
-(
-  echo ""
-  echo ""
-  echo ""
-) >> "$logfile"
-
-
-###### summary sas ######
-(
-  echo ""
-  echo "########## SMART status report summary for all SAS drives on server ${freenashost} ##########"
-  echo ""
-  echo "+------+------------------------+----+-----+------+------+------+------+------+------+"
-  echo "|Device|Serial                  |Temp|Start|Load  |Defect|Uncorr|Uncorr|Uncorr|Non   |"
-  echo "|      |Number                  |    |Stop |Unload|List  |Read  |Write |Verify|Medium|"
-  echo "|      |                        |    |Count|Count |Elems |Errors|Errors|Errors|Errors|"
-  echo "+------+------------------------+----+-----+------+------+------+------+------+------+"
-) >> "$logfile"
-
-###### for each SAS drive ######
-for drive in $sasdrives; do
+    else if (temp > tempWarn)
+        device=device " " warnSymbol;
+      printf "|%-6s|%-24s| %3s|%5s|%6s|%6s|%6s|%6s|%6s|%6s|\n",
+      device, serial, temp, startStop, loadUnload, defectList, \
+      readErrors, writeErrors, verifyErrors, nonMediumErrors;
+     }'
+    ) >> "$logfile"
+  done
   (
-  devid=$(basename "$drive")
-  "$smartctl" -a "$drive" | \
-  awk -v device="$devid" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" \
-  -v warnSymbol="$warnSymbol" -v critSymbol="$critSymbol" '\
-  /Serial number:/{serial=$3}
-  /Current Drive Temperature:/{temp=$4} \
-  /start-stop cycles:/{startStop=$4} \
-  /load-unload cycles:/{loadUnload=$4} \
-  /grown defect list:/{defectList=$6} \
-  /read:/{readErrors=$8} \
-  /write:/{writeErrors=$8} \
-  /verify:/{verifyErrors=$8} \
-  /Non-medium error count:/{nonMediumErrors=$4} \
-  END {
-    if (temp > tempCrit)
-	  device=device " " critSymbol;
-	else if (temp > tempWarn)
-      device=device " " warnSymbol;
-	  printf "|%-6s|%-24s| %3s|%5s|%6s|%6s|%6s|%6s|%6s|%6s|\n",
-	  device, serial, temp, startStop, loadUnload, defectList, \
-	  readErrors, writeErrors, verifyErrors, nonMediumErrors;
-   }'
+    echo "+------+------------------------+----+-----+------+------+------+------+------+------+"
   ) >> "$logfile"
-done
-(
-  echo "+------+------------------------+----+-----+------+------+------+------+------+------+"
-) >> "$logfile"
+fi
 
-
-###### for SATA drives ######
-for drive in $satadrives; do
-  brand=$("$smartctl" -i "$drive" | grep "Model Family" | sed "s/^.*   //")
-  if [ -z "$brand" ]; then
-    brand=$("$smartctl" -i "$drive" | grep "Device Model" | sed "s/^.* //")
-  fi
-  serial=$("$smartctl" -i "$drive" | grep "Serial Number" | sed "s/^.* //")
-  (
-  echo ""
-  echo "########## SMART status report for $drive drive (${brand} : ${serial}) ##########"
-  "$smartctl" -n never -H -A -l error "$drive"
-  "$smartctl" -n never -l selftest "$drive" | grep "# 1 \\|Num" | cut -c6-
-  ) >> "$logfile"
-done
-
-###### for SAS drives ######
-for drive in $sasdrives; do
-  devid=$(basename "$drive")
-  brand=$("$smartctl" -i "$drive" | grep "Product" | sed "s/^.* //")
-  serial=$("$smartctl" -i "$drive" | grep "Serial number" | sed "s/^.* //")
-  (
-  echo ""
-  echo "########## SMART status report for $drive drive (${brand} : ${serial}) ##########"
-  "$smartctl" -n never -H -A -l error "$drive"
-  "$smartctl" -n never -l selftest "$drive" | grep "# 1 \\|Num" | cut -c6-
-  ) >> "$logfile"
-done
+if [ $SATA_count -gt 0 ] || [ $SAS_count -gt 0 ]; then
+ 
+  ###### Emit SATA drive information ######
+  for drive in $SATA_list; do
+    brand=$("$smartctl" -i "$drive" | grep "Model Family" | awk '{print $3, $4, $5, $6, $7}')
+    if [ -z "$brand" ]; then
+      brand=$("$smartctl" -i "$drive" | grep "Device Model" | awk '{print $3, $4, $5, $6, $7}')
+    fi
+    serial=$("$smartctl" -i "$drive" | grep "Serial Number" | awk '{print $3}')
+    (
+    echo ""
+    echo "########## SMART status for SATA drive $drive $serial (${brand}) ##########"
+    "$smartctl" -n never -H -A -l error "$drive"
+    "$smartctl" -n never -l selftest "$drive" | grep "# 1 \\|Num" | cut -c6-
+    ) >> "$logfile"
+  done
+  
+  ###### Emit SAS drive information ######
+  for drive in $SAS_list; do
+    devid=$(basename "$drive")
+    brand=$("$smartctl" -i "$drive" | grep "Product" | sed "s/^.* //")
+    serial=$("$smartctl" -i "$drive" | grep "Serial number" | sed "s/^.* //")
+    (
+    echo ""
+    echo "########## SMART status for SAS drive $drive $serial (${brand}) ##########"
+    "$smartctl" -n never -H -A -l error "$drive"
+    "$smartctl" -n never -l selftest "$drive" | grep "# 1 \\|Num" | cut -c6-
+    ) >> "$logfile"
+  done
+fi
 
 sed -i '' -e '/smartctl 7.*/d' "$logfile"
 sed -i '' -e '/smartctl 6.*/d' "$logfile"