From 12bded980b241db809f2cb3badc61e12a8216fe5 Mon Sep 17 00:00:00 2001 From: nielash Date: Thu, 21 Aug 2025 10:10:04 -0400 Subject: [PATCH] bisync: fix --no-slow-hash settings on path2 Before this change, if path2 had slow hashes, and --no-slow-hash or --slow-hash-sync-only was in use, bisync was erroneously setting path1's hashtype to 'none' instead of path2's. This change fixes the issue. See https://forum.rclone.org/t/hashtype-mismatch-with-slow-hash-sync-only-in-onedrive-local-bisync/52138/2?u=nielash --- cmd/bisync/compare.go | 2 +- docs/content/bisync.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/bisync/compare.go b/cmd/bisync/compare.go index 33079d5f7..cf69b5d1c 100644 --- a/cmd/bisync/compare.go +++ b/cmd/bisync/compare.go @@ -177,7 +177,7 @@ func (b *bisyncRun) setHashType(ci *fs.ConfigInfo) { } if (b.opt.Compare.NoSlowHash || b.opt.Compare.SlowHashSyncOnly) && b.fs2.Features().SlowHash { fs.Infoc(nil, Color(terminal.YellowFg, "Slow hash detected on Path2. Will ignore checksum due to slow-hash settings")) - b.opt.Compare.HashType1 = hash.None + b.opt.Compare.HashType2 = hash.None } else { b.opt.Compare.HashType2 = b.fs2.Hashes().GetOne() if b.opt.Compare.HashType2 != hash.None { diff --git a/docs/content/bisync.md b/docs/content/bisync.md index 957314f44..5942e5b4b 100644 --- a/docs/content/bisync.md +++ b/docs/content/bisync.md @@ -1816,6 +1816,7 @@ about _Unison_ and synchronization in general. ## Changelog ### `v1.71` +* Fixed an issue causing hash type to be set incorrectly if `path2` had slow hashes and `--no-slow-hash` or `--slow-hash-sync-only` was in use. * Fixed an issue causing errors when running concurrent bisync runs through the `rc`. ### `v1.69.1`