jgaunt/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-12-06 00:03:32 +00:00
Code Issues Projects Releases Wiki Activity

azurefiles: Fix server side copy not waiting for completion - fixes #8848

Browse Source
This commit is contained in:
Vikas Bhansali
2025-09-26 17:11:42 +05:30
committed by GitHub
parent 913278327b
commit 519623d9f1
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
backend/azurefiles/azurefiles.go
View File

@@ -1313,10 +1313,29 @@ func (f *Fs) Copy(ctx context.Context, src fs.Object, remote string) (fs.Object,
} }
srcURL := srcObj.fileClient().URL() srcURL := srcObj.fileClient().URL()
fc := f.fileClient(remote) fc := f.fileClient(remote)
_, err = fc.StartCopyFromURL(ctx, srcURL, &opt) startCopy, err := fc.StartCopyFromURL(ctx, srcURL, &opt)
if err != nil { if err != nil {
return nil, fmt.Errorf("Copy failed: %w", err) return nil, fmt.Errorf("Copy failed: %w", err)
} }
// Poll for completion if necessary
//
// The for loop is never executed for same storage account copies.
copyStatus := startCopy.CopyStatus
var properties file.GetPropertiesResponse
pollTime := 100 * time.Millisecond
for copyStatus != nil && string(*copyStatus) == string(file.CopyStatusTypePending) {
time.Sleep(pollTime)
properties, err = fc.GetProperties(ctx, &file.GetPropertiesOptions{})
if err != nil {
return nil, err
}
copyStatus = properties.CopyStatus
pollTime = min(2*pollTime, time.Second)
}
dstObj, err := f.NewObject(ctx, remote) dstObj, err := f.NewObject(ctx, remote)
if err != nil { if err != nil {
return nil, fmt.Errorf("Copy: NewObject failed: %w", err) return nil, fmt.Errorf("Copy: NewObject failed: %w", err)