config: load config file only on first access (closes #1659, closes #2096) (#2147)

cmd/version/version_test.go

@@ -0,0 +1,43 @@
+package version
+
+import (
+	"io/ioutil"
+	"os"
+	"testing"
+
+	"github.com/ncw/rclone/cmd"
+	"github.com/ncw/rclone/fs/config"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestVersionWorksWithoutAccessibleConfigFile(t *testing.T) {
+	// create temp config file
+	tempFile, err := ioutil.TempFile("", "unreadable_config.conf")
+	assert.NoError(t, err)
+	path := tempFile.Name()
+	defer func() {
+		err := os.Remove(path)
+		assert.NoError(t, err)
+	}()
+	assert.NoError(t, tempFile.Close())
+	assert.NoError(t, os.Chmod(path, 0000))
+	// re-wire
+	oldOsStdout := os.Stdout
+	oldConfigPath := config.ConfigPath
+	config.ConfigPath = path
+	os.Stdout = nil
+	defer func() {
+		os.Stdout = oldOsStdout
+		config.ConfigPath = oldConfigPath
+	}()
+
+	cmd.Root.SetArgs([]string{"version"})
+	assert.NotPanics(t, func() {
+		assert.NoError(t, cmd.Root.Execute())
+	})
+
+	cmd.Root.SetArgs([]string{"--version"})
+	assert.NotPanics(t, func() {
+		assert.NoError(t, cmd.Root.Execute())
+	})
+}