jgaunt/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-12-06 00:03:32 +00:00
Code Issues Projects Releases Wiki Activity

build: fix errors spotted by ineffassign linter

Browse Source 
These were mostly caused by shadowing err and a good fraction of them
will have caused errors not to be propagated properly.
This commit is contained in:
Nick Craig-Wood
2018-05-04 15:19:50 +01:00
parent 790a8a9aed
commit cb5bd47e61
19 changed files with 37 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
vfs/read_write_test.go
View File

@@ -155,7 +155,7 @@ func TestRWFileHandleSeek(t *testing.T) {
assert.Equal(t, "d", rwReadString(t, fh, 1))
// Seek off the end
n, err = fh.Seek(100, io.SeekStart)
_, err = fh.Seek(100, io.SeekStart)
assert.NoError(t, err)
// Get the error on read
@@ -215,7 +215,7 @@ func TestRWFileHandleReadAt(t *testing.T) {
assert.NoError(t, fh.Close())
// check reading on closed file
n, err = fh.ReadAt(buf, 100)
_, err = fh.ReadAt(buf, 100)
assert.Equal(t, ECLOSED, err)
}
@@ -351,6 +351,7 @@ func TestRWFileHandleMethodsWrite(t *testing.T) {
// check vfs
root, err := vfs.Root()
require.NoError(t, err)
checkListing(t, root, []string{"file1,11,false"})
// check the underlying r.Fremote but not the modtime
@@ -399,6 +400,7 @@ func TestRWFileHandleWriteAt(t *testing.T) {
// check vfs
root, err := vfs.Root()
require.NoError(t, err)
checkListing(t, root, []string{"file1,11,false"})
// check the underlying r.Fremote but not the modtime
@@ -427,6 +429,7 @@ func TestRWFileHandleWriteNoWrite(t *testing.T) {
// check vfs
root, err := vfs.Root()
require.NoError(t, err)
checkListing(t, root, []string{"file1,0,false", "file2,0,false"})
// check the underlying r.Fremote but not the modtime