jgaunt/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2026-01-06 02:23:24 +00:00
Code Issues Projects Releases Wiki Activity

bisync: add overlapping paths check

Browse Source 
Before this change, Bisync did not check to make sure that Path1 and Path2 do
not overlap, nor did it check for overlaps with `--backup-dir`. While `sync`
does check for these things, it can sometimes be fooled because of the way
Bisync calls it with `--files-from` filters. Relying on sync could also leave a
run in a half-finished state if it were to error in one direction but not the
other (`--backup-dir` only checks for overlaps with the dest.)

After this change, Bisync does its own check up front, so we can quickly return
an error and exit before any changes are made.
This commit is contained in:
nielash
2023-12-18 13:03:14 -05:00
parent e9cd3e5986
commit e71b252b65
35 changed files with 350 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/bisync/testdata/test_backupdir/modfiles/file1.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer

1
cmd/bisync/testdata/test_backupdir/modfiles/file10.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer

1
cmd/bisync/testdata/test_backupdir/modfiles/file11.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer

1
cmd/bisync/testdata/test_backupdir/modfiles/file2.txt vendored Normal file
View File

@@ -0,0 +1 @@
Newer version

1
cmd/bisync/testdata/test_backupdir/modfiles/file5L.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer and not equal to 5R

1
cmd/bisync/testdata/test_backupdir/modfiles/file5R.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer and not equal to 5L

1
cmd/bisync/testdata/test_backupdir/modfiles/file6.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer

1
cmd/bisync/testdata/test_backupdir/modfiles/file7.txt vendored Normal file
View File

@@ -0,0 +1 @@
This file is newer