11 Commits

Author	SHA1	Message	Date
Nick Craig-Wood	b5cbb7520d	lib/pool: fix unreliable TestPoolMaxBufferMemory test ... This turned out to be a problem in the tests. The tests used to do 1. allocate 2. increment 3. free 4. decrement But if one goroutine had just completed 2 and another had just completed 3 then this can cause the test to register too many allocations. This was fixed by doing the test in this order instead: 1. allocate 2. increment 3. decrement 4. free The 4 operations are atomic. Fixes #8813	2025-09-12 10:39:32 +01:00
dougal	35fe609722	pool: fix flaky unreliability test	2025-09-11 18:09:50 +01:00
Nick Craig-Wood	8c37a9c2ef	lib/pool: fix flaky test which was causing timeouts ... This puts a limit on the number of allocation failures in a row which stops the test timing out as the exponential backoffs get very large.	2025-09-01 16:25:31 +01:00
Nick Craig-Wood	0c0fb93111	pool: fix deadlock with --max-buffer-memory ... Before this change we used an overcomplicated method of memory reservations in the pool.RW which caused deadlocks. This changes it to use a much simpler reservation system where we actually reserve the memory and store it in the pool.RW. This allows us to use the semaphore.Weighted to count the actually memory in use (rather than the memory in use and in the cache). This in turn allows accurate use of the semaphore by users wanting memory.	2025-08-14 16:14:59 +01:00
Nick Craig-Wood	5050f42b8b	pool: unify memory between multipart and asyncreader to use one pool ... Before this the multipart code and asyncreader used separate pools which is inefficient on memory use.	2025-08-07 12:45:44 +01:00
Nick Craig-Wood	19aa366d88	pool: add --max-buffer-memory to limit total buffer memory usage	2025-03-17 18:01:15 +00:00
Nick Craig-Wood	401cf81034	build: modernize Go usage ... This commit modernizes Go usage. This was done with: go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./... Then files needed to be `go fmt`ed and a few comments needed to be restored. The modernizations include replacing - if/else conditional assignment by a call to the built-in min or max functions added in go1.21 - sort.Slice(x, func(i, j int) bool) { return s[i] < s[j] } by a call to slices.Sort(s), added in go1.21 - interface{} by the 'any' type added in go1.18 - append([]T(nil), s...) by slices.Clone(s) or slices.Concat(s), added in go1.21 - loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21 - []byte(fmt.Sprintf...) by fmt.Appendf(nil, ...), added in go1.19 - append(s[:i], s[i+1]...) by slices.Delete(s, i, i+1), added in go1.21 - a 3-clause for i := 0; i < n; i++ {} loop by for i := range n {}, added in go1.22	2025-02-28 11:31:14 +00:00
Nick Craig-Wood	b58bb03e95	test: Don't run unreliable tests on CI #4171	2020-06-15 21:34:37 +01:00
Nick Craig-Wood	cfba337ef0	lib/pool: fix memory leak by freeing buffers on flush	2019-02-06 17:20:54 +00:00
Nick Craig-Wood	da90069462	lib/pool: only flush buffers if they are unused between flush intervals	2019-02-03 19:07:50 +00:00
Nick Craig-Wood	bed2971bf0	lib/pool: a buffer recycling library which can be optionally be used with mmap	2019-02-02 14:35:56 +00:00