Version v1.49.1

This fixes a crash on the google photos backend when an error is
returned from the rest.Call function.

This turned out to be a mis-understanding of the rest docs so
- improved rest.Call docs
- fixed mis-understanding in google photos backend
- fixed similar mis-understading in onedrive backend

MANUAL.html

@@ -17,7 +17,7 @@
 <header>
 <h1 class="title">rclone(1) User Manual</h1>
 <p class="author">Nick Craig-Wood</p>
-<p class="date">Aug 26, 2019</p>
+<p class="date">Aug 28, 2019</p>
 </header>
 <h1 id="rclone---rsync-for-cloud-storage">Rclone - rsync for cloud storage</h1>
 <p>Rclone is a command line program to sync files and directories to and from:</p>
@@ -4590,7 +4590,7 @@ Showing nodes accounting for 1537.03kB, 100% of 1537.03kB total
       --use-json-log                         Use json log format.
       --use-mmap                             Use mmap allocator (see docs).
       --use-server-modtime                   Use server modified time instead of object metadata
-      --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default &quot;rclone/v1.49.0&quot;)
+      --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default &quot;rclone/v1.49.1&quot;)
   -v, --verbose count                        Print lots more stuff (repeat for more)</code></pre>
 <h2 id="backend-flags">Backend Flags</h2>
 <p>These flags are available for every command. They control the backends and may be set in the config file.</p>
@@ -12288,6 +12288,23 @@ $ tree /tmp/b
 </ul>
 <!--- autogenerated options stop -->
 <h1 id="changelog">Changelog</h1>
+<h2 id="v1.49.1---2019-08-28">v1.49.1 - 2019-08-28</h2>
+<p>Point release to fix config bug and google photos backend.</p>
+<ul>
+<li>Bug Fixes
+<ul>
+<li>config: Fix generated passwords being stored as empty password (Nick Craig-Wood)</li>
+<li>rcd: Added missing parameter for web-gui info logs. (Chaitanya)</li>
+</ul></li>
+<li>Googlephotos
+<ul>
+<li>Fix crash on error response (Nick Craig-Wood)</li>
+</ul></li>
+<li>Onedrive
+<ul>
+<li>Fix crash on error response (Nick Craig-Wood)</li>
+</ul></li>
+</ul>
 <h2 id="v1.49.0---2019-08-26">v1.49.0 - 2019-08-26</h2>
 <ul>
 <li>New backends
@@ -12302,8 +12319,10 @@ $ tree /tmp/b
 <li>Experimental <a href="https://rclone.org/gui/">web GUI</a> (Chaitanya Bankanhal)</li>
 <li>Implement <code>--compare-dest</code> &amp; <code>--copy-dest</code> (yparitcher)</li>
 <li>Implement <code>--suffix</code> without <code>--backup-dir</code> for backup to current dir (yparitcher)</li>
+<li><code>config reconnect</code> to re-login (re-run the oauth login) for the backend. (Nick Craig-Wood)</li>
+<li><code>config userinfo</code> to discover which user you are logged in as. (Nick Craig-Wood)</li>
+<li><code>config disconnect</code> to disconnect you (log out) from the backend. (Nick Craig-Wood)</li>
 <li>Add <code>--use-json-log</code> for JSON logging (justinalin)</li>
-<li>Add <code>config reconnect</code>, <code>config userinfo</code> and <code>config disconnect</code> subcommands. (Nick Craig-Wood)</li>
 <li>Add context propagation to rclone (Aleksandar Jankovic)</li>
 <li>Reworking internal statistics interfaces so they work with rc jobs (Aleksandar Jankovic)</li>
 <li>Add Higher units for ETA (AbelThar)</li>

MANUAL.md

@@ -1,6 +1,6 @@
 % rclone(1) User Manual
 % Nick Craig-Wood
-% Aug 26, 2019
+% Aug 28, 2019
 
 # Rclone - rsync for cloud storage
 
@@ -8245,7 +8245,7 @@ These flags are available for every command.
       --use-json-log                         Use json log format.
       --use-mmap                             Use mmap allocator (see docs).
       --use-server-modtime                   Use server modified time instead of object metadata
-      --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default "rclone/v1.49.0")
+      --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default "rclone/v1.49.1")
   -v, --verbose count                        Print lots more stuff (repeat for more)
 ```
 
@@ -18466,6 +18466,18 @@ to override the default choice.
 
 # Changelog
 
+## v1.49.1 - 2019-08-28
+
+Point release to fix config bug and google photos backend.
+
+* Bug Fixes
+    * config: Fix generated passwords being stored as empty password (Nick Craig-Wood)
+    * rcd: Added missing parameter for web-gui info logs. (Chaitanya)
+* Googlephotos
+    * Fix crash on error response (Nick Craig-Wood)
+* Onedrive
+    * Fix crash on error response (Nick Craig-Wood)
+
 ## v1.49.0 - 2019-08-26
 
 * New backends
@@ -18477,8 +18489,10 @@ to override the default choice.
     * Experimental [web GUI](https://rclone.org/gui/) (Chaitanya Bankanhal)
     * Implement `--compare-dest` & `--copy-dest` (yparitcher)
     * Implement `--suffix` without `--backup-dir` for backup to current dir (yparitcher)
+    * `config reconnect` to re-login (re-run the oauth login) for the backend. (Nick Craig-Wood)
+    * `config userinfo` to discover which user you are logged in as. (Nick Craig-Wood)
+    * `config disconnect` to disconnect you (log out) from the backend. (Nick Craig-Wood)
     * Add `--use-json-log` for JSON logging (justinalin)
-    * Add `config reconnect`, `config userinfo` and `config disconnect` subcommands. (Nick Craig-Wood)
     * Add context propagation to rclone (Aleksandar Jankovic)
     * Reworking internal statistics interfaces so they work with rc jobs (Aleksandar Jankovic)
     * Add Higher units for ETA (AbelThar)

MANUAL.txt

@@ -1,6 +1,6 @@
 rclone(1) User Manual
 Nick Craig-Wood
-Aug 26, 2019
+Aug 28, 2019
 
 
 
@@ -7824,7 +7824,7 @@ These flags are available for every command.
           --use-json-log                         Use json log format.
           --use-mmap                             Use mmap allocator (see docs).
           --use-server-modtime                   Use server modified time instead of object metadata
-          --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default "rclone/v1.49.0")
+          --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default "rclone/v1.49.1")
       -v, --verbose count                        Print lots more stuff (repeat for more)
 
 
@@ -17923,6 +17923,20 @@ override the default choice.
 CHANGELOG
 
 
+v1.49.1 - 2019-08-28
+
+Point release to fix config bug and google photos backend.
+
+-   Bug Fixes
+    -   config: Fix generated passwords being stored as empty password
+        (Nick Craig-Wood)
+    -   rcd: Added missing parameter for web-gui info logs. (Chaitanya)
+-   Googlephotos
+    -   Fix crash on error response (Nick Craig-Wood)
+-   Onedrive
+    -   Fix crash on error response (Nick Craig-Wood)
+
+
 v1.49.0 - 2019-08-26
 
 -   New backends
@@ -17935,9 +17949,13 @@ v1.49.0 - 2019-08-26
     -   Implement --compare-dest & --copy-dest (yparitcher)
     -   Implement --suffix without --backup-dir for backup to current
         dir (yparitcher)
+    -   config reconnect to re-login (re-run the oauth login) for the
+        backend. (Nick Craig-Wood)
+    -   config userinfo to discover which user you are logged in as.
+        (Nick Craig-Wood)
+    -   config disconnect to disconnect you (log out) from the backend.
+        (Nick Craig-Wood)
     -   Add --use-json-log for JSON logging (justinalin)
-    -   Add config reconnect, config userinfo and config disconnect
-        subcommands. (Nick Craig-Wood)
     -   Add context propagation to rclone (Aleksandar Jankovic)
     -   Reworking internal statistics interfaces so they work with rc
         jobs (Aleksandar Jankovic)

backend/googlephotos/googlephotos.go

@@ -956,7 +956,6 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
 	err = o.fs.pacer.CallNoRetry(func() (bool, error) {
 		resp, err = o.fs.srv.Call(&opts)
 		if err != nil {
-			_ = resp.Body.Close()
 			return shouldRetry(resp, err)
 		}
 		token, err = rest.ReadBody(resp)

backend/onedrive/onedrive.go

@@ -1464,22 +1464,24 @@ func (o *Object) uploadFragment(url string, start int64, totalSize int64, chunk
 	}
 	//	var response api.UploadFragmentResponse
 	var resp *http.Response
+	var body []byte
 	err = o.fs.pacer.Call(func() (bool, error) {
 		_, _ = chunk.Seek(0, io.SeekStart)
 		resp, err = o.fs.srv.Call(&opts)
-		if resp != nil {
-			defer fs.CheckClose(resp.Body, &err)
+		if err != nil {
+			return shouldRetry(resp, err)
 		}
-		retry, err := shouldRetry(resp, err)
-		if !retry && resp != nil {
-			if resp.StatusCode == 200 || resp.StatusCode == 201 {
-				// we are done :)
-				// read the item
-				info = &api.Item{}
-				return false, json.NewDecoder(resp.Body).Decode(info)
-			}
+		body, err = rest.ReadBody(resp)
+		if err != nil {
+			return shouldRetry(resp, err)
 		}
-		return retry, err
+		if resp.StatusCode == 200 || resp.StatusCode == 201 {
+			// we are done :)
+			// read the item
+			info = &api.Item{}
+			return false, json.Unmarshal(body, info)
+		}
+		return false, nil
 	})
 	return info, err
 }

cmd/rcd/rcd.go

@@ -61,7 +61,7 @@ See the [rc documentation](/rc/) for more info on the rc flags.
 			}
 			if rcflags.Opt.HTTPOptions.BasicUser == "" {
 				rcflags.Opt.HTTPOptions.BasicUser = "gui"
-				fs.Infof("Using default username: %s \n", rcflags.Opt.HTTPOptions.BasicUser)
+				fs.Infof(nil, "Using default username: %s \n", rcflags.Opt.HTTPOptions.BasicUser)
 			}
 			if rcflags.Opt.HTTPOptions.BasicPass == "" {
 				randomPass, err := random.Password(128)
@@ -69,7 +69,7 @@ See the [rc documentation](/rc/) for more info on the rc flags.
 					log.Fatalf("Failed to make password: %v", err)
 				}
 				rcflags.Opt.HTTPOptions.BasicPass = randomPass
-				fs.Infof("No password specified. Using random password: %s \n", randomPass)
+				fs.Infof(nil, "No password specified. Using random password: %s \n", randomPass)
 			}
 			rcflags.Opt.Serve = true
 		}

docs/content/changelog.md

@@ -1,11 +1,23 @@
 ---
 title: "Documentation"
 description: "Rclone Changelog"
-date: "2019-08-26"
+date: "2019-08-28"
 ---
 
 # Changelog
 
+## v1.49.1 - 2019-08-28
+
+Point release to fix config bug and google photos backend.
+
+* Bug Fixes
+    * config: Fix generated passwords being stored as empty password (Nick Craig-Wood)
+    * rcd: Added missing parameter for web-gui info logs. (Chaitanya)
+* Googlephotos
+    * Fix crash on error response (Nick Craig-Wood)
+* Onedrive
+    * Fix crash on error response (Nick Craig-Wood)
+
 ## v1.49.0 - 2019-08-26
 
 * New backends

docs/content/commands/rclone.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone"
 slug: rclone
 url: /commands/rclone/

docs/content/commands/rclone_about.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone about"
 slug: rclone_about
 url: /commands/rclone_about/

docs/content/commands/rclone_authorize.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone authorize"
 slug: rclone_authorize
 url: /commands/rclone_authorize/

docs/content/commands/rclone_cachestats.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone cachestats"
 slug: rclone_cachestats
 url: /commands/rclone_cachestats/

docs/content/commands/rclone_cat.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone cat"
 slug: rclone_cat
 url: /commands/rclone_cat/

docs/content/commands/rclone_check.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone check"
 slug: rclone_check
 url: /commands/rclone_check/

docs/content/commands/rclone_cleanup.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone cleanup"
 slug: rclone_cleanup
 url: /commands/rclone_cleanup/

docs/content/commands/rclone_config.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config"
 slug: rclone_config
 url: /commands/rclone_config/

docs/content/commands/rclone_config_create.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config create"
 slug: rclone_config_create
 url: /commands/rclone_config_create/

docs/content/commands/rclone_config_delete.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config delete"
 slug: rclone_config_delete
 url: /commands/rclone_config_delete/

docs/content/commands/rclone_config_disconnect.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config disconnect"
 slug: rclone_config_disconnect
 url: /commands/rclone_config_disconnect/

docs/content/commands/rclone_config_dump.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config dump"
 slug: rclone_config_dump
 url: /commands/rclone_config_dump/

docs/content/commands/rclone_config_edit.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config edit"
 slug: rclone_config_edit
 url: /commands/rclone_config_edit/

docs/content/commands/rclone_config_file.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config file"
 slug: rclone_config_file
 url: /commands/rclone_config_file/

docs/content/commands/rclone_config_password.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config password"
 slug: rclone_config_password
 url: /commands/rclone_config_password/

docs/content/commands/rclone_config_providers.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config providers"
 slug: rclone_config_providers
 url: /commands/rclone_config_providers/

docs/content/commands/rclone_config_reconnect.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config reconnect"
 slug: rclone_config_reconnect
 url: /commands/rclone_config_reconnect/

docs/content/commands/rclone_config_show.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config show"
 slug: rclone_config_show
 url: /commands/rclone_config_show/

docs/content/commands/rclone_config_update.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config update"
 slug: rclone_config_update
 url: /commands/rclone_config_update/

docs/content/commands/rclone_config_userinfo.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone config userinfo"
 slug: rclone_config_userinfo
 url: /commands/rclone_config_userinfo/

docs/content/commands/rclone_copy.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone copy"
 slug: rclone_copy
 url: /commands/rclone_copy/

docs/content/commands/rclone_copyto.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone copyto"
 slug: rclone_copyto
 url: /commands/rclone_copyto/

docs/content/commands/rclone_copyurl.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone copyurl"
 slug: rclone_copyurl
 url: /commands/rclone_copyurl/

docs/content/commands/rclone_cryptcheck.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone cryptcheck"
 slug: rclone_cryptcheck
 url: /commands/rclone_cryptcheck/

docs/content/commands/rclone_cryptdecode.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone cryptdecode"
 slug: rclone_cryptdecode
 url: /commands/rclone_cryptdecode/

docs/content/commands/rclone_dbhashsum.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone dbhashsum"
 slug: rclone_dbhashsum
 url: /commands/rclone_dbhashsum/

docs/content/commands/rclone_dedupe.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone dedupe"
 slug: rclone_dedupe
 url: /commands/rclone_dedupe/

docs/content/commands/rclone_delete.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone delete"
 slug: rclone_delete
 url: /commands/rclone_delete/

docs/content/commands/rclone_deletefile.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone deletefile"
 slug: rclone_deletefile
 url: /commands/rclone_deletefile/

docs/content/commands/rclone_genautocomplete.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone genautocomplete"
 slug: rclone_genautocomplete
 url: /commands/rclone_genautocomplete/

docs/content/commands/rclone_genautocomplete_bash.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone genautocomplete bash"
 slug: rclone_genautocomplete_bash
 url: /commands/rclone_genautocomplete_bash/

docs/content/commands/rclone_genautocomplete_zsh.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone genautocomplete zsh"
 slug: rclone_genautocomplete_zsh
 url: /commands/rclone_genautocomplete_zsh/

docs/content/commands/rclone_gendocs.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone gendocs"
 slug: rclone_gendocs
 url: /commands/rclone_gendocs/

docs/content/commands/rclone_hashsum.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone hashsum"
 slug: rclone_hashsum
 url: /commands/rclone_hashsum/

docs/content/commands/rclone_link.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone link"
 slug: rclone_link
 url: /commands/rclone_link/

docs/content/commands/rclone_listremotes.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone listremotes"
 slug: rclone_listremotes
 url: /commands/rclone_listremotes/

docs/content/commands/rclone_ls.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone ls"
 slug: rclone_ls
 url: /commands/rclone_ls/

docs/content/commands/rclone_lsd.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone lsd"
 slug: rclone_lsd
 url: /commands/rclone_lsd/

docs/content/commands/rclone_lsf.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone lsf"
 slug: rclone_lsf
 url: /commands/rclone_lsf/

docs/content/commands/rclone_lsjson.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone lsjson"
 slug: rclone_lsjson
 url: /commands/rclone_lsjson/

docs/content/commands/rclone_lsl.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone lsl"
 slug: rclone_lsl
 url: /commands/rclone_lsl/

docs/content/commands/rclone_md5sum.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone md5sum"
 slug: rclone_md5sum
 url: /commands/rclone_md5sum/

docs/content/commands/rclone_mkdir.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone mkdir"
 slug: rclone_mkdir
 url: /commands/rclone_mkdir/

docs/content/commands/rclone_mount.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone mount"
 slug: rclone_mount
 url: /commands/rclone_mount/

docs/content/commands/rclone_move.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone move"
 slug: rclone_move
 url: /commands/rclone_move/

docs/content/commands/rclone_moveto.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone moveto"
 slug: rclone_moveto
 url: /commands/rclone_moveto/

docs/content/commands/rclone_ncdu.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone ncdu"
 slug: rclone_ncdu
 url: /commands/rclone_ncdu/

docs/content/commands/rclone_obscure.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone obscure"
 slug: rclone_obscure
 url: /commands/rclone_obscure/

docs/content/commands/rclone_purge.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone purge"
 slug: rclone_purge
 url: /commands/rclone_purge/

docs/content/commands/rclone_rc.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone rc"
 slug: rclone_rc
 url: /commands/rclone_rc/

docs/content/commands/rclone_rcat.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone rcat"
 slug: rclone_rcat
 url: /commands/rclone_rcat/

docs/content/commands/rclone_rcd.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone rcd"
 slug: rclone_rcd
 url: /commands/rclone_rcd/

docs/content/commands/rclone_rmdir.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone rmdir"
 slug: rclone_rmdir
 url: /commands/rclone_rmdir/

docs/content/commands/rclone_rmdirs.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone rmdirs"
 slug: rclone_rmdirs
 url: /commands/rclone_rmdirs/

docs/content/commands/rclone_serve.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve"
 slug: rclone_serve
 url: /commands/rclone_serve/

docs/content/commands/rclone_serve_dlna.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve dlna"
 slug: rclone_serve_dlna
 url: /commands/rclone_serve_dlna/

docs/content/commands/rclone_serve_ftp.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve ftp"
 slug: rclone_serve_ftp
 url: /commands/rclone_serve_ftp/

docs/content/commands/rclone_serve_http.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve http"
 slug: rclone_serve_http
 url: /commands/rclone_serve_http/

docs/content/commands/rclone_serve_restic.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve restic"
 slug: rclone_serve_restic
 url: /commands/rclone_serve_restic/

docs/content/commands/rclone_serve_sftp.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve sftp"
 slug: rclone_serve_sftp
 url: /commands/rclone_serve_sftp/

docs/content/commands/rclone_serve_webdav.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone serve webdav"
 slug: rclone_serve_webdav
 url: /commands/rclone_serve_webdav/

docs/content/commands/rclone_settier.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone settier"
 slug: rclone_settier
 url: /commands/rclone_settier/

docs/content/commands/rclone_sha1sum.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone sha1sum"
 slug: rclone_sha1sum
 url: /commands/rclone_sha1sum/

docs/content/commands/rclone_size.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone size"
 slug: rclone_size
 url: /commands/rclone_size/

docs/content/commands/rclone_sync.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone sync"
 slug: rclone_sync
 url: /commands/rclone_sync/

docs/content/commands/rclone_touch.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone touch"
 slug: rclone_touch
 url: /commands/rclone_touch/

docs/content/commands/rclone_tree.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone tree"
 slug: rclone_tree
 url: /commands/rclone_tree/

docs/content/commands/rclone_version.md

@@ -1,5 +1,5 @@
 ---
-date: 2019-08-26T15:19:45+01:00
+date: 2019-08-28T17:50:40+01:00
 title: "rclone version"
 slug: rclone_version
 url: /commands/rclone_version/

docs/content/flags.md

@@ -1,7 +1,7 @@
 ---
 title: "Global Flags"
 description: "Rclone Global Flags"
-date: "2019-08-26T15:19:45+01:00"
+date: "2019-08-28T17:50:40+01:00"
 ---
 
 # Global Flags
@@ -127,7 +127,7 @@ These flags are available for every command.
       --use-json-log                         Use json log format.
       --use-mmap                             Use mmap allocator (see docs).
       --use-server-modtime                   Use server modified time instead of object metadata
-      --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default "rclone/v1.49.0")
+      --user-agent string                    Set the user-agent to a specified string. The default is rclone/ version (default "rclone/v1.49.1")
   -v, --verbose count                        Print lots more stuff (repeat for more)
 ```
 

docs/layouts/partials/version.html

@@ -1 +1 @@
-v1.49.0
+v1.49.1

fs/config/config.go

@@ -89,6 +89,9 @@ var (
 	// For security reasons, the temp file is deleted once the configKey is successfully loaded.
 	// This can be used to pass the configKey to a child process.
 	PassConfigKeyForDaemonization = false
+
+	// Password can be used to configure the random password generator
+	Password = random.Password
 )
 
 func init() {
@@ -854,6 +857,7 @@ func ChooseOption(o *fs.Option, name string) string {
 			actions = append(actions, "nNo leave this optional password blank")
 		}
 		var password string
+		var err error
 		switch i := Command(actions); i {
 		case 'y':
 			password = ChangePassword("the")
@@ -861,7 +865,7 @@ func ChooseOption(o *fs.Option, name string) string {
 			for {
 				fmt.Printf("Password strength in bits.\n64 is just about memorable\n128 is secure\n1024 is the maximum\n")
 				bits := ChooseNumber("Bits", 64, 1024)
-				password, err := random.Password(bits)
+				password, err = Password(bits)
 				if err != nil {
 					log.Fatalf("Failed to make password: %v", err)
 				}

fs/config/config_test.go

@@ -30,6 +30,7 @@ func testConfigFile(t *testing.T, configFileName string) func() {
 	oldConfig := fs.Config
 	oldConfigFile := configFile
 	oldReadLine := ReadLine
+	oldPassword := Password
 	os.Stdout = nil
 	ConfigPath = path
 	fs.Config = &fs.ConfigInfo{}
@@ -63,6 +64,7 @@ func testConfigFile(t *testing.T, configFileName string) func() {
 		os.Stdout = oldOsStdout
 		ConfigPath = oldConfigPath
 		ReadLine = oldReadLine
+		Password = oldPassword
 		fs.Config = oldConfig
 		configFile = oldConfigFile
 
@@ -71,24 +73,28 @@ func testConfigFile(t *testing.T, configFileName string) func() {
 	}
 }
 
-func TestCRUD(t *testing.T) {
-	defer testConfigFile(t, "crud.conf")()
-
-	// expect script for creating remote
+// makeReadLine makes a simple readLine which returns a fixed list of
+// strings
+func makeReadLine(answers []string) func() string {
 	i := 0
-	ReadLine = func() string {
-		answers := []string{
-			"config_test_remote", // type
-			"true",               // bool value
-			"y",                  // type my own password
-			"secret",             // password
-			"secret",             // repeat
-			"y",                  // looks good, save
-		}
+	return func() string {
 		i = i + 1
 		return answers[i-1]
 	}
+}
 
+func TestCRUD(t *testing.T) {
+	defer testConfigFile(t, "crud.conf")()
+
+	// script for creating remote
+	ReadLine = makeReadLine([]string{
+		"config_test_remote", // type
+		"true",               // bool value
+		"y",                  // type my own password
+		"secret",             // password
+		"secret",             // repeat
+		"y",                  // looks good, save
+	})
 	NewRemote("test")
 
 	assert.Equal(t, []string{"test"}, configFile.GetSectionList())
@@ -97,7 +103,11 @@ func TestCRUD(t *testing.T) {
 	assert.Equal(t, "secret", obscure.MustReveal(FileGet("test", "pass")))
 
 	// normal rename, test → asdf
-	ReadLine = func() string { return "asdf" }
+	ReadLine = makeReadLine([]string{
+		"asdf",
+		"asdf",
+		"asdf",
+	})
 	RenameRemote("test")
 
 	assert.Equal(t, []string{"asdf"}, configFile.GetSectionList())
@@ -118,6 +128,41 @@ func TestCRUD(t *testing.T) {
 	assert.Equal(t, []string{}, configFile.GetSectionList())
 }
 
+func TestChooseOption(t *testing.T) {
+	defer testConfigFile(t, "crud.conf")()
+
+	// script for creating remote
+	ReadLine = makeReadLine([]string{
+		"config_test_remote", // type
+		"false",              // bool value
+		"x",                  // bad choice
+		"g",                  // generate password
+		"1024",               // very big
+		"y",                  // password OK
+		"y",                  // looks good, save
+	})
+	Password = func(bits int) (string, error) {
+		assert.Equal(t, 1024, bits)
+		return "not very random password", nil
+	}
+	NewRemote("test")
+
+	assert.Equal(t, "false", FileGet("test", "bool"))
+	assert.Equal(t, "not very random password", obscure.MustReveal(FileGet("test", "pass")))
+
+	// script for creating remote
+	ReadLine = makeReadLine([]string{
+		"config_test_remote", // type
+		"true",               // bool value
+		"n",                  // not required
+		"y",                  // looks good, save
+	})
+	NewRemote("test")
+
+	assert.Equal(t, "true", FileGet("test", "bool"))
+	assert.Equal(t, "", FileGet("test", "pass"))
+}
+
 func TestCreateUpatePasswordRemote(t *testing.T) {
 	defer testConfigFile(t, "update.conf")()
 

fs/version.go

@@ -1,4 +1,4 @@
 package fs
 
 // Version of rclone
-var Version = "v1.49.0"
+var Version = "v1.49.1"

lib/rest/rest.go

@@ -46,7 +46,7 @@ func ReadBody(resp *http.Response) (result []byte, err error) {
 }
 
 // defaultErrorHandler doesn't attempt to parse the http body, just
-// returns it in the error message
+// returns it in the error message closing resp.Body
 func defaultErrorHandler(resp *http.Response) (err error) {
 	body, err := ReadBody(resp)
 	if err != nil {
@@ -178,9 +178,11 @@ func ClientWithNoRedirects(c *http.Client) *http.Client {
 
 // Call makes the call and returns the http.Response
 //
-// if err != nil then resp.Body will need to be closed unless
+// if err == nil then resp.Body will need to be closed unless
 // opt.NoResponse is set
 //
+// if err != nil then resp.Body will have been closed
+//
 // it will return resp if at all possible, even if err is set
 func (api *Client) Call(opts *Opts) (resp *http.Response, err error) {
 	api.mu.RLock()

rclone.1

@@ -1,7 +1,7 @@
 .\"t
 .\" Automatically generated by Pandoc 2.2.1
 .\"
-.TH "rclone" "1" "Aug 26, 2019" "User Manual" ""
+.TH "rclone" "1" "Aug 28, 2019" "User Manual" ""
 .hy
 .SH Rclone \- rsync for cloud storage
 .PP
@@ -10462,7 +10462,7 @@ These flags are available for every command.
 \ \ \ \ \ \ \-\-use\-json\-log\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Use\ json\ log\ format.
 \ \ \ \ \ \ \-\-use\-mmap\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Use\ mmap\ allocator\ (see\ docs).
 \ \ \ \ \ \ \-\-use\-server\-modtime\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Use\ server\ modified\ time\ instead\ of\ object\ metadata
-\ \ \ \ \ \ \-\-user\-agent\ string\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Set\ the\ user\-agent\ to\ a\ specified\ string.\ The\ default\ is\ rclone/\ version\ (default\ "rclone/v1.49.0")
+\ \ \ \ \ \ \-\-user\-agent\ string\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Set\ the\ user\-agent\ to\ a\ specified\ string.\ The\ default\ is\ rclone/\ version\ (default\ "rclone/v1.49.1")
 \ \ \-v,\ \-\-verbose\ count\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Print\ lots\ more\ stuff\ (repeat\ for\ more)
 \f[]
 .fi
@@ -23648,6 +23648,31 @@ Type: bool
 .IP \[bu] 2
 Default: false
 .SH Changelog
+.SS v1.49.1 \- 2019\-08\-28
+.PP
+Point release to fix config bug and google photos backend.
+.IP \[bu] 2
+Bug Fixes
+.RS 2
+.IP \[bu] 2
+config: Fix generated passwords being stored as empty password (Nick
+Craig\-Wood)
+.IP \[bu] 2
+rcd: Added missing parameter for web\-gui info logs.
+(Chaitanya)
+.RE
+.IP \[bu] 2
+Googlephotos
+.RS 2
+.IP \[bu] 2
+Fix crash on error response (Nick Craig\-Wood)
+.RE
+.IP \[bu] 2
+Onedrive
+.RS 2
+.IP \[bu] 2
+Fix crash on error response (Nick Craig\-Wood)
+.RE
 .SS v1.49.0 \- 2019\-08\-26
 .IP \[bu] 2
 New backends
@@ -23673,12 +23698,19 @@ Implement \f[C]\-\-compare\-dest\f[] & \f[C]\-\-copy\-dest\f[]
 Implement \f[C]\-\-suffix\f[] without \f[C]\-\-backup\-dir\f[] for
 backup to current dir (yparitcher)
 .IP \[bu] 2
-Add \f[C]\-\-use\-json\-log\f[] for JSON logging (justinalin)
-.IP \[bu] 2
-Add \f[C]config\ reconnect\f[], \f[C]config\ userinfo\f[] and
-\f[C]config\ disconnect\f[] subcommands.
+\f[C]config\ reconnect\f[] to re\-login (re\-run the oauth login) for
+the backend.
 (Nick Craig\-Wood)
 .IP \[bu] 2
+\f[C]config\ userinfo\f[] to discover which user you are logged in as.
+(Nick Craig\-Wood)
+.IP \[bu] 2
+\f[C]config\ disconnect\f[] to disconnect you (log out) from the
+backend.
+(Nick Craig\-Wood)
+.IP \[bu] 2
+Add \f[C]\-\-use\-json\-log\f[] for JSON logging (justinalin)
+.IP \[bu] 2
 Add context propagation to rclone (Aleksandar Jankovic)
 .IP \[bu] 2
 Reworking internal statistics interfaces so they work with rc jobs