Simplify exception logging

This commit is contained in:
Sebastian Goscik
2023-02-25 18:13:40 +00:00
parent 900d0d2881
commit 73022fddf1
5 changed files with 8 additions and 14 deletions

View File

@@ -109,8 +109,7 @@ class VideoDownloader:
self.current_event = None self.current_event = None
except Exception as e: except Exception as e:
self.logger.warn(f"Unexpected exception occurred, abandoning event {event.id}:") self.logger.warn(f"Unexpected exception occurred, abandoning event {event.id}:", exc_info=e)
self.logger.exception(e)
async def _download(self, event: Event) -> bytes: async def _download(self, event: Event) -> bytes:
"""Downloads the video clip for the given event""" """Downloads the video clip for the given event"""
@@ -121,8 +120,7 @@ class VideoDownloader:
assert isinstance(video, bytes) assert isinstance(video, bytes)
break break
except (AssertionError, ClientPayloadError, TimeoutError) as e: except (AssertionError, ClientPayloadError, TimeoutError) as e:
self.logger.warn(f" Failed download attempt {x+1}, retying in 1s") self.logger.warn(f" Failed download attempt {x+1}, retying in 1s", exc_info=e)
self.logger.exception(e)
await asyncio.sleep(1) await asyncio.sleep(1)
else: else:
self.logger.warn(f"Download failed after 5 attempts, abandoning event {event.id}:") self.logger.warn(f"Download failed after 5 attempts, abandoning event {event.id}:")

View File

@@ -111,8 +111,7 @@ class EventListener:
else: else:
logger.warn("Unable to establish connection to Unifi Protect") logger.warn("Unable to establish connection to Unifi Protect")
except Exception as e: except Exception as e:
logger.warn("Unexpected exception occurred while trying to reconnect:") logger.warn("Unexpected exception occurred while trying to reconnect:", exc_info=e)
logger.exception(e)
# Back off for a little while # Back off for a little while
await asyncio.sleep(10) await asyncio.sleep(10)

View File

@@ -112,7 +112,6 @@ class MissingEventChecker:
await self._download_queue.put(event) await self._download_queue.put(event)
except Exception as e: except Exception as e:
logger.warn(f"Unexpected exception occurred during missing event check:") logger.warn(f"Unexpected exception occurred during missing event check:", exc_info=e)
logger.exception(e)
await asyncio.sleep(self.interval) await asyncio.sleep(self.interval)

View File

@@ -69,8 +69,7 @@ class Purge:
await tidy_empty_dirs(self.rclone_destination) await tidy_empty_dirs(self.rclone_destination)
except Exception as e: except Exception as e:
logger.warn(f"Unexpected exception occurred during purge:") logger.warn(f"Unexpected exception occurred during purge:", exc_info=e)
logger.exception(e)
next_purge_time = datetime.now() + self.interval next_purge_time = datetime.now() + self.interval
logger.extra_debug(f'sleeping until {next_purge_time}') logger.extra_debug(f'sleeping until {next_purge_time}')

View File

@@ -67,8 +67,7 @@ class VideoUploader:
self.current_event = None self.current_event = None
except Exception as e: except Exception as e:
self.logger.warn(f"Unexpected exception occurred, abandoning event {event.id}:") self.logger.warn(f"Unexpected exception occurred, abandoning event {event.id}:", exc_info=e)
self.logger.exception(e)
async def _upload_video(self, video: bytes, destination: pathlib.Path, rclone_args: str): async def _upload_video(self, video: bytes, destination: pathlib.Path, rclone_args: str):
"""Upload video using rclone. """Upload video using rclone.