bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-03 02:03:53 +00:00
Code Issues Releases Wiki Activity

improve assign tasks view display

Browse Source 
- Remove illustration/preview section (mailbox icon and prompt text)
- Show unique member count instead of calculated task count
- Use reportSummary.totalCriticalAtRiskMemberCount from AllActivitiesService
- Remove unused SecurityTasksApiService dependency
- Follow same pattern as all-activity.component.ts for consistency
This commit is contained in:
Alex
2025-10-30 11:02:43 -04:00
parent ed283f15bd
commit 08df1ea44e
2 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/assign-tasks-view.component.html
View File

@@ -16,7 +16,7 @@
</div>
<div class="tw-flex tw-items-baseline tw-gap-2">
<span bitTypography="h3">{{ totalTasksToAssign }}</span>
<span bitTypography="h3">{{ criticalAppsAtRiskMemberCount }}</span>
<span bitTypography="body2" class="tw-text-muted">
{{ "membersWithAtRiskPasswords" | i18n }}
</span>

34
bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/assign-tasks-view.component.ts
View File

@@ -2,10 +2,7 @@ import { CommonModule } from "@angular/common";
import { Component, OnInit, inject, input, output } from "@angular/core";
import { firstValueFrom } from "rxjs";
import {
AllActivitiesService,
SecurityTasksApiService,
} from "@bitwarden/bit-common/dirt/reports/risk-insights";
import { AllActivitiesService } from "@bitwarden/bit-common/dirt/reports/risk-insights";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { LogService } from "@bitwarden/common/platform/abstractions/log.service";
import { OrganizationId } from "@bitwarden/common/types/guid";
@@ -55,39 +52,32 @@ export class AssignTasksViewComponent implements OnInit {
*/
readonly back = output<void>();
protected totalTasksToAssign = 0;
protected criticalAppsAtRiskMemberCount = 0;
protected isAssigning = false;
private allActivitiesService = inject(AllActivitiesService);
private securityTasksApiService = inject(SecurityTasksApiService);
private accessIntelligenceSecurityTasksService = inject(AccessIntelligenceSecurityTasksService);
private toastService = inject(ToastService);
private i18nService = inject(I18nService);
private logService = inject(LogService);
async ngOnInit(): Promise<void> {
// Calculate tasks to assign using organizationId passed from parent
await this.calculateTasksToAssign();
// Get unique members with at-risk passwords from report summary
// Uses the same pattern as all-activity.component.ts
await this.loadAtRiskMemberCount();
}
/**
* Calculates the number of tasks that will be assigned.
* Uses the same logic as password-change-metric.component.ts
* Loads the count of unique members with at-risk passwords.
* Uses the same pattern as all-activity.component.ts
*/
private async calculateTasksToAssign(): Promise<void> {
private async loadAtRiskMemberCount(): Promise<void> {
try {
const taskMetrics = await firstValueFrom(
this.securityTasksApiService.getTaskMetrics(this.organizationId()),
);
const atRiskPasswordsCount = await firstValueFrom(
this.allActivitiesService.atRiskPasswordsCount$,
);
const newTasksCount = atRiskPasswordsCount - taskMetrics.totalTasks;
this.totalTasksToAssign = newTasksCount > 0 ? newTasksCount : 0;
const summary = await firstValueFrom(this.allActivitiesService.reportSummary$);
this.criticalAppsAtRiskMemberCount = summary.totalCriticalAtRiskMemberCount;
} catch (error) {
this.logService.error("[AssignTasksView] Failed to calculate tasks", error);
this.totalTasksToAssign = 0;
this.logService.error("[AssignTasksView] Failed to load at-risk member count", error);
this.criticalAppsAtRiskMemberCount = 0;
}
}