bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 14:04:03 +00:00
Code Issues Releases Wiki Activity

validator filter tests

Browse Source
This commit is contained in:
✨ Audrey ✨
2025-03-12 14:06:21 -04:00
parent 8cd0173103
commit 27c5f0b543
1 changed files with 34 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
libs/common/src/tools/achievements/event-processor.spec.ts
View File

@@ -1,8 +1,8 @@
import { BehaviorSubject, ReplaySubject, bufferCount, firstValueFrom } from "rxjs";
import { BehaviorSubject, ReplaySubject, bufferCount, concat, first, firstValueFrom } from "rxjs";
import { validate } from "./event-processor";
import { ItemCreatedProgressEvent } from "./example-achievements";
import { itemAdded$ } from "./example-events";
import { itemAdded$, itemUpdated$ } from "./example-events";
import {
ItemCreatedAchievement,
ItemCreatedProgress,
@@ -54,8 +54,8 @@ describe("event-processor", () => {
it("tracks achievement progress and earns an achievement", async () => {
const validators$ = new BehaviorSubject([ItemCreatedValidator]);
const captured$ = new BehaviorSubject<AchievementEvent[]>([]);
const achievements$ = new ReplaySubject<AchievementEvent>(2);
const result = firstValueFrom(achievements$.pipe(bufferCount(2)));
const achievements$ = new ReplaySubject<AchievementEvent>(3);
const result = firstValueFrom(achievements$.pipe(bufferCount(3)));
itemAdded$.pipe(validate(validators$, captured$)).subscribe(achievements$);
@@ -67,5 +67,35 @@ describe("event-processor", () => {
];
await expect(result).resolves.toMatchObject(expected);
});
it("skips records that fail the validator's filter criteria", async () => {
const validators$ = new BehaviorSubject([ItemCreatedTracker]);
const captured$ = new BehaviorSubject<AchievementEvent[]>([]);
const achievements$ = new ReplaySubject<AchievementEvent>(2);
const result = firstValueFrom(achievements$.pipe(bufferCount(2)));
// `ItemCreatedTracker` filters out update events
concat(itemUpdated$, itemAdded$)
.pipe(validate(validators$, captured$))
.subscribe(achievements$);
const expected = [{ achievement: { type: "progress", name: ItemCreatedProgress, value: 1 } }];
await expect(result).resolves.toMatchObject(expected);
});
it("only emits when its validators return events", async () => {
const validators$ = new BehaviorSubject([ItemCreatedTracker]);
const captured$ = new BehaviorSubject<AchievementEvent[]>([]);
const achievements$ = new BehaviorSubject<AchievementEvent | null | undefined>(undefined);
// `ItemCreatedTracker` filters `itemUpdated$` emissions. There are no others
// to process. When `itemUpdated$` completes, `first()` emits `null`, which
// replaces the `undefined` value in `achievements$`.
concat(itemUpdated$)
.pipe(validate(validators$, captured$), first(null, null))
.subscribe(achievements$);
await expect(achievements$.value).toBeNull();
});
});
});