bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-07 04:03:29 +00:00
Code Issues Releases Wiki Activity

Fix inconsistent comment phrasing in isOrganizationReportSummary

Browse Source 
Update the comment for the newApplications field validation to accurately
reflect that the field IS in the type definition (as optional), but is
optional due to legacy encrypted data.

Changed from: "not in type definition"
Changed to: "legacy encrypted data predates this field"

This aligns with the explanation used elsewhere in the codebase and
accurately describes why the field must remain optional.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Claude
2025-10-30 05:31:08 +00:00
parent 13d4fd98c8
commit 306cdd5f53
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-type-guards.ts
View File

@@ -230,7 +230,7 @@ export function isOrganizationReportSummary(obj: any): obj is OrganizationReport
Number.isSafeInteger(obj.totalCriticalAtRiskApplicationCount) &&
obj.totalCriticalAtRiskApplicationCount >= 0 &&
obj.totalCriticalAtRiskApplicationCount <= MAX_COUNT &&
// newApplications is optional (backward compatibility - not in type definition)
// newApplications is optional (backward compatibility - legacy encrypted data predates this field)
(obj.newApplications === undefined ||
(Array.isArray(obj.newApplications) &&
obj.newApplications.length <= MAX_ARRAY_LENGTH &&