1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-07 04:03:29 +00:00

refactor openPopup vault message to OpenAtRiskPasswords

This commit is contained in:
Nick Krantz
2025-03-28 11:18:00 -05:00
parent 7ed2145393
commit 35efd42c7c
4 changed files with 8 additions and 6 deletions

View File

@@ -17,7 +17,7 @@ const windowMessageHandlers: ContentMessageWindowEventHandlers = {
[VaultMessages.checkBwInstalled]: () => handleExtensionInstallCheck(),
duoResult: ({ data, referrer }: { data: any; referrer: string }) =>
handleDuoResultMessage(data, referrer),
[VaultMessages.OpenPopup]: () => handleOpenPopupMessage(),
[VaultMessages.OpenAtRiskPasswords]: () => handleOpenAtRiskPasswordsMessage(),
};
/**
@@ -73,8 +73,8 @@ function handleWebAuthnResultMessage(data: ContentMessageWindowData, referrer: s
sendExtensionRuntimeMessage({ command, data: data.data, remember, referrer });
}
function handleOpenPopupMessage() {
sendExtensionRuntimeMessage({ command: VaultMessages.OpenPopup });
function handleOpenAtRiskPasswordsMessage() {
sendExtensionRuntimeMessage({ command: VaultMessages.OpenAtRiskPasswords });
}
/**

View File

@@ -68,7 +68,9 @@ describe("BrowserExtensionPromptService", () => {
);
expect(window.postMessage).toHaveBeenCalledTimes(2);
expect(window.postMessage).toHaveBeenCalledWith({ command: VaultMessages.OpenPopup });
expect(window.postMessage).toHaveBeenCalledWith({
command: VaultMessages.OpenAtRiskPasswords,
});
});
});

View File

@@ -55,7 +55,7 @@ export class BrowserExtensionPromptService {
/** Post a message to the extension to open */
openExtension() {
window.postMessage({ command: VaultMessages.OpenPopup });
window.postMessage({ command: VaultMessages.OpenAtRiskPasswords });
}
/** Send message checking for the browser extension */

View File

@@ -1,7 +1,7 @@
const VaultMessages = {
HasBwInstalled: "hasBwInstalled",
checkBwInstalled: "checkIfBWExtensionInstalled",
OpenPopup: "openPopup",
OpenAtRiskPasswords: "openAtRiskPasswords",
PopupOpened: "popupOpened",
} as const;