bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-19 10:54:00 +00:00
Code Issues Releases Wiki Activity

fix(notification-processing): [PM-19877] System Notification Implementation - Renamed noop server notifications service.

Browse Source
This commit is contained in:
Patrick Pimentel
2025-07-23 15:56:34 -04:00
parent 2ca7383114
commit 43ce345f8a
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/angular/src/services/jslib-services.module.ts
View File

@@ -211,7 +211,7 @@ import { ServerNotificationsService } from "@bitwarden/common/platform/notificat
// eslint-disable-next-line no-restricted-imports -- Needed for service creation
import {
DefaultServerNotificationsService,
NoopNotificationsService,
UnsupportedServerNotificationsService,
SignalRConnectionService,
UnsupportedWebPushConnectionService,
WebPushConnectionService,
@@ -954,7 +954,7 @@ const safeProviders: SafeProvider[] = [
safeProvider({
provide: ServerNotificationsService,
useClass: devFlagEnabled("noopNotifications")
? NoopNotificationsService
? UnsupportedServerNotificationsService
: DefaultServerNotificationsService,
deps: [
LogService,

2
libs/common/src/platform/notifications/internal/index.ts
View File

@@ -1,7 +1,7 @@
export * from "./worker-webpush-connection.service";
export * from "./signalr-connection.service";
export * from "./default-server-notifications.service";
export * from "./noop-notifications.service";
export * from "./unsupported-server-notifications.service";
export * from "./unsupported-webpush-connection.service";
export * from "./webpush-connection.service";
export * from "./websocket-webpush-connection.service";

2
libs/common/src/platform/notifications/internal/noop-notifications.service.ts → libs/common/src/platform/notifications/internal/unsupported-server-notifications.service.ts
View File

@@ -6,7 +6,7 @@ import { UserId } from "@bitwarden/common/types/guid";
import { LogService } from "../../abstractions/log.service";
import { ServerNotificationsService } from "../server-notifications-service";
export class NoopNotificationsService implements ServerNotificationsService {
export class UnsupportedServerNotificationsService implements ServerNotificationsService {
notifications$: Observable<readonly [NotificationResponse, UserId]> = new Subject();
constructor(private logService: LogService) {}