bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 22:13:32 +00:00
Code Issues Releases Wiki Activity

select module improvements

Browse Source
This commit is contained in:
Vicki League
2025-06-25 16:54:56 -04:00
parent 2697d87d36
commit 44bd72b4df
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libs/components/src/select/option.component.ts
View File

@@ -9,11 +9,11 @@ import { MappedOptionComponent } from "./option";
template: `<ng-template><ng-content></ng-content></ng-template>`,
})
export class OptionComponent<T = unknown> implements MappedOptionComponent<T> {
icon = input<string>();
readonly icon = input<string>();
value = input.required<T>();
readonly value = input.required<T>();
label = input.required<string>();
readonly label = input.required<string>();
disabled = input(undefined, { transform: booleanAttribute });
readonly disabled = input(undefined, { transform: booleanAttribute });
}

10
libs/components/src/select/select.component.ts
View File

@@ -42,14 +42,14 @@ let nextId = 0;
providers: [{ provide: BitFormFieldControl, useExisting: SelectComponent }],
imports: [NgSelectModule, ReactiveFormsModule, FormsModule],
host: {
"[id]": "this.id()",
"[id]": "id()",
},
})
export class SelectComponent<T> implements BitFormFieldControl, ControlValueAccessor {
@ViewChild(NgSelectComponent) select: NgSelectComponent;
/** Optional: Options can be provided using an array input or using `bit-option` */
items = model<Option<T>[]>();
items = model<Option<T>[] | undefined>();
readonly placeholder = input(this.i18nService.t("selectPlaceholder"));
@Output() closed = new EventEmitter();
@@ -162,7 +162,7 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce
}
/**Implemented as part of BitFormFieldControl */
id = input(`bit-multi-select-${nextId++}`);
readonly id = input(`bit-multi-select-${nextId++}`);
/**Implemented as part of BitFormFieldControl */
// TODO: Skipped for migration because:
@@ -188,8 +188,8 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce
return [key, this.ngControl?.errors[key]];
}
private findSelectedOption(items: Option<T>[], value: T): Option<T> | undefined {
return items.find((item) => item.value === value);
private findSelectedOption(items: Option<T>[] | undefined, value: T): Option<T> | undefined {
return items?.find((item) => item.value === value);
}
/**Emits the closed event. */