bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-10 05:30:01 +00:00
Code Issues Releases Wiki Activity

fix missing argument

Browse Source
This commit is contained in:
✨ Audrey ✨
2025-03-11 18:33:16 -04:00
parent 9a9e72f483
commit 49033aea9b
3 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libs/common/src/tools/achievements/event-processor.spec.ts Normal file
View File

@@ -0,0 +1,9 @@
describe("event-processor", () => {
describe("active", () => {
it("", () => {});
});
describe("validate", () => {
it("", () => {});
});
});

8
libs/common/src/tools/achievements/event-processor.ts
View File

@@ -76,15 +76,15 @@ function validate(
for (const monitor of monitors) {
const progress = mapProgressByName(status);
const measurements = monitor.measure(action, progress);
results.push(...measurements);
const measured = monitor.measure(action, progress);
results.push(...measured);
// modify copy produced by filter to avoid reallocation
for (const m of measurements) {
for (const m of measured) {
progress.set(m.achievement.name, m.achievement.value);
}
results.push(...monitor.earn(progress));
results.push(...monitor.earn(measured, progress));
}
// deliver results as a stream containing individual records to maintain

4
libs/common/src/tools/achievements/example-validators.ts
View File

@@ -38,7 +38,7 @@ const ThreeItemsCreatedValidator = {
const value = 1 + (progress.get(ItemCreatedProgress) ?? 0);
return [progressEvent(ItemCreatedProgress, value)];
},
earn(progress) {
earn(_measured, progress) {
const value = progress.get(ItemCreatedProgress) ?? 0;
return value >= 3 ? [earnedEvent(ItemCreatedAchievement)] : [];
},
@@ -57,7 +57,7 @@ const FiveItemsCreatedValidator = {
const value = 1 + (progress.get(ItemCreatedProgress) ?? 0);
return [progressEvent(ItemCreatedProgress, value)];
},
earn(progress) {
earn(_measured, progress) {
const value = progress.get(ItemCreatedProgress) ?? 0;
return value >= 5 ? [earnedEvent(ItemCreatedAchievement)] : [];
},