[PM-31429] Add missing helper text for password protected Sends, remove unused one (#18694)

* [PM-31429] Add missing helper text for password protected Sends, remove unused one

* Put one UI change behind feature flag, add back required translations

* Reorder translation

* Add spaces

* Come full circle, remove last couple of committed changes

apps/browser/src/_locales/en/messages.json

@@ -3035,10 +3035,6 @@
   "custom": {
     "message": "Custom"
   },
-  "sendPasswordDescV3": {
-    "message": "Add an optional password for recipients to access this Send.",
-    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
-  },
   "createSend": {
     "message": "New Send",
     "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
@@ -6144,5 +6140,9 @@
   },
   "emailPlaceholder": {
     "message": "user@bitwarden.com , user@acme.com"
+  },
+  "sendPasswordHelperText": {
+    "message": "Individuals will need to enter the password to view this Send",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
   }
 }

apps/desktop/src/locales/en/messages.json

@@ -137,10 +137,6 @@
      "message": "Send details",
      "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
    },
-   "sendPasswordDescV3": {
-     "message": "Add an optional password for recipients to access this Send.",
-     "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
-   },
    "sendTypeTextToShare": {
      "message": "Text to share"
    },
@@ -4587,5 +4583,9 @@
   },
   "whyAmISeeingThis": {
     "message": "Why am I seeing this?"
+  },
+  "sendPasswordHelperText": {
+    "message": "Individuals will need to enter the password to view this Send",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
   }
 }

apps/web/src/locales/en/messages.json

@@ -5645,10 +5645,6 @@
   "sendTypeText": {
     "message": "Text"
   },
-  "sendPasswordDescV3": {
-    "message": "Add an optional password for recipients to access this Send.",
-    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
-  },
   "createSend": {
     "message": "New Send",
     "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
@@ -12783,6 +12779,10 @@
   "invalidSendPassword": {
     "message": "Invalid Send password"
   },
+  "sendPasswordHelperText": {
+    "message": "Individuals will need to enter the password to view this Send",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },
   "perUser": {
     "message": "per user"
   }

libs/tools/send/send-ui/src/send-form/components/send-details/send-details.component.html

@@ -61,6 +61,9 @@
       @if (sendDetailsForm.get("authType").value === AuthType.Email) {
         <bit-hint class="tw-mt-2">{{ "emailVerificationDesc" | i18n }}</bit-hint>
       }
+      @if (sendDetailsForm.get("authType").value === AuthType.Password) {
+        <bit-hint class="tw-mt-2">{{ "sendPasswordHelperText" | i18n }}</bit-hint>
+      }
     </bit-form-field>
 
     @if (sendDetailsForm.get("authType").value === AuthType.Password) {
@@ -108,7 +111,6 @@
             ></button>
           }
         </div>
-        <bit-hint>{{ "sendPasswordDescV3" | i18n }}</bit-hint>
       </bit-form-field>
     }