bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-10 13:40:06 +00:00
Code Issues Releases Wiki Activity

Fix bug causing race condition due to not consuming / awaiting observable.

Browse Source
This commit is contained in:
Nik Gilmore
2026-01-07 17:17:01 -08:00
parent 3563c881fa
commit 5a6e51442d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/common/src/vault/services/cipher.service.ts
View File

@@ -910,9 +910,9 @@ export class CipherService implements CipherServiceAbstraction {
userId: UserId,
orgAdmin?: boolean,
): Promise<CipherView | void> {
const resultCipherView = firstValueFrom(
const resultCipherView = await firstValueFrom(
this.sdkService.userClient$(userId).pipe(
map(async (sdk) => {
switchMap(async (sdk) => {
if (!sdk) {
throw new Error("SDK not available");
}
@@ -927,7 +927,7 @@ export class CipherService implements CipherServiceAbstraction {
return CipherView.fromSdkCipherView(result);
}),
catchError((error: unknown) => {
this.logService.error(`Failed to encrypt cipher: ${error}`);
this.logService.error(`Failed to create cipher: ${error}`);
return EMPTY;
}),
),
@@ -988,9 +988,9 @@ export class CipherService implements CipherServiceAbstraction {
originalCipherView?: CipherView,
orgAdmin?: boolean,
): Promise<CipherView> {
const resultCipherView = firstValueFrom(
const resultCipherView = await firstValueFrom(
this.sdkService.userClient$(userId).pipe(
map(async (sdk) => {
switchMap(async (sdk) => {
if (!sdk) {
throw new Error("SDK not available");
}
@@ -1009,7 +1009,7 @@ export class CipherService implements CipherServiceAbstraction {
return CipherView.fromSdkCipherView(result);
}),
catchError((error: unknown) => {
this.logService.error(`Failed to encrypt cipher: ${error}`);
this.logService.error(`Failed to update cipher: ${error}`);
return EMPTY;
}),
),