bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-18 18:33:50 +00:00
Code Issues Releases Wiki Activity

[PM-29512] Remove ts strict ignore in popup fido 2 cipher row component ts (#18064)

Browse Source 
* last is dead code, remove completely

* pass required true so that angular enforces at runtime and run apply a definitive assignment assertion since angulars input binding is running before use
This commit is contained in:
Daniel Riera
2026-01-13 14:36:52 -05:00
committed by jaasen-livefront
parent fdacac989c
commit 5caf36c674
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/browser/src/autofill/popup/fido2/fido2-cipher-row.component.ts
View File

@@ -1,5 +1,3 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import { CommonModule } from "@angular/common";
import { Component, EventEmitter, Input, Output, ChangeDetectionStrategy } from "@angular/core";
@@ -33,13 +31,10 @@ export class Fido2CipherRowComponent {
@Output() onSelected = new EventEmitter<CipherView>();
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() cipher: CipherView;
@Input({ required: true }) cipher!: CipherView;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() last: boolean;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() title: string;
@Input({ required: true }) title!: string;
protected selectCipher(c: CipherView) {
this.onSelected.emit(c);