bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-05 03:03:26 +00:00
Code Issues Releases Wiki Activity

Fix broken vault test

Browse Source
This commit is contained in:
Jeffrey Holland
2025-08-20 18:20:28 +02:00
parent d4cdf6a922
commit 5d55b8feb3
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
apps/desktop/src/autofill/modal/credentials/fido2-vault.component.spec.ts
View File

@@ -50,7 +50,7 @@ describe("Fido2VaultComponent", () => {
mockAccountService.activeAccount$ = of(mockActiveAccount as Account);
mockFido2UserInterfaceService.getCurrentSession.mockReturnValue(mockSession);
mockSession.availableCipherIds$ = of(mockCipherIds);
mockCipherService.getAllDecryptedForIds.mockResolvedValue([]);
mockCipherService.cipherListViews$ = jest.fn().mockReturnValue(of([]));
await TestBed.configureTestingModule({
imports: [Fido2VaultComponent],
@@ -106,24 +106,31 @@ describe("Fido2VaultComponent", () => {
describe("ngOnInit", () => {
it("should initialize session and load ciphers successfully", async () => {
mockCipherService.getAllDecryptedForIds.mockResolvedValue(mockCiphers);
mockCipherService.cipherListViews$ = jest.fn().mockReturnValue(of(mockCiphers));
await component.ngOnInit();
expect(mockFido2UserInterfaceService.getCurrentSession).toHaveBeenCalled();
expect(component.session).toBe(mockSession);
expect(component.cipherIds$).toBe(mockSession.availableCipherIds$);
expect(mockCipherService.cipherListViews$).toHaveBeenCalledWith(mockActiveAccount.id);
});
it("should handle error when no active session found", async () => {
it("should handle when no active session found", async () => {
mockFido2UserInterfaceService.getCurrentSession.mockReturnValue(null);
await expect(component.ngOnInit()).rejects.toThrow();
await component.ngOnInit();
expect(component.session).toBeNull();
});
it("should filter out deleted ciphers", async () => {
mockCiphers[1].deletedDate = new Date();
mockCipherService.getAllDecryptedForIds.mockResolvedValue(mockCiphers);
const ciphersWithDeleted = [
...mockCiphers.slice(0, 1),
{ ...mockCiphers[1], deletedDate: new Date() },
...mockCiphers.slice(2),
];
mockCipherService.cipherListViews$ = jest.fn().mockReturnValue(of(ciphersWithDeleted));
await component.ngOnInit();
await new Promise((resolve) => setTimeout(resolve, 0));

2
apps/desktop/src/autofill/modal/credentials/fido2-vault.component.ts
View File

@@ -79,7 +79,7 @@ export class Fido2VaultComponent implements OnInit, OnDestroy {
async ngOnInit(): Promise<void> {
this.session = this.fido2UserInterfaceService.getCurrentSession();
this.cipherIds$ = this.session.availableCipherIds$;
this.cipherIds$ = this.session?.availableCipherIds$;
await this.loadCiphers();
}