bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-21 20:03:43 +00:00
Code Issues Releases Wiki Activity

Improve routing during account switching to ensure feature flags are triggered (#18037)

Browse Source 
When account switching from the old layout it's not bringing you into the new design. This resolves it by ensuring the route guard for vault is triggered after account switching.
This commit is contained in:
Oscar Hinton
2026-01-13 11:23:29 +01:00
committed by GitHub
parent bea6fb26f8
commit 5fe01323bb
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/desktop/src/app/app-routing.module.ts
View File

@@ -114,6 +114,8 @@ const routes: Routes = [
authGuard,
canAccessFeature(FeatureFlag.DesktopUiMigrationMilestone1, false, "new-vault", false),
],
// Needed to ensure feature flag changes are picked up on account switching
runGuardsAndResolvers: "always",
},
{
path: "send",

5
apps/desktop/src/app/app.component.ts
View File

@@ -492,9 +492,8 @@ export class AppComponent implements OnInit, OnDestroy {
this.loading = true;
await this.syncService.fullSync(false);
this.loading = false;
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate(["vault"]);
// Force reload to ensure route guards are activated
await this.router.navigate(["vault"], { onSameUrlNavigation: "reload" });
}
this.messagingService.send("finishSwitchAccount");
break;