Remove feature flag check from password generation

libs/common/src/tools/providers.ts

@@ -3,7 +3,6 @@ import { BitwardenClient } from "@bitwarden/sdk-internal";
 import { StateProvider } from "@bitwarden/state";
 
 import { PolicyService } from "../admin-console/abstractions/policy/policy.service.abstraction";
-import { ConfigService } from "../platform/abstractions/config/config.service";
 import { PlatformUtilsService } from "../platform/abstractions/platform-utils.service";
 
 import { LegacyEncryptorProvider } from "./cryptography/legacy-encryptor-provider";
@@ -22,9 +21,6 @@ export type SystemServiceProvider = {
   /** Event monitoring and diagnostic interfaces */
   readonly log: LogProvider;
 
-  /** Config Service to determine flag features */
-  readonly configService: ConfigService;
-
   /** Platform Service to inspect runtime environment */
   readonly environment: PlatformUtilsService;
 
@@ -40,7 +36,6 @@ export function createSystemServiceProvider(
   registry: ExtensionRegistry,
   logger: LogService,
   environment: PlatformUtilsService,
-  configService: ConfigService,
 ): SystemServiceProvider {
   let log: LogProvider;
   if (environment.isDev()) {
@@ -60,7 +55,6 @@ export function createSystemServiceProvider(
     policy,
     extension,
     log,
-    configService,
     environment,
   };
 }

libs/tools/generator/components/src/generator-services.module.ts

@@ -1,14 +1,11 @@
 import { NgModule } from "@angular/core";
-import { from, take } from "rxjs";
 
 import { JslibModule } from "@bitwarden/angular/jslib.module";
 import { safeProvider } from "@bitwarden/angular/platform/utils/safe-provider";
 import { SafeInjectionToken } from "@bitwarden/angular/services/injection-tokens";
 import { ApiService } from "@bitwarden/common/abstractions/api.service";
 import { PolicyService } from "@bitwarden/common/admin-console/abstractions/policy/policy.service.abstraction";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
 import { EncryptService } from "@bitwarden/common/key-management/crypto/abstractions/encrypt.service";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
 import { LogService } from "@bitwarden/common/platform/abstractions/log.service";
 import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
@@ -91,7 +88,6 @@ export const SYSTEM_SERVICE_PROVIDER = new SafeInjectionToken<SystemServiceProvi
         registry: ExtensionRegistry,
         logger: LogService,
         environment: PlatformUtilsService,
-        configService: ConfigService,
       ) => {
         let log: LogProvider;
         if (environment.isDev()) {
@@ -111,7 +107,6 @@ export const SYSTEM_SERVICE_PROVIDER = new SafeInjectionToken<SystemServiceProvi
           policy,
           extension,
           log,
-          configService,
         };
       },
       deps: [
@@ -121,7 +116,6 @@ export const SYSTEM_SERVICE_PROVIDER = new SafeInjectionToken<SystemServiceProvi
         ExtensionRegistry,
         LogService,
         PlatformUtilsService,
-        ConfigService,
       ],
     }),
     safeProvider({
@@ -141,18 +135,13 @@ export const SYSTEM_SERVICE_PROVIDER = new SafeInjectionToken<SystemServiceProvi
           now: Date.now,
         } satisfies UserStateSubjectDependencyProvider;
 
-        const featureFlagObs$ = from(
-          system.configService.getFeatureFlag(FeatureFlag.UseSdkPasswordGenerators),
-        );
-        let featureFlag: boolean = false;
-        featureFlagObs$.pipe(take(1)).subscribe((ff) => (featureFlag = ff));
         const metadata = new providers.GeneratorMetadataProvider(
           userStateDeps,
           system,
           Object.values(BuiltIn),
         );
 
-        const sdkService = featureFlag ? system.sdk : undefined;
+        const sdkService = system.sdk;
         const profile = new providers.GeneratorProfileProvider(userStateDeps, system.policy);
 
         const generator: providers.GeneratorDependencyProvider = {

libs/tools/generator/core/src/metadata/password/eff-word-list.ts

@@ -3,7 +3,7 @@ import { GENERATOR_DISK } from "@bitwarden/common/platform/state";
 import { PublicClassifier } from "@bitwarden/common/tools/public-classifier";
 import { ObjectKey } from "@bitwarden/common/tools/state/object-key";
 
-import { PasswordRandomizer, SdkPasswordRandomizer } from "../../engine";
+import { SdkPasswordRandomizer } from "../../engine";
 import { passphraseLeastPrivilege, PassphrasePolicyConstraints } from "../../policies";
 import { GeneratorDependencyProvider } from "../../providers";
 import { CredentialGenerator, PassphraseGenerationOptions } from "../../types";
@@ -30,9 +30,6 @@ const passphrase: GeneratorMetadata<PassphraseGenerationOptions> = {
     create(
       dependencies: GeneratorDependencyProvider,
     ): CredentialGenerator<PassphraseGenerationOptions> {
-      if (dependencies.sdk == undefined) {
-        return new PasswordRandomizer(dependencies.randomizer, dependencies.now);
-      }
       return new SdkPasswordRandomizer(dependencies.sdk, dependencies.now);
     },
   },

libs/tools/generator/core/src/metadata/password/random-password.ts

@@ -3,7 +3,7 @@ import { GENERATOR_DISK } from "@bitwarden/common/platform/state";
 import { PublicClassifier } from "@bitwarden/common/tools/public-classifier";
 import { deepFreeze } from "@bitwarden/common/tools/util";
 
-import { PasswordRandomizer, SdkPasswordRandomizer } from "../../engine";
+import { SdkPasswordRandomizer } from "../../engine";
 import { DynamicPasswordPolicyConstraints, passwordLeastPrivilege } from "../../policies";
 import { GeneratorDependencyProvider } from "../../providers";
 import { CredentialGenerator, PasswordGeneratorSettings } from "../../types";
@@ -30,9 +30,6 @@ const password: GeneratorMetadata<PasswordGeneratorSettings> = deepFreeze({
     create(
       dependencies: GeneratorDependencyProvider,
     ): CredentialGenerator<PasswordGeneratorSettings> {
-      if (dependencies.sdk == undefined) {
-        return new PasswordRandomizer(dependencies.randomizer, dependencies.now);
-      }
       return new SdkPasswordRandomizer(dependencies.sdk, dependencies.now);
     },
   },

libs/tools/generator/core/src/providers/generator-metadata-provider.spec.ts

@@ -5,7 +5,6 @@ import { PolicyService } from "@bitwarden/common/admin-console/abstractions/poli
 import { PolicyType } from "@bitwarden/common/admin-console/enums";
 import { Policy } from "@bitwarden/common/admin-console/models/domain/policy";
 import { Account } from "@bitwarden/common/auth/abstractions/account.service";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { LegacyEncryptorProvider } from "@bitwarden/common/tools/cryptography/legacy-encryptor-provider";
 import { UserEncryptor } from "@bitwarden/common/tools/cryptography/user-encryptor.abstraction";
 import {
@@ -96,8 +95,6 @@ const SomePolicyService = mock<PolicyService>();
 
 const SomeExtensionService = mock<ExtensionService>();
 
-const SomeConfigService = mock<ConfigService>;
-
 const SomeSdkService = mock<BitwardenClient>;
 
 const ApplicationProvider = {
@@ -110,9 +107,6 @@ const ApplicationProvider = {
   /** Event monitoring and diagnostic interfaces */
   log: disabledSemanticLoggerProvider,
 
-  /** Feature flag retrieval */
-  configService: SomeConfigService,
-
   /** SDK access for password generation */
   sdk: SomeSdkService,
 } as unknown as SystemServiceProvider;