[PM-32442] Enforce tsc-strict on desktop and CLI apps (#19058)

* fix: ts-strict not applying to desktop

* fix: ts-strict not applying to cli

* fix: desktop ESM module resolution in storybook

.storybook/tsconfig.json

@@ -1,7 +1,8 @@
 {
   "extends": "../tsconfig",
   "compilerOptions": {
-    "allowSyntheticDefaultImports": true
+    "allowSyntheticDefaultImports": true,
+    "moduleResolution": "bundler"
   },
   "exclude": ["../src/test.setup.ts", "../apps/**/*.spec.ts", "../libs/**/*.spec.ts"],
   "files": [

apps/cli/src/commands/get.command.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { filter, firstValueFrom, map, switchMap } from "rxjs";
 
 import { CollectionService } from "@bitwarden/admin-console/common";

apps/cli/src/utils.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import * as fs from "fs";
 import * as path from "path";
 

apps/cli/src/vault/delete.command.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom } from "rxjs";
 
 import { ApiService } from "@bitwarden/common/abstractions/api.service";

apps/cli/src/vault/models/attachment.response.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { AttachmentView } from "@bitwarden/common/vault/models/view/attachment.view";
 
 export class AttachmentResponse {

apps/desktop/src/autofill/modal/credentials/fido2-create.component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { CommonModule } from "@angular/common";
 import { ChangeDetectionStrategy, Component, OnInit, OnDestroy } from "@angular/core";
 import { RouterModule, Router } from "@angular/router";

apps/desktop/src/autofill/modal/credentials/fido2-excluded-ciphers.component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { CommonModule } from "@angular/common";
 import { ChangeDetectionStrategy, Component, OnInit, OnDestroy } from "@angular/core";
 import { RouterModule, Router } from "@angular/router";

apps/desktop/src/autofill/modal/credentials/fido2-vault.component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { CommonModule } from "@angular/common";
 import { ChangeDetectionStrategy, Component, OnInit, OnDestroy } from "@angular/core";
 import { RouterModule, Router } from "@angular/router";

apps/desktop/src/autofill/services/desktop-autofill.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Injectable, OnDestroy } from "@angular/core";
 import {
   Subject,

apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Router } from "@angular/router";
 import {
   lastValueFrom,

apps/desktop/src/entry.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { spawn } from "child_process";
 import * as path from "path";
 

apps/desktop/src/main/updater.main.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { dialog, shell, Notification } from "electron";
 import log from "electron-log";
 import { autoUpdater, UpdateDownloadedEvent, VerifyUpdateSupport } from "electron-updater";

apps/desktop/src/vault/app/vault/assign-collections/assign-collections-desktop.component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { DIALOG_DATA, DialogConfig, DialogRef } from "@angular/cdk/dialog";
 import { Component, Inject } from "@angular/core";
 

apps/desktop/src/vault/app/vault/vault-filter/filters/status-filter.component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Component, viewChild } from "@angular/core";
 import { combineLatest, firstValueFrom, map, switchMap } from "rxjs";
 

apps/desktop/src/vault/app/vault/vault-v2.component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { CommonModule } from "@angular/common";
 import {
   ChangeDetectorRef,

tsconfig.json

@@ -1,8 +1,10 @@
 {
   "extends": "./tsconfig.base.json",
   "include": [
-    "apps/web/src/**/*",
     "apps/browser/src/**/*",
+    "apps/cli/src/**/*",
+    "apps/desktop/src/**/*",
+    "apps/web/src/**/*",
     "libs/*/src/**/*",
     "libs/tools/send/**/src/**/*",
     "libs/dirt/card/src/**/*",
@@ -10,8 +12,10 @@
     "bitwarden_license/bit-common/src/**/*"
   ],
   "exclude": [
-    "apps/web/src/**/*.spec.ts",
     "apps/browser/src/**/*.spec.ts",
+    "apps/cli/src/**/*.spec.ts",
+    "apps/desktop/src/**/*.spec.ts",
+    "apps/web/src/**/*.spec.ts",
     "libs/*/src/**/*.spec.ts",
     "**/*.spec-util.ts"
   ]