bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-26 17:43:22 +00:00
Code Issues Releases Wiki Activity

Add signing options for DLLs and Node files (#19197)

Browse Source
This commit is contained in:
Vince Grassia
2026-02-25 13:25:12 -05:00
committed by GitHub
parent 2e38f409ec
commit 727bc02a63
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
apps/desktop/electron-builder.beta.json
View File

@@ -32,6 +32,7 @@
"win": {
"electronUpdaterCompatibility": ">=0.0.1",
"target": ["portable", "nsis-web", "appx"],
"signExts": [".dll", ".node"],
"signtoolOptions": {
"sign": "./sign.js"
},

1
apps/desktop/electron-builder.json
View File

@@ -93,6 +93,7 @@
"win": {
"electronUpdaterCompatibility": ">=0.0.1",
"target": ["portable", "nsis-web", "appx"],
"signExts": [".dll", ".node"],
"signtoolOptions": {
"sign": "./sign.js"
},

7
apps/desktop/sign.js
View File

@@ -3,7 +3,7 @@ const child_process = require("child_process");
exports.default = async function (configuration) {
const ext = configuration.path.split(".").at(-1);
if (parseInt(process.env.ELECTRON_BUILDER_SIGN) === 1 && ["exe"].includes(ext)) {
if (parseInt(process.env.ELECTRON_BUILDER_SIGN) === 1 && ["exe", "dll", "node"].includes(ext)) {
console.log(`[*] Signing file: ${configuration.path}`);
child_process.execFileSync(
"azuresigntool",
@@ -25,7 +25,10 @@ exports.default = async function (configuration) {
stdio: "inherit",
},
);
} else if (process.env.ELECTRON_BUILDER_SIGN_CERT && ["exe", "appx"].includes(ext)) {
} else if (
process.env.ELECTRON_BUILDER_SIGN_CERT &&
["exe", "dll", "node", "appx"].includes(ext)
) {
console.log(`[*] Signing file: ${configuration.path}`);
if (process.platform !== "win32") {
console.warn(