bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-12 22:44:11 +00:00
Code Issues Releases Wiki Activity

link up remaining props to risk insight report

Browse Source
This commit is contained in:
jaasen-livefront
2024-12-12 12:07:46 -08:00
parent b01d4d067d
commit 7d70c18331
4 changed files with 12 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitwarden_license/bit-common/src/tools/reports/risk-insights/models/password-health.ts
View File

@@ -25,7 +25,7 @@ export type ApplicationHealthReportDetail = {
passwordCount: number;
atRiskPasswordCount: number;
memberCount: number;
atRiskMemberCount: number;
memberDetails: MemberDetailsFlat[];
atRiskMemberDetails: MemberDetailsFlat[];
};

1
bitwarden_license/bit-common/src/tools/reports/risk-insights/services/risk-insights-report.service.ts
View File

@@ -290,6 +290,7 @@ export class RiskInsightsReportService {
: newUriDetail.cipherMembers,
atRiskMemberDetails: existingUriDetail ? existingUriDetail.atRiskMemberDetails : [],
atRiskPasswordCount: existingUriDetail ? existingUriDetail.atRiskPasswordCount : 0,
atRiskMemberCount: existingUriDetail ? existingUriDetail.atRiskMemberDetails.length : 0,
} as ApplicationHealthReportDetail;
if (isAtRisk) {

11
bitwarden_license/bit-web/src/app/tools/access-intelligence/all-applications.component.html
View File

@@ -65,11 +65,11 @@
<ng-container header>
<tr>
<th *ngIf="isCriticalAppsFeatureEnabled"></th>
<th bitSortable="name" bitCell>{{ "application" | i18n }}</th>
<th bitSortable="atRiskPasswords" bitCell>{{ "atRiskPasswords" | i18n }}</th>
<th bitSortable="totalPasswords" bitCell>{{ "totalPasswords" | i18n }}</th>
<th bitSortable="atRiskMembers" bitCell>{{ "atRiskMembers" | i18n }}</th>
<th bitSortable="totalMembers" bitCell>{{ "totalMembers" | i18n }}</th>
<th bitSortable="applicationName" bitCell>{{ "application" | i18n }}</th>
<th bitSortable="atRiskPasswordCount" bitCell>{{ "atRiskPasswords" | i18n }}</th>
<th bitSortable="passwordCount" bitCell>{{ "totalPasswords" | i18n }}</th>
<th bitSortable="atRiskMemberCount" bitCell>{{ "atRiskMembers" | i18n }}</th>
<th bitSortable="memberCount" bitCell>{{ "totalMembers" | i18n }}</th>
</tr>
</ng-container>
<ng-template body let-rows$>
@@ -100,7 +100,6 @@
{{ r.atRiskMemberCount }}
</span>
</td>
w
<td bitCell data-testid="total-membership">
{{ r.memberCount }}
</td>

15
bitwarden_license/bit-web/src/app/tools/access-intelligence/all-applications.component.ts
View File

@@ -1,5 +1,3 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import { Component, DestroyRef, inject, OnInit } from "@angular/core";
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
import { FormControl } from "@angular/forms";
@@ -15,14 +13,11 @@ import {
ApplicationHealthReportDetail,
ApplicationHealthReportSummary,
} from "@bitwarden/bit-common/tools/reports/risk-insights/models/password-health";
import { AuditService } from "@bitwarden/common/abstractions/audit.service";
import { OrganizationService } from "@bitwarden/common/admin-console/abstractions/organization/organization.service.abstraction";
import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service";
import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
import {
Icons,
NoItemsModule,
@@ -82,6 +77,8 @@ export class AllApplicationsComponent implements OnInit {
next: (applications: ApplicationHealthReportDetail[]) => {
if (applications) {
this.dataSource.data = applications;
const summary = this.reportService.generateApplicationsSummary(applications);
this.applicationSummary = summary;
this.loading = false;
}
},
@@ -90,14 +87,12 @@ export class AllApplicationsComponent implements OnInit {
constructor(
protected cipherService: CipherService,
protected riskInsightsReportService: RiskInsightsReportService,
protected auditService: AuditService,
protected i18nService: I18nService,
protected activatedRoute: ActivatedRoute,
protected toastService: ToastService,
protected organizationService: OrganizationService,
protected configService: ConfigService,
protected dataService: RiskInsightsDataService,
protected reportService: RiskInsightsReportService,
) {
this.searchControl.valueChanges
.pipe(debounceTime(200), takeUntilDestroyed())
@@ -130,8 +125,8 @@ export class AllApplicationsComponent implements OnInit {
});
};
trackByFunction(_: number, item: CipherView) {
return item.id;
trackByFunction(_: number, item: ApplicationHealthReportDetail) {
return item.applicationName;
}
onCheckboxChange(id: number, event: Event) {