bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-02 17:53:41 +00:00
Code Issues Releases Wiki Activity

small cleanup

Browse Source
This commit is contained in:
Anders Åberg
2025-07-07 17:08:16 +02:00
parent 83fba37e03
commit 7edebe8160
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/desktop/desktop_native/windows_plugin_authenticator/src/com_provider.rs
View File

@@ -352,8 +352,7 @@ impl EXPERIMENTAL_IPluginAuthenticator_Impl for PluginAuthenticatorComObject_Imp
} => {
util::message("Creating WebAuthn make credential response");
match create_make_credential_response(credential_id, attestation_object)
{
match create_make_credential_response(attestation_object) {
Ok(webauthn_response) => {
util::message("Successfully created WebAuthn response");
*response = webauthn_response;

3
apps/desktop/desktop_native/windows_plugin_authenticator/src/make_credential.rs
View File

@@ -196,7 +196,7 @@ pub fn send_registration_request(
user_name: request.user_name.clone(),
client_data_hash: request.client_data_hash.clone(),
user_verification: request.user_verification.clone(),
window_xy: Position { x: 400, y: 400 },
window_xy: Position { x: 400, y: 400 }, // TODO: Get actual window position
supported_algorithms: request.supported_algorithms.clone(),
excluded_credentials: request.excluded_credentials.clone(),
};
@@ -218,7 +218,6 @@ pub fn send_registration_request(
/// Creates a WebAuthn make credential response from Bitwarden's registration response
pub unsafe fn create_make_credential_response(
credential_id: Vec<u8>,
attestation_object: Vec<u8>,
) -> std::result::Result<*mut ExperimentalWebAuthnPluginOperationResponse, HRESULT> {
// Use the attestation object directly as the encoded response