1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-16 16:59:30 +00:00

fix(eslint): clean up new lint errors

This commit is contained in:
addisonbeck
2025-06-04 15:02:01 -04:00
parent a3bb4eab86
commit 81b6ad1b92
7 changed files with 15 additions and 0 deletions

View File

@@ -24,6 +24,8 @@ export class ExtensionLoginDecryptionOptionsService
// start listening for "switchAccountFinish" or "doneLoggingOut"
const messagePromise = firstValueFrom(postLogoutMessageListener$);
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
super.logOut();
// wait for messages

View File

@@ -54,6 +54,8 @@ export class AcceptProviderComponent extends BaseAcceptComponent {
this.i18nService.t("providerInviteAcceptedDesc"),
{ timeout: 10000 },
);
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate(["/vault"]);
}

View File

@@ -17,6 +17,8 @@ export class SetupProviderComponent extends BaseAcceptComponent {
requiredParameters = ["providerId", "email", "token"];
async authedHandler(qParams: Params) {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate(["/providers/setup"], { queryParams: qParams });
}
@@ -25,6 +27,8 @@ export class SetupProviderComponent extends BaseAcceptComponent {
}
login() {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate(["/login"], { queryParams: { email: this.email } });
}
}

View File

@@ -100,6 +100,8 @@ export class LoginApprovalComponent implements OnInit, OnDestroy {
this.updateTimeText();
}, RequestTimeUpdate);
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.loginApprovalComponentService.showLoginRequestedAlertIfWindowNotVisible(this.email);
this.loading = false;

View File

@@ -137,6 +137,8 @@ export class NewDeviceVerificationComponent implements OnInit, OnDestroy {
return;
}
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.loginSuccessHandlerService.run(authResult.userId);
// If verification succeeds, navigate to vault

View File

@@ -265,6 +265,8 @@ export class TwoFactorAuthComponent implements OnInit, OnDestroy {
private listenForAuthnSessionTimeout() {
this.loginStrategyService.authenticationSessionTimeout$
.pipe(takeUntilDestroyed(this.destroyRef))
// TODO: Fix this!
// eslint-disable-next-line rxjs/no-async-subscribe
.subscribe(async (expired) => {
if (!expired) {
return;

View File

@@ -256,6 +256,7 @@ export class DefaultKeyService implements KeyServiceAbstraction {
}
if (keySuffix === KeySuffixOptions.Pin && userId != null) {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.pinService.clearPinKeyEncryptedUserKeyEphemeral(userId);
}
}