bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-31 00:33:33 +00:00
Code Issues Releases Wiki Activity

feat(pricing): Add quantity support to discount labels

Browse Source
This commit is contained in:
Stephon Brown
2026-01-27 18:44:34 -05:00
parent 8eda352f57
commit 8350fdd90f
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
libs/pricing/src/types/discount.ts
View File

@@ -7,13 +7,24 @@ export const DiscountTypes = {
export type DiscountType = (typeof DiscountTypes)[keyof typeof DiscountTypes];
/**
* Represents a discount that can be applied to a price.
* - type: The type of discount (amount-off or percent-off).
* - value: The value of the discount. For amount-off, this is a fixed amount (e.g., 5 for $5 off).
* For percent-off, this is a percentage (e.g., 10 for 10% off).
* - translationKey: An optional key for localization of the discount label.
* - quantity: An optional quantity associated with the discount (e.g., number of items).
* note: when quantity is provided, it is displayed in the label instead of the value.
*/
export type Discount = {
type: DiscountType;
value: number;
translationKey?: string;
quantity?: number;
};
export const getLabel = (i18nService: I18nService, discount: Discount): string => {
const showQuantity = discount.quantity != null && discount.quantity > 0;
switch (discount.type) {
case DiscountTypes.AmountOff: {
const formattedAmount = new Intl.NumberFormat("en-US", {
@@ -22,7 +33,7 @@ export const getLabel = (i18nService: I18nService, discount: Discount): string =
minimumFractionDigits: 2,
maximumFractionDigits: 2,
}).format(discount.value);
return `${formattedAmount} ${i18nService.t(discount.translationKey ?? "discount")}`;
return `${showQuantity ? discount.quantity : formattedAmount} ${i18nService.t(discount.translationKey ?? "discount")}`;
}
case DiscountTypes.PercentOff: {
const percentValue = discount.value < 1 ? discount.value * 100 : discount.value;